[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:167 + for (const auto &Param : Fn->args()) { +if (Param.hasStructRetAttr()) { + // FIXME: support output. beanz wrote: > python3kgae wrote: > > beanz wrote: > > > I might

[PATCH] D134998: [HLSL] [Driver] Add -no-legacy-cbuf-layout to control layout for cbuffer.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Two new options a

[PATCH] D134921: [HLSL] add cos library function

python3kgae added a comment. In D134921#3828545 , @bob80905 wrote: > - lower cos to llvm This will affect things outside HLSL. Please create a new PR without HLSL related part. Sorry I didn't make things clear before :(. You can copy what https://gith

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added subscribers: kosarev, Anastasia, mattd, gchakrabarti, asavonic, kerbowa, jvesely. Herald added a reviewer: aaron.ballman. Herald added a project: All. python3kgae requested review of this revision.

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/include/llvm/Frontend/HLSL/HLSLResource.h:35 + GlobalVariable *getGlobalVariable(); + StringRef getSourceType(); + Constant *getID(); Could we save things like shape and component type instead of a StringRef

[PATCH] D135011: Add sin and cos llvm builtins

python3kgae added a comment. In D135011#3831949 , @rjmccall wrote: > The titled of this patch should be something like "Add > __builtin_elementwise_sin and __builtin_elementwise_cos". > > Can you explain why this uses a new builtin name instead of overlo

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added a comment. In D135011#3831452 , @craig.topper wrote: > Does these support scalable vector types from ARM SVE or RISC-V? I can't > remember what the rest of the __builtin_elementwise do. I ask because the > backends will probably crash

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae updated this revision to Diff 465115. python3kgae added a comment. Limit MaybeParseHLSLSemantics to HLSL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134617/new/ https://reviews.llvm.org/D134617 Files: clang/include/clang/Basic/Att

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2817-2818 + void MaybeParseHLSLSemantics(Declarator &D, + SourceLocation *EndLoc = nullptr) { +if (Tok.is(tok::colo

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added a comment. In D135011#3834739 , @bob80905 wrote: > Here is the code I used to test the machine code output: > > typedef float float4 __attribute__((ext_vector_type(4))); > > void test_builtin_elementwise_sin(float f1, float f2, do

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG15aa64301ab1: [HLSL] Support register binding attribute on global variable (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

python3kgae updated this revision to Diff 465441. python3kgae added a comment. Update to match comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/ https://reviews.llvm.org/D134330 Files: clang/docs/HLSL/HLSLSupport.rst Index: cl

[PATCH] D135335: [HLSL] Add Resource kind for HLSLResourceAttr.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 465628. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clang/Basic/AddressSpaces.h clang/include/cla

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 465661. python3kgae added a comment. Fix test fail caused by max address space change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clan

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae added a comment. In D133993#3840838 , @efriedma wrote: > It seems like it would be better to put the code in an LLVM IR transform > pass, if we can. It separates the concerns more clearly, and it would make > life easier for other compilers.

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bdfececef43: [HLSL] Remove global ctor/dtor variable for non-lib profile. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/ne

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae created this revision. python3kgae added reviewers: efriedma, pow2clk, beanz, bogner. Herald added subscribers: Anastasia, hiraditya. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, c

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. Hi, @rjmccall and @efriedma, Could you take a look at this PR? Or should I find someone else to review it? Thanks Xiang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 __

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6f10fd23b2: [Docs] [HLSL] Add note about PCH support (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/ https://reviews.

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 466141. python3kgae marked 5 inline comments as done. python3kgae added a comment. Fix test fail after rebase and code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ ht

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. In D135429#3843906 , @efriedma wrote: > You might actually want to run this twice, once early, and once in the > backend. Early to get high-quality optimization, late in case optimizations > don't run for some reason. (Not

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. In D135429#3844179 , @efriedma wrote: > In D135429#3844172 , @efriedma > wrote: > >>> The pass will be always enabled in >>> registerPipelineEarlySimplificationEPCallback (Not contro

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 466382. python3kgae added a comment. Change Category to DocCatVariable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clang/Basic/Address

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

python3kgae added a comment. Backend needs the same thing. Is it possible to move this to llvm and share it between frontend and backend? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135595/new/ https://reviews.llvm.org/D135595 __

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae updated this revision to Diff 466623. python3kgae added a comment. Add end of file newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

python3kgae added a comment. In D135595#3847158 , @beanz wrote: > In D135595#3847056 , @python3kgae > wrote: > >> Backend needs the same thing. >> Is it possible to move this to llvm and share it between frontend

[PATCH] D135335: [HLSL] Add Resource kind for HLSLResourceAttr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb267ac49e764: [HLSL] Add Resource kind for HLSLResourceAttr. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135335/new/ https://re

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 466925. python3kgae marked 12 inline comments as done. python3kgae added a comment. Code cleanup to match comments. Reuse opencl error. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ ht

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4045 +def HLSLGroupSharedAddressSpace : TypeAttr { + let Spellings = [Keyword<"groupshared">, Clang<"groupshared">]; + let Documentation = [HLSLGroupSharedAddressSpaceDocs]; aaron.

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); Should this

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); gracejenning

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 467285. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add SubjectList<[Var]> and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D1

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/SemaHLSL/group_shared.hlsl:57 + // expected-error@+1 {{no matching function for call to 'tfoo'}} + GSF gs2 = tfoo(gs); aaron.ballman wrote: > Some other Sema t

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 467318. python3kgae marked an inline comment as done. python3kgae added a comment. Go llvm_unreachable is hit HLSLBuffer inside function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://re

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:131 case Decl::RequiresExprBody: + case Decl::HLSLBuffer: // None of these decls require codegen support. efriedma wrote: > I'm a li

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rGebe9c7f3e2da: [HLSL] CodeGen hlsl cbuffer/tbuffer. (authored by python3kgae). Repository: rG LLVM Gi

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:11 +// expected-warning@+1 {{'auto' type specifier is a C++11 extension}} +auto l = []() groupshared {}; + beanz wrote: > What ha

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 467383. python3kgae marked an inline comment as done. python3kgae added a comment. Add hlsl202x test for C++ 11 features like lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://review

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so w

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467631. python3kgae added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add resource shape to metadata. Conflict with https://reviews.llvm.org/D135110, will rebase once https://reviews.llvm.org/D135110 is in.

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467812. python3kgae added a comment. Fix clang-format missed by arc lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files: clang/include/clang/Basic/HLSLRu

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467909. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase to use FrontendResource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); gracejenning

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468047. python3kgae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. arc diff `git merge-base HEAD origin` --update D136031 to fix the apply patch issue Repository: rG LLVM Gith

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 468053. python3kgae added a comment. Rebase for D136031 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files: clang/lib/Code

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 468054. python3kgae added a comment. Rebase to fix stack patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:73 CodeGenModule &CGM; uint32_t ResourceCounters[static_cast( hlsl::ResourceClass::NumClasses)] = {0}; beanz wrote: > The `ResourceCounters` here was a stand-in for allo

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13163dd8abc5: [HLSL] CodeGen hlsl resource binding. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llv

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Move Re

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae added a comment. Merry Christmas and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews.llvm.org/D139935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 485747. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp llvm/lib/Targ

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae added a comment. Happy new year and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139935/new/ https://reviews.llvm.org/D139935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486070. python3kgae added a comment. Use llvm::TypeSize and uint32_t instead of unsigned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target

[PATCH] D140992: clang: Add __builtin_elementwise_fma

python3kgae added a comment. Need update clang/docs/ReleaseNotes.rst for new intrinsic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 486390. python3kgae added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayout.cpp llvm/

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad48e9669a80: [NFC] [Doc] Fix example for AnnotateTypeDocs (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D140489: Add builtin_elementwise_log

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:638 T __builtin_elementwise_floor(T x) return the largest integral value less than or equal to xfloating point types + T __builtin_elementwise_log(T x)return the natur

[PATCH] D135721: [HLSL] Added HLSL this as a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference (authored by gracejennings, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1357

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added inline comments. Comment at: clang/test/Sema/aarch64-sve-vector-trig-ops.c:4 +// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify + +#include Need limit to aarch64 enabled with // REQUIRES: aarch64-registered-target

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5d14f757bb1: Add builtin_elementwise_sin and builtin_elementwise_cos (authored by bob80905, committed by python3kgae). Changed prior to commit: https://reviews.llvm.org/D135011?vs=474628&id=474667#toc

[PATCH] D134921: [HLSL] add cos library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG9777e98a610f: [HLSL] add cos library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ ht

[PATCH] D138161: [HLSL] add sin library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG083d949f3800: [HLSL] add sin library function (authored by bob80905, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138161/new/ ht

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492559. python3kgae marked an inline comment as done. python3kgae added a comment. Only create dxv job when 'dxv' exist. Test ccc-print-bindings. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added a comment. In D141705#4082935 , @jhuber6 wrote: > I'm not overly familiar with HLSL or DirectX here. Most of the changes are > purely mechanical, but I don't see anywhere we create the tool.

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492878. python3kgae marked 9 inline comments as done. python3kgae added a comment. add DX_CONTAINER Driver type. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only a

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, +

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 6 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER, IN

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492894. python3kgae marked 2 inline comments as done. python3kgae added a comment. cast ToolChain to HLSLToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492912. python3kgae marked 2 inline comments as done. python3kgae added a comment. switch to getDefaultToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto &TC = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(&TC); +if (HLSLTC->needValida

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } jhuber6 wrote: > nit. remember to `clang-format` arc did find some clang-fo

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492931. python3kgae marked an inline comment as done. python3kgae added a comment. rename to requiresValidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 F

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { jhuber6 wrote: > python3kgae wro

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492941. python3kgae marked 2 inline comments as done. python3kgae added a comment. Fix windows test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 Files:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7 +// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s -Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH +// DXV_P

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 493149. python3kgae marked 2 inline comments as done. python3kgae added a comment. add space for warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; MaskRay wrote: > python3k

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5a7439e220c: [HLSL] [Dirver] add dxv as a VerifyDebug Job (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

python3kgae added a comment. Add log2 together? They're in same category. Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:19 +} \ No newline at end of file newline. Comment at: clang/test/SemaCXX/builtins-elementwise-math.cpp:90 +}

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 488707. python3kgae added a comment. Fix test fail after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Files: llvm/lib/Target/DirectX/CBufferDataLayou

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG944f4b280585: [DirectX backend] add support ConstantBuffer to DXILResource.h (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. New opt

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae updated this revision to Diff 489935. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add BinaryAnalyzeJobClass. Add -Vd to disable validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https:/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae added a comment. In D141705#4059162 , @beanz wrote: > Re-using the `VerifyDebug` action really doesn't make sense. That's not what > the DXIL validator does, and it will be a source of confusion forever. Added BinaryAnalyzeJobClass. Reposi

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae added a comment. In D136031#4062756 , @beanz wrote: > @python3kgae, this change introduced a bunch of warning spew because it is > using an API that was deprecated shortly before the change merged. Can you > please address this? Sure. I'll

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 490274. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files: clang/include/clang/Sema/HLSLExternalSemaSou

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. Gentle Ping. All the previous issues are fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 ___ cfe-commits mailing list cfe-c

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 436898. python3kgae added a comment. Fix typo in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { bogner wrote: > typo, should be `C

[PATCH] D127802: [HLSL] Support HLSL vector initializers

python3kgae added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} -

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > beanz wrote: > >

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

python3kgae added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:1022 +new HLSLExternalSemaSource()); +CI.getASTContext().setExternalSource(HLSLSema); + } Does this mean features like PCH which use ExternalSource will not work an

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 438220. python3kgae added a comment. Change CXXABI to Microsoft to match dxc behavior. The mangle name for half is "$f16@" when half is treat as native half type and "$halff@" when treat as float. And now in AST, half is still half. Only in clang codeGen

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 439463. python3kgae marked 3 inline comments as done. python3kgae added a comment. Cleanup comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clan

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added a comment. Thanks for the review. Updated the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 ___ cfe-commits mailing list cfe-commi

[PATCH] D124790: [HLSL] Enable half type for hlsl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f72ac15bca: [HLSL] Enable half type for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.or

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

<    1   2   3   4   5   >