python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7
+// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s 
-Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH
+// DXV_PATH:dxv" "-" "-o" "-"
+
----------------
jhuber6 wrote:
> Would this be called `dxv.exe` on Windows?
Good catch.
Changed to dxv{{(.exe)?}}"

Thanks a lot for the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to