python3kgae added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." + " Resulting DXIL will not be signed for use in release environments.">; ---------------- MaskRay wrote: > python3kgae wrote: > > beanz wrote: > > > Not all `dxv` binaries can sign… some just validate. Only the “official” > > > releases support signing. > > Fixed. > Make sure there is a space after `.`. The diagnostics convention does not > include the trailing period. Good catch! Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
