[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:9-12 +else() + # ... unless explicily overridden + set(LIBCLANG_SOVERSION ${CLANG_VERSION_MAJOR}) +endif() h-vetinari wrote: > Sorry I didn't get to comment in time, but now that the

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added a comment. In D132486#3748546 , @thakis wrote: > Was this reviewed by anyone on the original change? As far as I can tell, > there was no agreement on the original change or here that reverting is the > way to go. Was this discussed elsewhe

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

thieta added a comment. I think we should define a policy for this. I doubt we have many users on these older versions but I think maybe we should give deprecation messages for at least one release before we drop it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

thieta added a comment. This looks fine to me in principle. But I wonder if we should land the flag change first separately and make sure that no buildbots break because of it. Then we can merge the simplification a few days later when we are sure it's stabilized, since something similar happen

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta created this revision. thieta added reviewers: aganea, rnk, thakis, aeubanks. Herald added a subscriber: hiraditya. Herald added a project: All. thieta requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. As discussed in https://revi

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thieta added a comment. I posted https://reviews.llvm.org/D137322 to remove `-fmessage-length` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits m

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch code like this: if (Class* obj{getObject()}) {

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta updated this revision to Diff 473169. thieta added a comment. Expand and move testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta marked 2 inline comments as done. thieta added a comment. I have expanded testing and moved it to the place you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 __

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70de684d4413: [clang-format] Handle object instansiation in if-statements (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta added a reviewer: hans. thieta added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta updated this revision to Diff 473912. thieta added a comment. Updated from feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 Files: clang/test/CodeGen/debug-info-codeview-buildinfo.c llv

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta added a comment. Thanks @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa99b607b5cf: [clang][pdb] Don't include -fmessage-length in PDB buildinfo (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta accepted this revision as: thieta. thieta added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Thanks for fixing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-co

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta created this revision. thieta added reviewers: hans, mstorsjo. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Also make the output of -emit-ast end up where /Fo or /o points. The same with .plist file

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones i

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. In D128409#3604460 , @hans wrote: > I'm unfamiliar with -emit-ast. Can you add some background on what this is > for? What's CTU? CTU is cross translation unit. In this case the clang-static-analyzer can do analysis over several

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 439341. thieta added a comment. Removed unintentional whitespace removal and landed that as a NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/includ

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta requested changes to this revision. thieta added a comment. This revision now requires changes to proceed. Thanks for fixing - but it's not completely accurate right now. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for deb

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983 __

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

thieta added a comment. Yes, I can do that, but I rather wait for @balazske to also approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983 ___ cfe-commit

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540301. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540302. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h lld/test/COFF/print-search-paths

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540304. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h lld/test/COFF/print-search-paths

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta marked 6 inline comments as done. thieta added a comment. - Split the relative patch to this diff https://reviews.llvm.org/D155268 - Added some comments in both Clang and LLD - Fixed some code style. - Removed stray changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155273: [clang-format] Add TypeNames option to disambiguate types/objects

thieta added a comment. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155273/new/ https://reviews.llvm.org/D155273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

thieta updated this revision to Diff 540344. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151188/new/ https://reviews.llvm.org/D151188 Files: clang/lib/Driver/Driver.cpp lld/COFF/Driver.cpp lld/COFF/Driver.h lld/docs/ReleaseNotes.rst lld/

[PATCH] D151188: [LLD][COFF] Add LLVM toolchain library paths by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf744f0b84e2: [LLD][COFF] Add LLVM toolchain library paths by default. (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

thieta added a comment. I tried to look up what these options do exactly - but they don't seem to be documented. `/d1nodatetime` seems like an option that should be implemented instead of just ignored since it can have real reproducible problems not being there. Do you know what `/d1import_no_

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

thieta added a comment. Makes sense they are not documented and we probably can ignore them in that case! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139167/new/ https://reviews.llvm.org/D139167 ___ c

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4233290 , @MyDeveloperDay wrote: > because of https://github.com/llvm/llvm-project/issues/61785 should this > really be reverted? is basically saying `X * Y {` must be `X *Y{` but that > obviously not the case Tri

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. This was released in LLVM 16.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. Herald added a reviewer: rymiel. In D137327#4235255 , @MyDeveloperDay wrote: > In D137327#4234463 , @thieta wrote: > >> This was released in LLVM 16.0.0. > > The prior behaviour was there

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta added a comment. In D137327#4267342 , @MyDeveloperDay wrote: > You have commit rights correct? you really need to own your change especially > if it causes a regression. Alright - I did that now. Sorry I am just used to be on the other side as m

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd3c26a045c0: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta created this revision. thieta added reviewers: aaron.ballman, rsmith, tbaeder, saudi. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes so that declspec attributes are forwarded to t

[PATCH] D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names

thieta added a comment. @brad is this something you still need for OpenBSD? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138254/new/ https://reviews.llvm.org/D138254 ___ cfe-commits mailing list cfe-com

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta updated this revision to Diff 496906. thieta marked 2 inline comments as done. thieta added a comment. - Expand on tests - Fix crash when Attrs was null - Added release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143632/new/ https://r

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta marked an inline comment as done. thieta added a comment. Thanks for your comments - feel free to comment on the release note, I was struggling with describing the fix well for a short release note paragraph. Comment at: clang/lib/Parse/ParseDecl.cpp:61-63 + for (Parse

[PATCH] D143632: [clang] Handle __declspec() attributes in using

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG877859a09bda: [clang] Handle __declspec() attributes in using (authored by thieta). Changed prior to commit: https://reviews.llvm.org/D143632?vs=4

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta added a comment. Thanks for the review and the explanations! I fixed your nits and landed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143632/new/ https://reviews.llvm.org/D143632 ___ cfe-c

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

thieta created this revision. thieta added reviewers: jhenderson, JDevlieghere, MatzeB. Herald added subscribers: PiotrZSL, kadircet, mattd, asavonic, carlosgalvezp, abrachet, phosek, arphaman, fedor.sergeev, whisperity. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

thieta added inline comments. Comment at: clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py:9 # -#======# +# ===---

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

thieta updated this revision to Diff 523680. thieta added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150761/new/ https://reviews.llvm.org/D150761 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-a

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta added a comment. I think this is ready to land @Mordante or is there anything else missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commi

[PATCH] D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names

thieta added a comment. If this fixes OpenBSD it looks fine I think. But I wonder if we shouldn't just do this if we are on OpenBSD, changing the SOVERSION has been fraught with problems before since people have scripts that expect certain layouts. Without having more tests and more investigati

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1960 +/// "\#pragma managed" +/// "\#pragma managed(...)" I don't see the other comments in this file having `"\#` I think you can drop that. Also two `/` for the comments, not three. Reposit

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added a comment. It still looks odd to me, but since the rest of the file has comments like that I am fine with it. But I think we should figure out if they are like that because some tool is parsing them or if it's just legacy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

<    1   2