thieta added a comment. In D132486#3748546 <https://reviews.llvm.org/D132486#3748546>, @thakis wrote:
> Was this reviewed by anyone on the original change? As far as I can tell, > there was no agreement on the original change or here that reverting is the > way to go. Was this discussed elsewhere? > > (I don't have an opinion on which approach is better myself.) The bulk of the discussion was done in this thread: https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground-to-keep-it-behind-option/64410 I think the original revert in https://reviews.llvm.org/D129160 was probably a little hasty. But since this was raised pretty late in the 15.x release process this is the compromise that was the least bad IMHO. I had some offline discussions with Tom and Hans about it as well and the conclusion is that we should decide a proper way forward but the end of 15.x release window was the wrong place to have that discussion. I hope we can sort this out before 16 is branched and released. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132486/new/ https://reviews.llvm.org/D132486 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
