thieta requested changes to this revision.
thieta added a comment.
This revision now requires changes to proceed.
Thanks for fixing - but it's not completely accurate right now.
================
Comment at: clang/www/get_started.html:72
<li><tt>cd build</tt></li>
+ <li>This builds both LLVM and Clang for debug mode and takes a lot of time
and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a
release build.</li>
<li><tt>cmake -DLLVM_ENABLE_PROJECTS=clang -G "Unix Makefiles"
../llvm</tt></li>
----------------
This isn't correct - invoking cmake without a `CMAKE_BUILD_TYPE` argument will
just print an error. I would fix the command line below to include
`-DCMAKE_BUILD_TYPE=Release` and have a comment saying switch Release to Debug
if you need a debug build.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127496/new/
https://reviews.llvm.org/D127496
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
