[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

thopre added a comment. Hi George, This commit seems to be causing some testsuite regression on Armv8 (both Aarch64 and ARM) architectures: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450 http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5625 Best regards, T

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre added inline comments. Comment at: include/clang/Driver/Options.td:1634-1636 + HelpText<"Uses a stronger heuristic to apply stack protectors to functions " + "that include arrays of any size (and any type), " + "as well as any calls to alloca or the ta

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre added inline comments. Comment at: include/clang/Driver/Options.td:1636 def fstack_protector_all : Flag<["-"], "fstack-protector-all">, Group, HelpText<"Force the usage of stack protectors for all functions">; def fstack_protector_strong : Flag<["-"], "fstack-protecto

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thopre added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:95 + +static size_t argPrefixesSize(size_t len) { + if (len == 1) Any reason why not take a StringRef of the option to compute the prefix of? That would put the .size() gymnastic in one

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. That's much better thank you. I like the stream shift operator overload, nice touch. LGTM but give it a day for other to give feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/ https://reviews.llvm.org/D55428 ___ cfe-commits mailing list cfe-

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + From what I understood of

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + miyuki wrote: > thopre wr

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added a comment. FWIW LGTM. https://reviews.llvm.org/D45965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. As I said, LGTM. Please wait a few days (say next Monday) in case anyone else has any objection. https://reviews.llvm.org/D45965 ___ cfe-commits

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

thopre added a comment. That was a speedy patch! I can confirm that my non reduced testcase (git diff -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b ^ 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b

[PATCH] D81422: Change filecheck default to dump input on failure

thopre accepted this revision. thopre added a comment. In D81422#2080758 , @probinson wrote: > I don't remember the exact reasoning but I believe it had something to do > with bot logs? @jdenny or @thopre might remember. I guess -dump-input just follow

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

thopre created this revision. thopre added reviewers: zixuw, arphaman, ributzka, steven_wu, dexonsmith. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. thopre requested review of this revision. Clang tests Driver/apple-arm64-arch.c and Driver/darwin-warning-opt

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc863cd858f: [clang, test, Darwin] Fix tests expecting Darwin target (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85367/new/ https:/

[PATCH] D79276: [FileCheck] Support comment directives

thopre added inline comments. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + How about characters that cannot be part of an identifier? E.g. would "@COM:" be interpreted as a comment? Should w

[PATCH] D79276: [FileCheck] Support comment directives

thopre accepted this revision. thopre added a comment. LGTM. Sorry for the late review. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + jdenny wrote: > jdenny wrote: > > thopre wrote: > > > Ho

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre created this revision. thopre added reviewers: sconstab, craig.topper, andrew.w.kaylor, zbrid, chandlerc. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

thopre updated this revision to Diff 430029. thopre marked an inline comment as done. thopre added a comment. Be more conservative in what we reject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https://reviews.llvm.org/D125084 Files:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c failure (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125084/new/ https:/

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426196 , @thopre wrote: > In D92409#2426188 , @rsmith wrote: > >> Let's just disable this broken GCC warning. IIRC, the corresponding clang >> warning covers the actual bugs cause

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450690 , @rsmith wrote: > In D92409#2450550 , @thopre wrote: > >> In D92409#2426196 , @thopre wrote: >> >>> Is there a way to disable it fr

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre created this revision. thopre added reviewers: zbrid, chandlerc, EricWF. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix use of undefined variable in CHECK-NOT directive in clang test CodeGen/attr-speculative-load-hardenin

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

thopre created this revision. thopre added reviewers: rsmith, rnk, BillyONeal, spatel. thopre requested review of this revision. Herald added a project: clang. Commit 9e52c43090f8cd980167bbd2719878ae36bcf6b5 removed the directive defining LINE_1600 but left a string substitution to that variable i

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG150fe05db441: [Test] Fix undef var in catch-undef-behavior.c (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

thopre created this revision. thopre added reviewers: jdenny, aaron.ballman, hfinkel, llvm-commits. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. The deserialize() method would trigger the following warning on GCC <7: warning: d

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre created this revision. thopre added reviewers: ABataev, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. GCC's -Wcomment warning is emit

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't mind

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426188 , @rsmith wrote: > Let's just disable this broken GCC warning. IIRC, the corresponding clang > warning covers the actual bugs caused by line continuation in comments, and > doesn't warn if the next line begins wi

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG507bbc45bba9: [AST][NFC] Silence GCC warning about broken strict aliasing rules (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92384/new

[PATCH] D94396: Fix macos target assumption in test

thopre added reviewers: hans, jyknight, steven_wu. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/ https://reviews.llvm.org/D94396 ___ cfe-commits mailing list cfe-

[PATCH] D94396: Fix macos target assumption in test

This revision was automatically updated to reflect the committed changes. Closed by commit rG305ac81e1d4b: Fix macos target assumption in test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/ https://reviews.llvm.org/D9

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre created this revision. thopre added reviewers: efriedma, kpn, mibintc, sepavloff, rjmccall. Herald added subscribers: dexonsmith, pengfei. thopre requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. __builtin_isnan currently generat

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V = EmitScalarExp

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2995 +Builder.getDefaultConstrainedExcept() == fp::ebIgnore || +!Ty->isIEEE()) { + V = Builder.CreateFCmpUNO(V, V, "cmp"); I'm

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321107. thopre marked 2 inline comments as done. thopre added a comment. - Fix order of sub operands in comments and use fully parenthesized expression - Explain how LShr is equivalent to < 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321554. thopre added a comment. Add AArch64 testcase and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/Cod

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre added inline comments. Comment at: clang/test/CodeGen/aarch64-strictfp-builtins.c:1 +// RUN: %clang_cc1 %s -emit-llvm -ffp-exception-behavior=maytrap -fexperimental-strict-floating-point -o - -triple arm64-none-linux-gnu | FileCheck %s + AArch64 is not S

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00a62547da7e: Stop traping on sNaN in __builtin_isnan (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG005fc11ebdd6: [PGO] Change ThinLTO test for targets with loop unrolling disabled (authored by Sherwin da Cruz <59867245+sherwin...@users.noreply.github.com>, committed by thopre). Repository: rG LLVM G

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre created this revision. thopre added reviewers: gregmiller, tejohnson, davide, danielcdh. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Re-add -fexperimental-new-pass-manager to Clang::CodeG

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added a comment. In D109234#3004253 , @gregmiller wrote: > Hello, > We are maintaining a downstream version of the monorepo based on the LLVM > main branch. We have not transitioned to the new PM yet. In a recent attempt > to merge the latest u

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre updated this revision to Diff 373214. thopre added a comment. Remove old PM tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109956/new/ https://reviews.llvm.org/D109956 Files: clang/test/CodeGen/pgo-sample-thinlto-summary.c Index: c

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a7a28075b7f: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2567145 , @jonpa wrote: > In D96568#2559476 , @thopre wrote: > >> In D96568#2559475 , @uweigand wrote: >> >>> In D96568#2559336

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it tak

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre created this revision. thopre added reviewers: kpn, efriedma, mibintc, sepavloff, rjmccall. Herald added a subscriber: pengfei. thopre requested review of this revision. Herald added a project: clang. __builtin_isinf currently generates a floating-point compare operation which triggers a tr

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. I think we should also add tests for half Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 325718. thopre added a comment. - Add half testcase - Fixup existing testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added inline comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT: [[IFLOA

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

thopre added a comment. +1 for this change but being a downstream target only I prefer to let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 __

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it tak

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre created this revision. thopre added reviewers: kstoimenov, vitalybuka. Herald added subscribers: pengfei, krytarowski. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicitely set x86_64-linux-gnu as a target for asan-use-c

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre created this revision. thopre added reviewers: xur, tejohnson, lebedev.ri. Herald added subscribers: ormris, pengfei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test CodeGen/thinlto-

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

thopre updated this revision to Diff 365425. thopre added a comment. Use x86_64-linux-gnu as triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/ https://reviews.llvm.org/D107667 Files: clang/test/CodeGen/thinlto-clang-diagnostic-ha

[PATCH] D107633: Set supported target for asan-use-callbacks test

thopre updated this revision to Diff 365465. thopre added a comment. Remove REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 Files: clang/test/CodeGen/asan-use-callbacks.cpp Index: clang/test/

[PATCH] D107633: Set supported target for asan-use-callbacks test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1397e19129ef: Set supported target for asan-use-callbacks test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e11ccad837c: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86 (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. LGTM (besides comment fix) but I'm not too familiar with the vector side of things Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6967 + // NaN has all exp bits set and a non zero significand. Therefore: + // isnan(V) == ((exp mask - (ab

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added reviewers: rsmith, rnk, kristof.beyls. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. Ping? Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21 + // NOFP16-NEXT: [[IHALF:%.*]] = load i16, i16* [[LDADDR]], align 2 + // NOFP16-NEXT: [[CONV:%.*]] = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]]) + // NOFP16-NEXT: [[IFL

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6eb56aa0ea: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre created this revision. thopre added reviewers: mibintc, kpn, efriedma, sepavloff, rjmccall, jonpa. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9 Files:

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; jonpa wrote: > What are these variants all about...? > They were introduced in https://r

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; uweigand wrote: > thopre wrote: > > jonpa wrote: > > > What are these variants all about.

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

thopre updated this revision to Diff 328130. thopre added a comment. Adapt to revert of __builtin_isinf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 Files: clang/test/CodeGen/strictfp_builtins.c Inde

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bfe6605ab7: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328170. thopre added a comment. Fix isfinite logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/stri

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre updated this revision to Diff 328171. thopre added a comment. Add isfinite testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.org/D97125 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

thopre added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; thopre wrote: > uweigand wrote: > > thopre wrote: > > > jonpa wrote: > > > > What are the

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre requested review of this revision. thopre added a comment. Requesting review since the logic has changed. This time I've also tested isfinite against glibc's result. All looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ h

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. In D97125#2603832 , @thopre wrote: > Requesting review since the logic has changed. This time I've also tested > isfinite against glibc's result. All looks good. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was automatically updated to reflect the committed changes. Closed by commit rGf60b35340fd7: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.or

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

thopre created this revision. thopre added reviewers: yln, rsmith. Herald added a project: All. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137484 Files: clang/t

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a86a23c10d: [Test] Fix driverkit-path.c with lib64 dir (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llv

[PATCH] D138274: Add version to all LLVM cmake package

thopre created this revision. thopre added reviewers: smeenai, arsenm, stella.stamenova, stellaraccident, Ericson2314, pmccormick, beanz. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp

[PATCH] D138274: Add version to all LLVM cmake package

thopre added a comment. In D138274#3938218 , @arsenm wrote: > I thought we had this already. The amount of boiler plate required repeated > in each component is depressing, but I wouldn't be surprised if it's really > needed I could configure the LLVMV

[PATCH] D138274: Add version to all LLVM cmake package

This revision was automatically updated to reflect the committed changes. Closed by commit rGad485b71b511: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org

[PATCH] D138274: Add version to all LLVM cmake package

thopre reopened this revision. thopre added inline comments. This revision is now accepted and ready to land. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM @LLVM_VERS

[PATCH] D138274: Add version to all LLVM cmake package

thopre updated this revision to Diff 477916. thopre added a comment. Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138274 Files: clang

[PATCH] D138274: Add version to all LLVM cmake package

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa2d3d9943: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155 ___ cfe-commits m

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

This revision was automatically updated to reflect the committed changes. Closed by commit rGb81cc6032902: [clang][NFC] Make various uses of Regex const (authored by thopre). Changed prior to commit: https://reviews.llvm.org/D68155?vs=26&id=230079#toc Repository: rG LLVM Github Monorepo

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

thopre added a comment. My sincere apologies, I forgot to change the author in the commit. I don't often commit on behalf of others so didn't think enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155

[PATCH] D70748: [clang test] Do not assume default target

thopre created this revision. thopre added a reviewer: thegameg. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang test Driver/darwin-opt-record.c assumes the default target is x86_64 by its uses of the -arch x86_64 and -arch x86_64h and thus fail on systems where it is

[PATCH] D70748: [clang test] Do not assume default target

thopre closed this revision. thopre added a comment. Committed as 717140a0dcc651ca2fec23248d1675fb2d388b9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70748/new/ https://revie

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre updated this revision to Diff 233712. thopre added a comment. Herald added subscribers: Sanitizers, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, delcypher, niosHD, sabu

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd0bb8dba2a: [lit] Remove lit's REQUIRES-ANY directive (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre added a subscriber: nemanjai. thopre added a comment. Herald added a subscriber: wuzish. In D71408#1787959 , @jdenny wrote: > This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` > needs to be updated for the removed tests. Th

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } I'm getting #0 for both functio

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } jdoerfert wrote: > thopre wrote

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2426b1fa66f9: [Test] Fix undef var in attr-speculative-load-hardening.c (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre created this revision. thopre added reviewers: andwar, david-arm, sdesmalen, SjoerdMeijer, kmclaughlin. Herald added a subscriber: tschuett. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test acle_sve_ld1.sh is missing

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre added a comment. In D98852#2634189 , @sdesmalen wrote: > LGTM, thanks for fixing! > > I'm curious, how did you find this case? :) The issue was caught by a patch of mine to FileCheck: https://reviews.llvm.org/D98691 Repository: rG LLVM Github

  1   2   >