thopre accepted this revision. thopre added a comment. In D81422#2080758 <https://reviews.llvm.org/D81422#2080758>, @probinson wrote:
> I don't remember the exact reasoning but I believe it had something to do > with bot logs? @jdenny or @thopre might remember. I guess -dump-input just followed the existing default behavior when -dump-input-on-failure was introduced. There was several mentions of whether to make it the default when that was introduced [1][2] and my understanding was the worry was on whether it would make some FileCheck test fail. I think with FileCheckOpt this is no longer a concern. I would have personally benefited from having this the default so I support this change. [1] https://reviews.llvm.org/D49328?id=155527#inline-433596 [2] https://reviews.llvm.org/D49328#1170186 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llvm.org/D81422 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
