thopre reopened this revision.
thopre added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/cmake/modules/ClangConfig.cmake.in:6
+set(LLVM_VERSION
${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH})
+find_package(LLVM @LLVM_VERSION@ EXACT REQUIRED CONFIG
HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@")
----------------
mceier wrote:
> I think instead of `@LLVM_VERSION@` it should be `${LLVM_VERSION}` since
> `@LLVM_VERSION@` can be something like `16.0.0gitfce7a7aa` when
> LLVM_VERSION_SUFFIX is set and that value is incorrect according to cmake
> find_package:
>
> > find_package called with invalid argument "16.0.0gitfce7a7aa"
>
> This error message is produced by cmake when configuring standalone build of
> lldb:
>
> > CMake Error at /usr/lib/llvm/16/lib64/cmake/clang/ClangConfig.cmake:10
> > (find_package):
> > find_package called with invalid argument "16.0.0gitfce7a7aa"
> > Call Stack (most recent call first):
> > cmake/modules/LLDBStandalone.cmake:10 (find_package)
> > CMakeLists.txt:30 (include)
>
>
>
Doh, yeah it was meant to use the variable above. I used PACKAGE_VERSION
initially which is why I had those @@. Weird that it worked on my test despite
using a git build. I've reverted and will upload a new version here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138274/new/
https://reviews.llvm.org/D138274
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
