r333148 - [Sema][ObjC] Do not DiagnoseUseOfDecl in LookupMemberExpr

Author: steven_wu Date: Wed May 23 18:01:43 2018 New Revision: 333148 URL: http://llvm.org/viewvc/llvm-project?rev=333148&view=rev Log: [Sema][ObjC] Do not DiagnoseUseOfDecl in LookupMemberExpr Summary: Remove the call to DiagnoseUseOfDecl in LookupMemberExpr because: 1. LookupMemberExpr eagerly

r321909 - Preserve unknown STDC pragma through preprocessor

Author: steven_wu Date: Fri Jan 5 14:45:03 2018 New Revision: 321909 URL: http://llvm.org/viewvc/llvm-project?rev=321909&view=rev Log: Preserve unknown STDC pragma through preprocessor Summary: #pragma STDC FP_CONTRACT handler is only registered in parser so we should keep the unknown STDC pragm

r335366 - Add const qualifier on FieldChainInfoComparator::operator()

Author: steven_wu Date: Fri Jun 22 09:51:17 2018 New Revision: 335366 URL: http://llvm.org/viewvc/llvm-project?rev=335366&view=rev Log: Add const qualifier on FieldChainInfoComparator::operator() libcxx has user defined warning to check for non const call operator. Silence the warning by adding t

r350970 - [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

Author: steven_wu Date: Fri Jan 11 13:16:04 2019 New Revision: 350970 URL: http://llvm.org/viewvc/llvm-project?rev=350970&view=rev Log: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO Summary: After r327851, Driver::GetTemporaryPath will create the file rather than just creat

r352537 - Fix the tests from r350970

Author: steven_wu Date: Tue Jan 29 12:13:02 2019 New Revision: 352537 URL: http://llvm.org/viewvc/llvm-project?rev=352537&view=rev Log: Fix the tests from r350970 Relax the tests from r350970 to allow non-standard path for ld. Modified: cfe/trunk/test/Driver/darwin-ld-lto.c Modified: cfe/tr

Re: r350970 - [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

r352537 should fix it. Steven > On Jan 29, 2019, at 11:36 AM, Matt Arsenault wrote: > > > >> On Jan 11, 2019, at 4:16 PM, Steven Wu via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> Author: steven_wu >> Date: Fri Jan 11

Re: r328173 - Improve -Winfinite-recursion

Hi Robert I ping'ed this commit on Phabricator with an example of false positive introduced by this patch. Can you take a look? Thanks Steven > On Mar 21, 2018, at 8:16 PM, Robert Widmann via cfe-commits > wrote: > > Author: codafi > Date: Wed Mar 21 20:16:23 2018 > New Revision: 328173 >

Re: r304661 - CodeGen: fix section names for different file formats

Hi Saleem I just realize there can be an issue with this commit. This breaks the bitcode compatibility when LTO linking bitcode file produced by llvm-5.0 vs the older versions. Because the objc related module flag has the behavior Module::Error, simple whitespace changes will cause libLTO to er

r348943 - [Driver] Add support for -fembed-bitcode for assembly file

Author: steven_wu Date: Wed Dec 12 09:30:16 2018 New Revision: 348943 URL: http://llvm.org/viewvc/llvm-project?rev=348943&view=rev Log: [Driver] Add support for -fembed-bitcode for assembly file Summary: Handle -fembed-bitcode for assembly inputs. When the input file is assembly, write a marker a

r330166 - [Availability] Improve availability to consider functions run at load time

Author: steven_wu Date: Mon Apr 16 16:34:18 2018 New Revision: 330166 URL: http://llvm.org/viewvc/llvm-project?rev=330166&view=rev Log: [Availability] Improve availability to consider functions run at load time Summary: There are some functions/methods that run when the application launches or th

r330338 - [CXX] Templates specialization visibility can be wrong

Author: steven_wu Date: Thu Apr 19 08:46:43 2018 New Revision: 330338 URL: http://llvm.org/viewvc/llvm-project?rev=330338&view=rev Log: [CXX] Templates specialization visibility can be wrong Summary: Under some conditions, LinkageComputer can get the visibility for ClassTemplateSpecializationDecl

r336168 - [Driver][Darwin] Use Host Triple to infer target os version

Author: steven_wu Date: Mon Jul 2 21:15:49 2018 New Revision: 336168 URL: http://llvm.org/viewvc/llvm-project?rev=336168&view=rev Log: [Driver][Darwin] Use Host Triple to infer target os version Summary: When clang required to infer target os version from --target option and the os version is no

r375027 - Fix darwin-ld-lto test for some speical path

Author: steven_wu Date: Wed Oct 16 11:12:41 2019 New Revision: 375027 URL: http://llvm.org/viewvc/llvm-project?rev=375027&view=rev Log: Fix darwin-ld-lto test for some speical path Fix the test by not assuming the prefix path of the temp directory can be matched by a regex. rdar://problem/562591

[clang] 2b42080 - [clang] Teach -fembed-bitcode option not to embed W_value Group

Author: Steven Wu Date: 2020-07-14T14:40:43-07:00 New Revision: 2b42080b51c9a0c5ed733b30da165774dcd0d595 URL: https://github.com/llvm/llvm-project/commit/2b42080b51c9a0c5ed733b30da165774dcd0d595 DIFF: https://github.com/llvm/llvm-project/commit/2b42080b51c9a0c5ed733b30da165774dcd0d595.diff LOG

[libunwind] 4cd0937 - [libunwind] Remove compatibility support for macOS 10.6

Author: Steven Wu Date: 2020-08-17T14:09:03-07:00 New Revision: 4cd09374cdb163573007ccb402f5ba8970eb6134 URL: https://github.com/llvm/llvm-project/commit/4cd09374cdb163573007ccb402f5ba8970eb6134 DIFF: https://github.com/llvm/llvm-project/commit/4cd09374cdb163573007ccb402f5ba8970eb6134.diff LOG

[clang] 493766e - Frontend: Respect -working-directory when checking if output files can be written

Author: Steven Wu Date: 2022-09-09T08:57:12-07:00 New Revision: 493766e068474a80a790ac41c667061229d2262d URL: https://github.com/llvm/llvm-project/commit/493766e068474a80a790ac41c667061229d2262d DIFF: https://github.com/llvm/llvm-project/commit/493766e068474a80a790ac41c667061229d2262d.diff LOG

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/74782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

https://github.com/cachemeifyoucan approved this pull request. LGTM with small comments. https://github.com/llvm/llvm-project/pull/74782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a driv

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a driv

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a driv

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/cachemeifyoucan created https://github.com/llvm/llvm-project/pull/72572 Fix decl-params-determinisim test after 48be81e1 packed some information in the clang module. The test is to make sure the decls are appearing in a strict ordering and it relies on check the correct fiel

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/cachemeifyoucan updated https://github.com/llvm/llvm-project/pull/72572 >From 89938936f2e021360e3889548608e76022c3d73b Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Thu, 16 Nov 2023 13:21:27 -0800 Subject: [PATCH 1/2] [ClangModule] Fix decl-params-determinisim test after se

[clang] [ClangModule] Fix decl-params-determinisim test after serialization change (PR #72572)

https://github.com/cachemeifyoucan closed https://github.com/llvm/llvm-project/pull/72572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

https://github.com/cachemeifyoucan approved this pull request. https://github.com/llvm/llvm-project/pull/74782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d072826 - [Darwin toolchain] Tune the logic for finding arclite.

Author: Steven Wu Date: 2022-07-20T16:45:52-07:00 New Revision: d0728260577d66b4b4d922adf0a40de86f09ccf5 URL: https://github.com/llvm/llvm-project/commit/d0728260577d66b4b4d922adf0a40de86f09ccf5 DIFF: https://github.com/llvm/llvm-project/commit/d0728260577d66b4b4d922adf0a40de86f09ccf5.diff LOG

[clang] [clang][Darwin] Handle reexported library arguments in driver (PR #86980)

https://github.com/cachemeifyoucan approved this pull request. https://github.com/llvm/llvm-project/pull/86980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9cd6fbe - Fix module build after TargetParser

Author: Steven Wu Date: 2022-12-20T10:31:19-08:00 New Revision: 9cd6fbee7ed881f8e80b735e95567040e56f189e URL: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e DIFF: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e.diff LOG

[clang] 516e301 - [NFC][Profile] Access profile through VirtualFileSystem

Author: Steven Wu Date: 2023-02-01T09:25:02-08:00 New Revision: 516e301752560311d2cd8c2b549493eb0f98d01b URL: https://github.com/llvm/llvm-project/commit/516e301752560311d2cd8c2b549493eb0f98d01b DIFF: https://github.com/llvm/llvm-project/commit/516e301752560311d2cd8c2b549493eb0f98d01b.diff LOG

[clang] 5cff68f - [Module] Respect `-fno-pch-timestamps` when building modules

Author: Steven Wu Date: 2023-02-01T10:34:35-08:00 New Revision: 5cff68fca0bc21ccad20cc7c8fb9845e32b4c925 URL: https://github.com/llvm/llvm-project/commit/5cff68fca0bc21ccad20cc7c8fb9845e32b4c925 DIFF: https://github.com/llvm/llvm-project/commit/5cff68fca0bc21ccad20cc7c8fb9845e32b4c925.diff LOG

[clang] 0480748 - [DeclContext] Sort the Decls before adding into DeclContext

Author: Steven Wu Date: 2023-02-02T15:16:20-08:00 New Revision: 0480748ea6728392886931b8470969ae17aaa91f URL: https://github.com/llvm/llvm-project/commit/0480748ea6728392886931b8470969ae17aaa91f DIFF: https://github.com/llvm/llvm-project/commit/0480748ea6728392886931b8470969ae17aaa91f.diff LOG

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

https://github.com/cachemeifyoucan commented: I haven't read the PR in details but one thing we found difficult to do is how to write a test for daemon spawning logic, because if anything went wrong, you left an unbounded daemon process on CI node. The strategy in this PR (try to kill it after

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

@@ -0,0 +1,302 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

cachemeifyoucan wrote: > Implementing a timeout as part of this patch as a safety measure seems worth > while too but I'm not sure I understand your final solution. You all spawned > a clang job that had to communicate with the daemon to make sure one did not > exist? It is something like thi

[clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] 4098e13 - Revert "[clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body"

Author: Steven Wu Date: 2023-07-28T11:39:46-07:00 New Revision: 4098e13a71464cc4747528edd8a41e5a4eaa1b23 URL: https://github.com/llvm/llvm-project/commit/4098e13a71464cc4747528edd8a41e5a4eaa1b23 DIFF: https://github.com/llvm/llvm-project/commit/4098e13a71464cc4747528edd8a41e5a4eaa1b23.diff LOG

[clang] 42c9354 - Revert "Reland "[LoongArch] Support -march=native and -mtune=""

Author: Steven Wu Date: 2023-07-31T16:57:06-07:00 New Revision: 42c9354a928d4d9459504527085fccc91b46aed3 URL: https://github.com/llvm/llvm-project/commit/42c9354a928d4d9459504527085fccc91b46aed3 DIFF: https://github.com/llvm/llvm-project/commit/42c9354a928d4d9459504527085fccc91b46aed3.diff LOG

[libunwind] 9366397 - [libunwind] Fix evaluating DWARF operation DW_OP_pick

Author: Steven Wu Date: 2019-12-18T12:22:21-08:00 New Revision: 9366397f057d18401e680b2cb28a0ee17c59d4a6 URL: https://github.com/llvm/llvm-project/commit/9366397f057d18401e680b2cb28a0ee17c59d4a6 DIFF: https://github.com/llvm/llvm-project/commit/9366397f057d18401e680b2cb28a0ee17c59d4a6.diff LOG

r317860 - [Driver] Make clang/cc conforms to UNIX standard

Author: steven_wu Date: Thu Nov 9 17:32:47 2017 New Revision: 317860 URL: http://llvm.org/viewvc/llvm-project?rev=317860&view=rev Log: [Driver] Make clang/cc conforms to UNIX standard Summary: This is basically reverting r261774 with a tweak for clang-cl. UNIX standard states: When c99 encounter

Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

Hi Eric Looks like the issue is fixed in r295794? Now green dragon is failing due to XPASS. http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3018/testReport/ Can we remove that XFAILs in these two files? std/strings/basic_string/string_cons.implicit_deduction_guides.pass.cpp std

Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

Hi Eric This has been failing for one week on green dragon. I think all the bots running sanitizer should pick up the clang with the fix already if they are building from trunk. Should I try remove the XFAIL? Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu wrote: > > Hi Eric > > Looks like

[libcxx] r296385 - Remove XFAIL in implicit_deduction_guides tests

Author: steven_wu Date: Mon Feb 27 15:10:41 2017 New Revision: 296385 URL: http://llvm.org/viewvc/llvm-project?rev=296385&view=rev Log: Remove XFAIL in implicit_deduction_guides tests The clang assertion causing these tests failing with sanitizer is fixed in r295794. All the bots running libcxx t

Re: [libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

For those watch the bots, Eric upgrade the bots with the new compiler and I remove the XFAIL in r296385. Thanks Steven > On Feb 23, 2017, at 11:48 AM, Steven Wu via cfe-commits > wrote: > > Hi Eric > > Looks like the issue is fixed in r295794? Now green dragon is faili

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

steven_wu created this revision. steven_wu added a reviewer: mehdi_amini. steven_wu added a subscriber: cfe-commits. -fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly passed when using LTO. LTO is a special case of -fembed-bitcode which it doesn't require embed the bitcode in

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

steven_wu added inline comments. Comment at: lib/Driver/Tools.cpp:8326 - if (C.getDriver().embedBitcodeEnabled() || - C.getDriver().embedBitcodeMarkerOnly()) { -// Check if the toolchain supports bitcode build flow. mehdi_amini wrote: > Why aren't these

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

steven_wu updated this revision to Diff 78111. steven_wu added a comment. Rename the functions to clarify the intention. embedBitcodeEnabled means if any flag in -fembed-bitcode family is used so the corresponding linker flag should be inferred. embedBitcodeInObject means if the bitcode should be

r287084 - [Driver] Infer the correct option to ld64 for -fembed-bitcode

Author: steven_wu Date: Wed Nov 16 00:06:44 2016 New Revision: 287084 URL: http://llvm.org/viewvc/llvm-project?rev=287084&view=rev Log: [Driver] Infer the correct option to ld64 for -fembed-bitcode Summary: -fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly passed when using L

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rL287084: [Driver] Infer the correct option to ld64 for -fembed-bitcode (authored by steven_wu). Changed prior to commit: https://reviews.llvm.org/D26690?vs=78111&id=78140#toc Repository: rL LLVM http

Re: Embedded Bitcode in Object Files

> >> On Mon, Feb 29, 2016 at 2:08 PM, Steven Wu via cfe-commits >> wrote: >> Ping. I don't know who is the best review for the patches. Thanks for Rafael >> looking at the LLVM change. Richard, do you have any opinions on the clang >> changes? >>

Re: r261774 - Bail on compilation as soon as a job fails.

Hi Nico Now that r262420 is landed. Is there any plan to move CUDA to the new approach so we can fix the UNIX conformance test? Thanks Steven > On Apr 22, 2017, at 8:08 PM, Nico Weber via cfe-commits > wrote: > > On Sat, Apr 22, 2017 at 8:40 PM, Duncan P. N. Exon Smith via cfe-commits > ma

Re: r261774 - Bail on compilation as soon as a job fails.

The other option is to make this behavior configurable so that clang on UNIX behaves differently than clang-cl or CUDA. I am not sure what problem CUDA is hitting. Is there a test case for that? Steven > On May 15, 2017, at 12:42 PM, Nico Weber wrote: > > r262420 landed in a way adapted to Ju

Re: r261774 - Bail on compilation as soon as a job fails.

> On May 15, 2017, at 3:03 PM, Nico Weber wrote: > > test/Driver/cl-pch-errorhandling.cpp tests the clang-cl pch bits. I don't think reverting r261774 will break any cl-pch tests (didn't try windows). That is why I wondering if there is any test case for CUDA so I don't break them when fixing

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

CreateElementBitcast doesn’t seem to do what the name suggested. If you give it VTy, it doesn’t grab the element type to generate bitcast. Is this by-design? If so, I need to do this: PtrOp0 = Builder.CreateElementBitCast(PtrOp0, VTy->getElementType()); Steven >> On Sep 8, 2015, at 5:14 PM, St

r247117 - Fix vld1_lane intrinsic generation

Author: steven_wu Date: Tue Sep 8 20:37:18 2015 New Revision: 247117 URL: http://llvm.org/viewvc/llvm-project?rev=247117&view=rev Log: Fix vld1_lane intrinsic generation Fix a bug introduced in r246985 which causes assertion when generating vld1_lane. Modified: cfe/trunk/lib/CodeGen/CGBuilt

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

Thanks. Committed in r247117. Steven > On Sep 8, 2015, at 6:32 PM, John McCall wrote: > >> On Sep 8, 2015, at 6:19 PM, Steven Wu wrote: >> CreateElementBitcast doesn’t seem to do what the name suggested. If you give >> it VTy, it doesn’t grab the element type to generate bitcast. Is this >>

r246282 - Revert r246214 and r246213

Author: steven_wu Date: Fri Aug 28 02:14:10 2015 New Revision: 246282 URL: http://llvm.org/viewvc/llvm-project?rev=246282&view=rev Log: Revert r246214 and r246213 These two commits causes llvm LTO bootstrap to hang in ScalarEvolution. Removed: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp

Re: r246214 - Assume loads fix #2

I am pretty sure this commit and r246213 causes llvm LTO bootstrap to hang in ScalarEvolution. Doesn’t look like a bug introduced in the commit but definitely triggered something bad. I reverted both commit in r246282. You should able to reproduce the hang by building llvm-cov using LTO. Let me

Re: r246830 - Fix a potential APInt memory leak when using __attribute__((flag_enum)), and

In case you didn’t get an email from the failure because it was overshadowed by the previous error. This commit seems to break the green dragon bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12990/testReport/junit/Clang/Sema/attr_flag_enum_c/

Re: r246830 - Fix a potential APInt memory leak when using __attribute__((flag_enum)), and

> OK, should be fixed in r246836. > > On Thu, Sep 3, 2015 at 7:50 PM, Richard Smith <mailto:rich...@metafoo.co.uk>> wrote: > On Thu, Sep 3, 2015 at 6:21 PM, Steven Wu via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > In case you didn’t get an email from

Re: r246830 - Fix a potential APInt memory leak when using __attribute__((flag_enum)), and

Looks fixed. Thank a lot for investigating! > On Sep 3, 2015, at 9:21 PM, Steven Wu via cfe-commits > wrote: > > Sorry I just get back to my computer. I will watch the bots going. I will try > investigating if it is still failing. > As far as I know, there is no special

[PATCH] D12644: Using -isysroot on Apple platform

steven_wu created this revision. steven_wu added a reviewer: EricWF. steven_wu added a subscriber: cfe-commits. --sysroot might cause inconsistency between the header gets used and the library gets linked on Apple platform. Use -isysroot instead. http://reviews.llvm.org/D12644 Files: CMakeList

Re: [PATCH] D12644: Using -isysroot on Apple platform

steven_wu updated this revision to Diff 34073. steven_wu added a comment. Sorry, made a typo on the previous patch. A little background information. When the greendragon jenkins make an system upgrade in the future, it will need this flag as well to build and test libcxx through cmake/ninja. ht

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

steven_wu added a subscriber: steven_wu. steven_wu added a comment. This commit seems to cause miscompile in LNT testsuite with -O0 and -O3 http://lab.llvm.org:8080/green/job/perf_o0g_run/7070/warnings2Result/new/ http://lab.llvm.org:8080/green/job/perf_o3lto_run/15591/warnings2Result/new/ Looks

Re: [PATCH] D12644: Using -isysroot on Apple platform

steven_wu added a comment. That works as well. I am not sure if there is any specific reason for using "--sysroot" so I proposed a safer fix. http://reviews.llvm.org/D12644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [libcxx] r249798 - Split out of .

Hi Richard Your splitting seems causing problem when using extern "C". Here is a test case: $ cat test.cpp #ifdef __cplusplus extern "C" { #endif #include #ifdef __cplusplus } #endif Error: clang -fsyntax-only test.cpp In file included from test.cpp:4: In file included from /usr/bin/../includ

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

> On Jul 25, 2016, at 3:24 AM, Jonas Devlieghere wrote: > > Hi, > > I hope I'm not breaking any mailing list etiquette by replying to this > mail, but if I am then please accept my apologies. > > On Fri, Jun 3, 2016 at 8:36 PM, Steven Wu via llvm-dev > wrote: >> Hi everyone >> >> I am still

[PATCH] D17389: Embed bitcode in object file (clang cc1 part)

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1 commandline into the bitcode in special sections

[PATCH] D17390: Introduce -fembed-bitcode driver option

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. This is the clang driver part of the change to embedded bitcode. This includes: 1. -fembed-bitcode option which breaks down the compilation into two stages. The first stage emits optimized bitcode and the second stage comp

Re: [PATCH] D17389: Embed bitcode in object file (clang cc1 part)

steven_wu abandoned this revision. steven_wu added a comment. I accidentally send this patch with everything in it. I will send out patch in small chunks instead. http://reviews.llvm.org/D17389 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. steven_wu added a dependency: D17390: Introduce -fembed-bitcode driver option. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1 commandli

Embedded Bitcode in Object Files

Hi all I put up some patches for embedding bitcode inside the object file (-fembed-bitcode) option. As I described in the dev list before, the new option can create normal object file with bitcode embedded in a special section. You can easily recreate the same object file with the embedded bitc

[PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu created this revision. steven_wu added reviewers: rtrieu, thakis. steven_wu added a subscriber: cfe-commits. -Wfor-loop-analysis was incorrectly warning about certain cases because the DeclMatcher is not looking pass OpaqueValueExpr. http://reviews.llvm.org/D17627 Files: lib/Sema/Sem

Re: r261767 - Add whole-program vtable optimization feature to Clang.

Hi Peter I notice after this commit, I can no longer use cmake option -DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link the clang driver. When using -DCLANG_TOOL_DRIVER_BUILD=OFF, clang target will not exist so cmake will error on the line: > +add_dependencies(clang vtables_blacklis

Re: r261767 - Add whole-program vtable optimization feature to Clang.

Thanks a lot! Steven > On Feb 25, 2016, at 7:12 PM, Peter Collingbourne wrote: > > (I don't understand why this flag needs to exist, but) I've implemented a > fix in r261960. > > Peter > > On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote: >> Hi Peter >> >> I notice after this comm

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu added subscribers: doug.gregor, rjmccall. steven_wu added reviewers: rjmccall, doug.gregor. steven_wu added a comment. Looking through the subscript sounds fine but I would like to know if this is indeed the only case that is being ignored because of OpaqueValueExpr and if everything i

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. Ping. http://reviews.llvm.org/D17392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:769-770 @@ +768,4 @@ +void clang::EmbedBitcode(llvm::Module *M, const CodeGenOptions &CGOpts, + llvm::MemoryBufferRef Buf) +{ + if (CGOpts.getEmbedBitcode() == CodeGenOptions::Embed_O

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 56367. steven_wu added a comment. Format update according to review. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def include/clang/Frontend/CodeGen

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 56371. steven_wu marked 2 inline comments as done. steven_wu added a comment. Add comments to address the feedback fromt the review. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/cl

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. Attach a new patch with the comments Comment at: lib/CodeGen/BackendUtil.cpp:799-831 @@ +798,35 @@ + // Embed the bitcode for the llvm module. + std::string Data; + ArrayRef ModuleData; + Triple T(M->getTargetTriple()); + if (CGOpts.getEmbedBitcod

r269202 - Embed bitcode in object file (clang cc1 part)

Author: steven_wu Date: Wed May 11 11:26:03 2016 New Revision: 269202 URL: http://llvm.org/viewvc/llvm-project?rev=269202&view=rev Log: Embed bitcode in object file (clang cc1 part) Summary: Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed bot

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269202: Embed bitcode in object file (clang cc1 part) (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D17392?vs=56371&id=56930#toc Repository: rL LLVM http://reviews.llvm.o

Re: [patch] Don't use appending linkage for embeded bitcode

Hi Rafael Thanks for notice this! That would definitely cause duplicated symbol error and I should definitely change that. Here is some background: ld64 in Xcode 7+ knows how to handle the embedded bitcode correctly but not the ones in earlier Xcode. The old ld64 will simply concatenate the bit

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/ Here is a patch to fix them: diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp inde

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

It is part of -Wall group and it should be on by default when you building clang. That warning is added into clang some time in 2014. Make sure you are not using a compiler that is too old. Steven > On May 13, 2016, at 10:58 AM, Liu, Yaxun (Sam) wrote: > > BTW is there a way to turn on this w

Re: [patch] Don't use appending linkage for embeded bitcode

Attach a patch using private linkage type and adding to llvm.used. I have to recreate llvm.used when embedding bitcode. I don't really like it but I don't have better solutions. Few other options: 1. Not allowing re-embedded bitcode will simplify the code a bit but not a lot. 2. Create a new "llv

Re: [patch] Don't use appending linkage for embeded bitcode

> On May 13, 2016, at 3:56 PM, Duncan P. N. Exon Smith > wrote: > > Is this something that you need the linker to treat as "used", or just > something you don't want the compiler to drop? If the latter, > @llvm.compiler.used seems more appropriate. Bitcode is actually not really used by the

Re: [patch] Don't use appending linkage for embeded bitcode

> On May 16, 2016, at 6:52 AM, Rafael Espíndola > wrote: > > + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); > > Please use an explicit type instead of auto. Sure. > > You deleted the assert Are you referring to the assertion that llvm.embedded.module has no uses. I adde

r269679 - Change embed-bitcode linkage type

Author: steven_wu Date: Mon May 16 13:54:58 2016 New Revision: 269679 URL: http://llvm.org/viewvc/llvm-project?rev=269679&view=rev Log: Change embed-bitcode linkage type Embedded bitcode should have private linkage instead of appending or external. Otherwise, it will cause link failure due to dup

Re: [patch] Don't use appending linkage for embeded bitcode

Thanks! Committed in r269679 Steven > On May 16, 2016, at 11:54 AM, Rafael Espíndola > wrote: > > LGTM > > On 16 May 2016 at 14:03, Steven Wu wrote: >> >>> On May 16, 2016, at 6:52 AM, Rafael Espíndola >>> wrote: >>> >>> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true); >

[PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

steven_wu created this revision. steven_wu added a reviewer: joker.eph. steven_wu added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. -fembed-bitcode was only checking for old style LTO flag (-flto) but not considering the new -flto= style option. That makes clang output bitcode

r269961 - [Driver] Fix the case when use -fembed-bitcode and -flto= together

Author: steven_wu Date: Wed May 18 12:04:52 2016 New Revision: 269961 URL: http://llvm.org/viewvc/llvm-project?rev=269961&view=rev Log: [Driver] Fix the case when use -fembed-bitcode and -flto= together Summary: -fembed-bitcode was only checking for old style LTO flag (-flto) but not considering

Re: [PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

This revision was automatically updated to reflect the committed changes. Closed by commit rL269961: [Driver] Fix the case when use -fembed-bitcode and -flto= together (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D20374?vs=57645&id=57646#toc Repository: rL LLVM

Re: r270047 - [Clang][AVX512][intrinsics] continue completing missing set intrinsics

Hi Michael This commit seems break darwin LTO bootstrap bot. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/7916/ Also breaks the Asan Ubsan bot: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1742/ Can you talk a look? I don't why the failure doesn't sho

Re: r265038 - Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.

The original handler is not there to workaround a crash. It is to avoid generate a crash report (report_fatal_error) when the input bitcode contains invalid assembly. It is an oversight to exit(0) even when it failed. Can you make the diagnostic handler fatal for Errors kinds instead of removin

Re: r265038 - Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.

> On Apr 1, 2016, at 12:04 PM, Tim Northover wrote: > > >> On 31 Mar 2016, at 16:51, Steven Wu wrote: >> >> The original handler is not there to workaround a crash. It is to avoid >> generate a crash report (report_fatal_error) when the input bitcode contains >> invalid assembly. > > Ah,

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 52435. steven_wu added a comment. Address the feedback from Richard: Break -fembed-bitcode option into multiple -fembed-bitcode= options. -fembed-bitcode=all will embed both bitcode and commandline and -fembed-bitcode=bitcode will embed only the bitcode in

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. ping. The currently -fembed-bitcode option is only half working. I don't want to leave it like that too long. http://reviews.llvm.org/D17392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 54559. steven_wu added a comment. Ping. Rebase the patch over trunk and tweak the testcase. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def includ

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 54597. steven_wu added a comment. Thanks Vedant! Address all of your review in this update. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def includ

  1   2   3   >