[PATCH] D55490: Add dumpMethodDeclOverrides to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55490 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Split the output streaming from the traversal to other AST nodes. Repository: rC Clang https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h incl

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D55492 Files: include/clang/AST/AttrVisitor.h include/clang/AST/CMakeLists.txt include/clang/AST/TextNodeDumper.h lib/A

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177419. steveire added a comment. Use std::string Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

steveire updated this revision to Diff 177420. steveire added a comment. Use child node labels Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55395/new/ https://reviews.llvm.org/D55395 Files: lib/AST/ASTDumper.cpp test/AST/dump.cpp Index: test/AST/dump.cpp

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 177421. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h l

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

steveire added a comment. In D55395#1324699 , @aaron.ballman wrote: > This is a novel approach that's not used anywhere else in the AST dumper Actually it's used by the InitListExpr dump. See https://reviews.llvm.org/D55488 Repository: rC Clang CHA

[PATCH] D55495: Change InitListExpr dump to label and pointer

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Don't add a child just for the label. Repository: rC Clang https://reviews.llvm.org/D55495 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-stmt.cpp Index: test/AST/ast-dump-

[PATCH] D55495: Change InitListExpr dump to label and pointer

steveire added a comment. My real preference is just to remove the `array filler` child node entirely and not add a pointer here. However, I'm just looking for something that has a chance of passing review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55495/new

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

steveire added a comment. I would prefer *not* to do what is in this patch. I'm just trying to find a way forward. I like the approach of using the existing precedent of printing the pointers as a compromise between removing such labels entirely and not having things like that at all. I did tha

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

steveire updated this revision to Diff 177428. steveire added a comment. Use pointer approach Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55395/new/ https://reviews.llvm.org/D55395 Files: lib/AST/ASTDumper.cpp test/AST/dump.cpp Index: test/AST/dump.cpp =

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire marked 3 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/AttrVisitor.h:21 + +namespace attrvisitor { + aaron.ballman wrote: > I don't think the namespace adds value. I think the point is to separate the implementati

[PATCH] D55495: Change InitListExpr dump to label and pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL348794: Change InitListExpr dump to label and pointer (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55495?vs=177426&i

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348795: Re-order content in OMPDeclareReductionDecl dump (authored by steveire, committed by ). Herald added a subscriber:

[PATCH] D55393: Re-order content of template parameter dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL348797: Re-order content of template parameter dumps (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55393?vs=177412&id

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177594. steveire marked an inline comment as done. steveire added a comment. Update with new approach Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDu

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177595. steveire added a comment. Clean up API a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp test/AST/a

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:89 void dumpDecl(const Decl *D); -void dumpStmt(const Stmt *S); +void dumpStmt(const Stmt *S, const std::string &label = {}); aaron.ballman wrote: > Label > > Rather than using `{}`

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire updated this revision to Diff 177670. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55337/new/ https://reviews.llvm.org/D55337 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D60910: [WIP] Dumping the AST to JSON

steveire added a comment. Thanks for doing this! I'm glad you were able to do it without needing to change the traverser class. That's a good indicator. I think it would be great if there were somewhere to document the non-stability of the format and content here. Comment at

[PATCH] D52334: Build clang-tidy even without static analyzer

steveire created this revision. steveire added reviewers: JonasToth, george.karpenkov, shuaiwang, aaron.ballman. Herald added subscribers: cfe-commits, Szelethus, a.sidorin, mgorny. Conditionally compile the parts of clang-tidy which depend on the static analyzer. Repository: rCTE Clang Tools

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. @JonasToth Sorry, I don't know what's unclear. I'm so surprised by your question that I think maybe I'm missing something. I thought the commit message and the patch itself are clear. Am I missing something? Currently you can only build clang-tidy if you build the stat

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. > But that clang-tidy is deactivated totally makes that impossible :) Yes. That should be clear by reading the patch. > Some of the clang-tidy stuff relies on Analysis/* from clang as well, e.g. > the CFG class. Is this still included in builds with CSA off? The `Anal

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. Thanks, that at least makes it more obvious where you are getting confused. See `tools/clang/lib/CMakeLists.txt`. It contains: add_subdirectory(Analysis) ... === if(CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(StaticAnalyzer) endif() 1. That is: Analysis and St

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. Actually, I had not run the tests. Thanks for the reminder there. I extended the patch to enable the tests even if CSA is not available. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 166644. steveire marked 2 inline comments as done. steveire added a comment. Handle tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plug

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 166825. steveire added a comment. Enable tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/Clang

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/CMakeLists.txt:69 -clang-tidy -) -endif() + clang-tidy + ) alexfh wrote: > There are some clang-tidy tests for the static analyzer integration (at least > tes

[PATCH] D52264: Deduplicate replacements from diagnostics.

steveire added a comment. Was this motivated by https://bugs.llvm.org/show_bug.cgi?id=38910 ? Repository: rL LLVM https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. Can I go ahead and merge this now? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. @JonasToth Once again - `clangStaticAnalyzerCheckers` is not `clangAnalysis`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Yes, `add_llvm_executable` uses `target_link_libraries` with `PRIVATE` for `LLVM_PTHREAD_LIB`. It is designed so that if you use the `PUBLIC|PRIVATE|INTERFACE` keyword with a target once,

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167584. steveire added a comment. Whitespace etc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/Cla

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked 2 inline comments as done. steveire added a comment. @aaron.ballman Happy to add a note to the docs, but your request leaves me wondering where? AFAIK, the fact that `clang-tidy` wasn't built at all when using `CLANG_ENABLE_STATIC_ANALYZER` is not documented, so I can't just upd

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167615. steveire added a comment. Herald added a subscriber: arphaman. Docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked 2 inline comments as done. steveire added a comment. > I think a reasonable place would be docs/clang-tidy/index.rst in the "Getting > Involved" area. That's at least actionable, but not very specific. I've added docs now. If they don't say what you want them to say, then please

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167618. steveire added a comment. Format docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangT

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167619. steveire added a comment. Doc fix Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyP

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked an inline comment as done. steveire added a comment. > Once I'm happy, I will accept it. If @alexfh has further comments, then they > can be addressed at that time (pre or post commit). That's very reasonable, thanks. Repository: rCTE Clang Tools Extra https://reviews.llvm.o

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. I'll take care of it in a few days and commit it myself. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D52713: Move llvm util dependencies from clang-tools-extra to add_lit_target.

steveire added a comment. inlining this into three `add_dependencies` calls would remove the `if (TARGET)` conditions. Are those dependencies conditionally built? Repository: rL LLVM https://reviews.llvm.org/D52713 ___ cfe-commits mailing list c

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL343528: [clang-tidy] Build it even without static analyzer (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52334?vs=167

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

This revision was automatically updated to reflect the committed changes. Closed by commit rC343530: Update CMakeLists.txt snippet so that example compiles (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D52664?vs=167521&id=167816#toc Repository: rC C

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

steveire added a comment. Done! Thanks for the contribution! Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire created this revision. steveire added reviewers: alexfh, aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire updated this revision to Diff 167825. steveire added a comment. Add test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryParserTest.cpp ===

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This is necessary for clang-query to be able to handle comments. Repository: rC Clang https://reviews.llvm.org/D52751 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTM

[PATCH] D52752: [clang-query] Add comment token handling

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. It is possible to pass a file of commands to clang-query using the command line option -f or --preload. Make it possible to write comments in such files. Repository: rCTE C

[PATCH] D52752: [clang-query] Add comment token handling

steveire updated this revision to Diff 167848. steveire added a comment. Remove garbage Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52752 Files: clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryParserTest.cpp =

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; I'll have to keep a p

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; hans wrote: > zturner

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire added a comment. @Szelethus You can approve it and then you will get the feature :). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire updated this revision to Diff 167984. steveire added a comment. Add docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/Query.cpp clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryPa

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

steveire added a comment. In https://reviews.llvm.org/D52746#1252455, @aaron.ballman wrote: > Please update `HelpQuery::run()` to print out the new mnemonic (it's the > *only* form of public documentation we have for clang-query currently). Good point, thanks! Repository: rCTE Clang Tools

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

steveire updated this revision to Diff 167987. steveire added a comment. use cxx_range_for Repository: rC Clang https://reviews.llvm.org/D52751 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp ===

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

steveire marked an inline comment as done. steveire added inline comments. Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190 + for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) { +EXPECT_EQ("", Sema.Errors[i]); + } aaron.ballman wrote:

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

steveire added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:792 Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name); + if (Args.hasArg(OPT_echo_main_file_name)) +llvm::outs() << Opts.MainFileName << "\n"; zturner wrote: > ztur

[PATCH] D52819: Support checking out cte to 'extra' only as backward compatibility

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. This requirement to check it out in a directory called 'extra' was never documented for git users, so git users doing the obvious thing (just clone, don't specify a name) will s

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343664: [clang-query] Add single-letter 'q' alias for 'quit' (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D52746?vs=167984&id=168077#toc Repository: rCTE

[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rL343665: Allow comments with '#' in dynamic AST Matchers (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52751?vs=167987

[PATCH] D52752: [clang-query] Add comment token handling

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343666: [clang-query] Add comment token handling (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D52752?vs=167848&id=168080#toc Repository: rCTE Clang Tools

[PATCH] D52752: [clang-query] Add comment token handling

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:42 +End = Begin; +return StringRef(Begin, 0); + } aaron.ballman wrote: > This is just returning an empty `StringRef`, isn't it? Might as we

[PATCH] D52819: Support checking out cte to 'extra' only as backward compatibility

steveire added a comment. Will do! Repository: rC Clang https://reviews.llvm.org/D52819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52840: Include Python binding tests in CMake rules

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. I didn't run it, but CMake-wise this looks fine. (I trust you did) I notice some tests use from tests.cindex.util import foo while others use from .util import foo You might want to

[PATCH] D52843: Update Clang Windows getting started docs

steveire added inline comments. Comment at: clang/www/get_started.html:197 +If you are using Visual Studio 2017: + cmake -G "Visual Studio 15 2017 Win64" ..\llvm +This will generate x64 binaries by default, which should perform better. smeenai wrote

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Replace it with granular options. This makes it possible to - Have both diag and dump active at once - Extend the output with other queryable content in the future. Repository: r

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire updated this revision to Diff 168217. steveire added a comment. Format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52857 Files: clang-query/Query.cpp clang-query/Query.h clang-query/QueryParser.cpp clang-query/QuerySession.h unittests/clang-query/QueryEngi

[PATCH] D52859: [clang-query] Add option to print matcher expression

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This is useful if using clang-query -f with a file containing multiple matchers. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52859 Files: clang-query/Query.cpp

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire updated this revision to Diff 168218. steveire added a comment. Commit message Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52857 Files: clang-query/Query.cpp clang-query/Query.h clang-query/QueryParser.cpp clang-query/QuerySession.h unittests/clang-query/Q

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire added inline comments. Comment at: clang-query/Query.cpp:48 +"Set whether to dump binding ASTs.\n" +" set print-output (true|false) " +"Set whether to print matched text.\n" Is the 'print' output useful at all? I'm thinking

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D52870 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp Index: lib/AST/NestedNameSpecifier.cpp ===

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

steveire updated this revision to Diff 168338. steveire added a comment. Format Repository: rC Clang https://reviews.llvm.org/D52870 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp Index: lib/AST/NestedNameSpecifier.cpp ===

[PATCH] D52870: [NestedNameSpecifier] Add missing stream-specific dump methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL343807: [NestedNameSpecifier] Add missing stream-specific dump methods (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5287

[PATCH] D52857: Deprecate 'set output foo' API of clang-query

steveire added a comment. Can I convince someone to be interested enough in this to approve it? I have a talk coming up and I'd like to be able to say that you don't have to switch between `dump` mode and `diag` mode all the time. I also want to enable other relevant outputting features in `cla

[PATCH] D57502: [ASTDump] Make template specialization tests more exact

This revision was automatically updated to reflect the committed changes. Closed by commit rL352804: [ASTDump] Make template specialization tests more exact (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:83 + + NodeVisitorType &getNodeVisitor() { return getDerived().doGetNodeVisitor(); } + Derived &getDerived() { return *static_cast(this); } --

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire updated this revision to Diff 184616. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDump

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// I think I'll rename this to `ASTNodeTraverser`. An

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL352989: [AST] Extract ASTNodeTraverser class from ASTDumper (authored by steveire, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

steveire added a comment. I have no objection to this, but I wonder whether all state accessible from all nodes should be part of the AST dump. Where do you think the line is? Is there anything else missing currently from other nodes? Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire accepted this revision. steveire added a comment. Sorry, this fell off my radar :). LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61834 Files: include/clang/AST/ASTNodeTraverser.h Index: include/clang/AST/ASTNodeTraverser.h

[PATCH] D61835: Extract ASTDumper to a header file

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This class has member APIs which are useful to clients. Make it possible to use those APIs without adding them to dump() member functions. Doing so doe

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

steveire created this revision. steveire added reviewers: klimek, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make it usable outside of ASTMatchFinder. This will make it possible to use this enum to control whether certain implicit nodes are skipped while

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

steveire added a comment. This is part of the work I demo'd at EuroLLVM for ignoring invisible AST nodes during AST Matching and dumping: http://ce.steveire.com/z/lHYwEH Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61836/new/ https://reviews.llvm.org/D61836

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire created this revision. steveire added reviewers: klimek, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This will eventually allow traversal of an AST while ignoring invisible AST nodes. Currently it depends on the available enum values for Traversa

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire added a comment. @klimek This includes a test for the memoization case you were interested in at EuroLLVM. In this iteration of the API, the traversal kind is changed by using a new `traverse` matcher, which gives the user control over whether invisible/implicit nodes are skipped or n

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 199181. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: include/clang/AST/ASTContext.h include/clang/AST/ASTNodeTraverser.h include/clan

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire updated this revision to Diff 199178. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 Files: include/clang/AST/ASTNodeTraverser.h Index: include/clang/AST/ASTNodeTraverser.h =

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

steveire updated this revision to Diff 199180. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61836/new/ https://reviews.llvm.org/D61836 Files: include/clang/AST/ASTTypeTraits.h include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D61835: Extract ASTDumper to a header file

steveire updated this revision to Diff 199179. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61835/new/ https://reviews.llvm.org/D61835 Files: include/clang/AST/ASTDumper.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D60910: [WIP] Dumping the AST to JSON

steveire added inline comments. Comment at: include/clang/AST/DeclBase.h:1139 + void dump(raw_ostream &Out, bool Deserialize = false, +ASTDumpOutputFormat OutputFormat = ADOF_Default) const; aaron.ballman wrote: > steveire wrote: > > I think we've

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 199185. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: include/clang/AST/ASTContext.h include/clang/AST/ASTNodeTraverser.h include/clan

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1504663 , @aaron.ballman wrote: > I'm not certain where you're planning to go with this change (or is this the > only change you're trying to make in this area?), so it's a bit hard to > evaluate this patch. Can you e

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire added a comment. In D61834#1504665 , @aaron.ballman wrote: > What will be making use of/testing this new functionality? Any code which has a `DynTypedNode` and wishes to traverse it. I envisage this as a more-flexible `DynTypedNode::dump` that

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

This revision was automatically updated to reflect the committed changes. Closed by commit rC360920: Move TraversalKind enum to ast_type_traits (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D61836?vs=199180&id=199856#toc Repository: rC Clang CHANGE

[PATCH] D61836: Move TraversalKind enum to ast_type_traits

steveire added a comment. Thanks, I made the comment changes in a separate commit because otherwise this would cease to be a refactoring commit. Commits get too noisy if their content is modified "mid-flight". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61836

[PATCH] D61835: Extract ASTDumper to a header file

steveire added a comment. In D61835#1505151 , @aaron.ballman wrote: > In D61835#1505048 , @steveire wrote: > > > The users of the follow-up patch > > https://reviews.llvm.org/D61837#change-x5mxz9Lpijjs need that

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 199875. steveire marked 10 inline comments as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: include/clang/AST/ASTContext.h include

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire added inline comments. Comment at: include/clang/AST/ASTContext.h:562-563 public: + ast_type_traits::TraversalKind GetTraversalKind() const { return Traversal; } + void SetTraversalKind(ast_type_traits::TraversalKind TK) { Traversal = TK; } + aaron.ba

<    1   2   3   4   5   6   7   8   9   10   >