steveire added a comment. In D61835#1505151 <https://reviews.llvm.org/D61835#1505151>, @aaron.ballman wrote:
> In D61835#1505048 <https://reviews.llvm.org/D61835#1505048>, @steveire wrote: > > > The users of the follow-up patch > > https://reviews.llvm.org/D61837#change-x5mxz9Lpijjs need that > > 'correctness', but also need the public API from `ASTNodeTraverser` on the > > instance. (That patch also extends the public API for users). > > > I don't see anything in the follow-up patch that actually uses the > `ASTDumper` class though, so I'm still a bit confused. Maybe my wording was confusing. I'll try again: 1. Anyone who wants traversal in the same way that dumping is done must use an instance of the `ASTDumper` class. Is that much clear? Does my previous response clarify why that is the case? 2. The follow-up patch https://reviews.llvm.org/D61837#change-x5mxz9Lpijjs adds API to ASTNodeTraverser. 3. Anyone who wants traversal in the same way that dumping is done and who needs to call API on the instance which is provided by ASTNodeTraverser (which ASTDumper inherits) needs to use ASTDumper. For example my UI. See my EuroLLVM talk for more: https://steveire.wordpress.com/2019/04/30/the-future-of-ast-matching-refactoring-tools-eurollvm-and-accu/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61835/new/ https://reviews.llvm.org/D61835 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
