[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Please can you extend the test coverage to cover more vector sizes and cpu target features, not just avx512, and also add x86_64-scei-ps4 triple tests. Maybe 32-bit tests as well? Comment at: clang/include/clang/Basic/LangOptions.h:143 +/// (SVN r

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Tests look great - please can you pre-commit them and update the patch to show the diff? Also, maybe call the test file x86-vec-i128.c and add a comment in the file describing PR42607? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. In D64672#1654983 , @craig.topper wrote: > In D64672#1654687 , @RKSimon wrote: > > > Tests look great - please can you pre-commit them and update the patch to > > show the diff? Also, mayb

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. MSVC builds are seeing template instantiation issues with this patch: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/27972/steps/build/lo

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits mailing list cf

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. @craig.topper Wasn't this committed at rL371169 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits mailing list cfe-commit

[PATCH] D60748: Fix i386 struct and union parameter alignment

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. In D60748#1524443 , @wxiao3 wrote: > Thanks for the information! > We have reverted the patch and will resubmit it when we have a complete

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. @nand The MSVC warnings are self explanatory - you've declared a number of methods (visitIndirectMember, emitConv and getPtrConstFn) but not provided definitions, as they're on template classes MSVC complains, a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1663867 , @nand wrote: > I am providing definitions in the C++ file - the problem is that they are not > available in the header before the extern declaration. The methods are > available at the site of the extern defin

[PATCH] D35996: [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

RKSimon created this revision. Clang specifies a max type alignment of 16 bytes on darwin targets (annoyingly in the driver not via cc1), meaning that the builtin nontemporal stores don't correctly align the loads/stores to 32 or 64 bytes when required, resulting in lowering to temporal unalign

[PATCH] D35996: [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309488: [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D35996?vs=108646&id=108788#toc Repository:

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

RKSimon added a comment. Codegen test case on no-sse2 target? https://reviews.llvm.org/D36362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. FMA4 tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

This revision was automatically updated to reflect the committed changes. Closed by commit rG48b510c4bc0f: [NFC] Fix compiler warnings due to integer comparison of different signedness (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon created this revision. RKSimon added a reviewer: craig.topper. Herald added a project: clang. RKSimon requested review of this revision. Placeholder patch for when the reduction intrinsics drop their experimental status, emitting the equivalent reduction intrinsic in IR instead of expandi

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

RKSimon added a comment. Would it be possible to add some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. In D87604#2272211 , @craig.topper wrote: > Longer term should we have a variadic version of this like > __builtin_shufflevector or __builtin_convertvector that can handle any > reduction? Yes, I was looking at what would be nec

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

RKSimon added a comment. @joerg Are you alright with this now? If so please can you accept it to unblock it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 ___

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. Do we have sufficient backend test coverage for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-co

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon planned changes to this revision. RKSimon added a comment. WIP until reductions are no longer experimental Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.llvm.org/D87604 ___

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

RKSimon added inline comments. Comment at: clang/test/CodeGen/bittest-intrin.c:50 // X64: call i8 asm sideeffect "lock btrq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{.*}}"(i64* %{{.*}}, i64 {{.*}}) // X64: call i8 asm sideeffect "lock btsq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{

[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

RKSimon accepted this revision. RKSimon added a comment. LGTM as well cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88121/new/ https://reviews.llvm.org/D88121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. LGTM @rnk ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon created this revision. RKSimon added reviewers: craig.topper, echristo, spatel, erichkeane, andreadb. Herald added a project: clang. RKSimon requested review of this revision. This is a RFC first step patch to enable constexpr support and testing to a large number of x86 intrinsics. All

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon added inline comments. Comment at: clang/lib/Headers/popcntintrin.h:16 +#ifdef __cplusplus +#define __DEFAULT_FN_ATTRS_CONSTEXPR __DEFAULT_FN_ATTRS constexpr craig.topper wrote: > Do we need to check for C++11? I don't actually know - its trivial to add

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286601. RKSimon added a comment. add c++11 limiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/lib/Headers/popcntintrin.h clang/test/CodeGen/popcnt

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + arsenm wrote: > Missing required register target? sure, oddly we d

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286605. RKSimon added a comment. Require x86-registered-target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/lib/Headers/popcntintrin.h clang/test/Co

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + craig.topper wrote: > RKSimon wrote: > > arsenm wrote: > > > Missi

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + arsenm wrote: > RKSimon wrote: > > craig.topper wrote: > > > RKSim

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286634. RKSimon edited the summary of this revision. RKSimon added a comment. Added -x c++ RUN lines to the existing popcnt-builtins.c file - thanks @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D862

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon added a comment. I think that's everything - I'd prefer to handle the registered target fixes in separate commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 __

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286835. RKSimon added a comment. Added release note entry - this will need to revised as we add more intrinsics, so is just an initial placeholder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ http

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286837. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/docs/ReleaseNotes.rst clang/lib/Headers/popcntintrin.h clang/test/CodeGen/popcnt-builtins.c I

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

RKSimon updated this revision to Diff 286861. RKSimon added a comment. Added constexpr tests - I went for the -ve array size approach as thats the approach in clang\test\Sema\constant-builtins-2.c etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcff0db08761f: [X86] Enable constexpr on POPCNT intrinsics (PR31446) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D8622

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, spatel. Herald added a project: clang. RKSimon requested review of this revision. This enables us to use the __builtin_bitreverse 8/16/32/64 intrinsics inside constexpr code. Repository: rG LLVM Github Monorepo htt

[PATCH] D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249)

RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, spatel. Herald added a project: clang. RKSimon requested review of this revision. This enables us to use the __builtin_rotateleft / __builtin_rotateright 8/16/32/64 intrinsics inside constexpr code. Repository: rG L

[PATCH] D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ceac91ec0fc: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D86342?vs=287006&id=287181#toc Repository:

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7d9182a666a: Enable constexpr on BITREVERSE builtin intrinsics (PR47249) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D86339?vs=286999&id=287182#toc Repository: rG LLVM G

[PATCH] D86398: [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446)

RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, erichkeane. Herald added a project: clang. RKSimon requested review of this revision. As suggested by @rsmith on PR47267, by replacing the __builtin_memcpy bitcast pattern with __builtin_bit_cast we can use _castf32_u32

[PATCH] D86398: [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8e0e5db4860: [X86] Enable constexpr on _cast fp<-> uint intrinsics (PR31446) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 ___

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, nikic, lebedev.ri. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. RKSimon requested review of this revision. We're now getting close to having the necessary analysis/combines etc. for the n

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

RKSimon added a comment. In D87101#2256557 , @spatel wrote: > I noticed one other LLVM codegen test that might want to be updated to use > the IR intrinsics to be more relevant -- > llvm-project/llvm/test/CodeGen/X86/combine-abs.ll. That can be done with

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2853ae3c1b81: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

RKSimon created this revision. RKSimon added reviewers: ABataev, doctorpangloss. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. RKSimon requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fixes issue noticed by sta

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

This revision was automatically updated to reflect the committed changes. Closed by commit rG58970eb7d1dd: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D872

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Couldn't we avoid a lot of this of this casting + template ugliness by just using the / INT_MAX / INT32_MAX defines? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://rev

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

RKSimon accepted this revision. RKSimon added a comment. LGTM - I'll try to commit this later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 ___ cfe-commit

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon added a comment. This patch doesn't look like it is taking into account the existing (albeit limited) support for znver3 - it looks like a very bad merge imo. It'd make much more sense to split this into several smaller incremental patches: 1 - cleanup any missing basic znver3 handling

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800 case Instruction::Invoke: - return getModRefInfo((const InvokeInst *)I, Loc, AAQIP); + return getModRefInfo((const CallBase *)I, Loc, AAQIP); case Instruction::CatchPad:

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/M68k.h:14 +#ifndef M680X0_H_LTNCIPAD +#define M680X0_H_LTNCIPAD + @myhsu This should probably be LLVM_CLANG_LIB_BASIC_TARGETS_M68K_H CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added a comment. This patch is very busy with 3 different aims - maybe split into 3 patches? The constifications, the include cleanup and the getModRefInfo tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a comment. Please can you pre-commit math-builtins-adjust.c with current IR checks and then rebase to show the diffs? Maybe rename it math-builtins-long.c as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://revi

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added inline comments. Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + This should probably be pulled out too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei. RKSimon requested review of this revision. Herald added a project: clang. Followup to D87604 , having confirmed on PR47506 that we can use the llvm codegen expansion for fadd/fmul as we

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9559 static __inline__ double __DEFAULT_FN_ATTRS512 _mm512_reduce_max_pd(__m512d __V) { _mm512_mask_reduce_operator(max_pd); pengfei wrote: > Better to change min and max as well. O

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4855a1004d4d: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction… (authored by RKSimon). Repository: rG LLVM Github Monorepo

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei, spatel. RKSimon requested review of this revision. Herald added a project: clang. As suggested by @pengfei on D92940 My concern with this is that by default llvm.vector.reduce.fmax/min

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + dfukalov wrote: > RKSimon wrote: > > This should probably be pulled out too > It uses `d

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. @BRevzin @nlopes This is causing MSVC build failure please can you take a look? E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): note: see declaration of 'std::reverse_iterator' E:\llvm\llvm-project\llvm\lib\DWARFLinker\DWARFLinker.cpp(383): no

[PATCH] D78938: Make LLVM build in C++20 mode

RKSimon added a comment. In D78938#2460360 , @nlopes wrote: > Just saw that you fixed it already. Thank you! 'Avoided' might be a better term than 'fixed' tbh - I didn't delve much into why it was breaking, or what effect it has on C++20 work. Reposit

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei, rsmith, erichkeane, spatel. RKSimon requested review of this revision. Herald added a project: clang. This is an initial exploratory patch towards making some (basic initialization and arithmetic) SSE/AVX intrinsics us

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon updated this revision to Diff 312979. RKSimon added a comment. missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93597/new/ https://reviews.llvm.org/D93597 Files: clang/lib/Headers/xmmintrin.h clang/test/CodeGen/X86/sse-bui

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added a comment. In D93597#2464870 , @tschuett wrote: > libcxx uses a function test and calls test() and static_assert(test()), see > below > https://github.com/llvm/llvm-project/blob/d86a00d8febd0138a21f92d1420c4b62d7acb0ca/libcxx/test/std/utilit

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon updated this revision to Diff 313038. RKSimon added a comment. I've added the static_assert constexpr methods - this requires C++14 so I've left the existing constexpr wrapper tests with C++11 coverage as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

RKSimon added a comment. I'm sorry I've only just started looking at this - are you saying that you want to handle all "insertelement undef" cases in one go and not just a series of patcches after this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added a comment. Some very minor nits - the 68060 omission is the biggest one (apple might not have used it but commodore did!) Comment at: clang/include/clang/Driver/Options.td:155 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocNa

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

RKSimon added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:78 Targets/Mips.cpp + Targets/M68k.cpp Targets/NVPTX.cpp (sorting) - move after Le64.cpp Comment at: clang/lib/CodeGen/TargetInfo.cpp:8087 + if (const FunctionDec

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

RKSimon added subscribers: stephenkelly, RKSimon. RKSimon added a comment. @stephenkelly This is breaking a large number of bots - please can you revert your patch series to get things green again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9098

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/M68k.cpp:51 +} +return CPUName.str(); + } Can't we just use StringSwitch here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

RKSimon added a comment. Herald added a subscriber: dang. @wxiao3 @LiuChen3 Are you still looking at this or should it be abandoned? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits mail

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

RKSimon added a comment. @lebedev.ri This is failing on the windows arm build bots - please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1482 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3285 Repository: rG LLVM Github Monorepo C

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon updated this revision to Diff 296930. RKSimon added a comment. Herald added a subscriber: pengfei. rebased now that the reduction intrinsics are no longer experiemental Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://review

[PATCH] D89102: [X86] Add HRESET instruction.

RKSimon added a comment. Please can you add a mention in the 12.0 release notes? Comment at: llvm/lib/Target/X86/X86InstrInfo.td:2920 + def HRESET : Ii8<0xF0, MRM_C0, (outs), (ins i32u8imm:$imm), "hreset\t$imm", []>, + Requires<[HasHRESET]>, TAXS; +

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. Please can you add an entry to the 12.00 release notes describing this? Maybe somewhere in the clang docs as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:191 -- Support for -march=sapphirerapids was added. +* Support for ``-march=sapphirerapids`` and ``-march=x86-64-v[234]`` has been added. Fix the bullet point: '-' Please can you extend

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.llvm.org/D87604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon added a comment. I'd prefer that our docs explicitly state what we've implemented instead of just referencing an external webpage. Please add the full explanation to UserManual.rst under the "CPU Architectures Features and Limitations" x86 section for long term reference - the release

[PATCH] D89197: [X86] Support -march=x86-64-v[234]

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 __

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c23cbc5603c: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics… (authored by RKSimon). Repository: rG LLVM Github M

[PATCH] D89405: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms intrinsics

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, rnk, thakis. Herald added a subscriber: pengfei. Herald added a project: clang. RKSimon requested review of this revision. Now that funnel shift handling is pretty good, we can use the intrinsics directly and avoid a lo

[PATCH] D89405: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fa9030d47f: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added subscribers: hvdijk, RKSimon. RKSimon added a reviewer: hvdijk. RKSimon added a comment. Adding @hvdijk as IIRC has been looking at gnux32 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D5205

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added a comment. Do we have any buildbot coverage for gnux32? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added a comment. In D52050#2369856 , @glaubitz wrote: > In D52050#2369838 , @dschuff wrote: > >> One other question then: do you know if Debian and/or Ubuntu still have the >> same support for running x32 p

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

RKSimon added a comment. @ashi1 This is causing build failures - please can you take a look ? http://lab.llvm.org:8011/#/builders/14/builds/2514 :17:66: note: possible intended match here "/b/1/clang-x86_64-debian-new-pass-manager-fast/llvm.obj/bin/llvm-ar" "rcsD" "a.out" "/tmp/a-88f827.o"

[PATCH] D89184: Support complex target features combinations

RKSimon added a comment. a few minor style comments that I noticed Comment at: clang/lib/CodeGen/CodeGenFunction.h:4705 +size_t SubexpressionStart = 0; +for (size_t i = 0; i < FeatureList.size(); ++i) { + char CurrentToken = FeatureList[i]; (style)

[PATCH] D39086: Performance tracing facility for clangd.

RKSimon added inline comments. Herald added subscribers: usaxena95, kadircet, arphaman, MaskRay. Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57 +} +std::string VS = V->getValue(Tmp).str(); +if (VS != I->second) { @sammccall PVS

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

RKSimon added a comment. @sammccall I've pushed rGc0053c62d9a0 to fix MSVC builds which were struggling to find a default constructor for ConstChildIterator http://lab.llvm.org:8011/#/builders/83 Repository: rG LLVM Gith

[PATCH] D102495: [clang][deps] Support inferred modules

RKSimon added inline comments. Comment at: clang/utils/module-deps-to-rsp.py:1 +#!/usr/bin/env python + @Bigcheese - https://lab.llvm.org/buildbot/#/builders/139/builds/4147 doesn't like this - should this be python3 ? Repository: rG LLVM Github Monorepo CH

[PATCH] D103491: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

RKSimon accepted this revision. RKSimon added a comment. Thanks for dealing with this @nikic For this refactor, keeping the implementation as close to the existing one makes more sense; also personally I'd prefer the missing include fixups to be committed first as NFCs but its up to you. Repo

[PATCH] D92270: [ConstantFold] Fold more operations to poison

RKSimon added a comment. https://bugs.llvm.org/show_bug.cgi?id=49005 seems to be due to this (either directly or it has unearthed an existing problem) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92270/new/ https://reviews.llvm.org/D92270 __

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. @pengfei I'm sorry I haven't gotten back to looking at this yet - it makes sense to create a patch to revert the fadd/fmul reduction changes for trunk/12.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https:/

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 ___ cfe-com

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:182 // CHECK-LABEL: test_mm256_castsi128_si256 - // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x i64> %{{.*}}, <2 x i64> %{{.*}}, <4 x i32

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

RKSimon created this revision. RKSimon added reviewers: ychen, rnk, MaskRay, zturner, chandlerc, lattner. Herald added subscribers: dexonsmith, hiraditya. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. https://commondatastorag

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rGe463b69736da: [Support] Change fatal_error_handler_t to take a const char* instead of std… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D111049?vs=376870&id=377135#toc Repos

<    1   2   3   4   5   6   7   >