[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The o

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 added a comment. In D124253#3467375 , @jhuber6 wrote: > Is this really the cause? `nvptx::assemble` should call `createOutputFile` > which makes a temp file to output to that is added to `TempFiles`. Hmm, that's interesting. After adding

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. The issue is in `clang/lib/Driver/ToolChains/Cuda.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253 ___

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 updated this revision to Diff 424589. tianshilei1992 added a comment. Herald added a subscriber: MaskRay. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253 Files: clang/lib/Driver/To

[PATCH] D124253: [Clang][OpenMP] Fix the issue that temp cubin files are not removed after compilation when using new OpenMP driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG20a9fb953e46: [Clang][OpenMP] Fix the issue that temp cubin files are not removed after… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Curre

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5936-5939 + CGF.Builder.CreateCast(X.getType()->hasSignedIntegerRepresentation() + ? llvm::Instruction::CastOps::SIToFP +

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 updated this revision to Diff 426532. tianshilei1992 added a comment. always use `UIToFP` because that is the only case that `UpdateVal` is a `ConstantInt`, where we created the constant integer for `++` or `--` operation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:217 void Visit(const OMPClause *C) { +if(OMPFailClause::classof(C)) { + Visit(static_cast(C)); clang-format plz. Comment at: clang/include/

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 updated this revision to Diff 426725. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124724/new/ https://reviews.llvm.org/D124724 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c1085c7e20b: [Clang][OpenMP] Add the support for floating-point variables for specific… (authored by tianshilei1992). Repository: rG LLVM Github

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added a comment. ping Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); tianshilei1992 wrote: > ABataev wrote: > > Why do we need to use `IgnoreImpCasts()` here and

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 427182. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6168 llvm::Value *EVal = CGF.EmitScalarExpr(E); + if (auto CI = dyn_cast(EVal)) +EVal = CGF.Builder.CreateIntCast( ABataev wrote: > 1. `auto *CI` > 2. What if this is not

[PATCH] D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125256/new/ https://reviews.llvm.org/D125256 _

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: mattd, gchakrabarti, asavonic, jholewinski. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added a comment. Feel free to add more reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125350/new/ https://reviews.llvm.org/D125350 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:311 +} +return false; + } `llvm_unreachable` might be more appropriate here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D125350: [RFC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added a comment. As for the test, here is a simple code snippet: #pragma omp begin declare target device_type(nohost) void foo() { double x, y; #pragma omp atomic update x += y; } #pragma omp end declare target `sm_35` doesn't support `FAdd` with `double` type, t

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

tianshilei1992 added a comment. Can we have test for right usage? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2496 +<< getOpenMPDirectiveName(DKind) << 0; +} +ConsumeToken(); clang-format plz, and remove the `{` and `}` as there is only one stat

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added a comment. In D123235#3513430 , @koops wrote: > I have tried on x64 RH and x64 SuSe. I could not reproduce the failures seen > on x64 debian. https://reviews.llvm.org/D118550 also has similar failures on > x64 debian. There is a co

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added a comment. LGTM, but please fix the build error first. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { koops wrote: > tianshilei1992 wrote: > > koops

[PATCH] D125350: [RFC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Do it in BE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125350/new/ https://reviews.llvm.org/D125350 ___ cfe-commits mailing lis

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParseOpenMP.cpp:3692-3694 + if (Kind == llvm::omp::Clause::OMPC_fail) { +Clause = ParseOpenMPFailClause(Clause); + } --

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 ___ cfe-commits mailing list

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. In D78075#2272398 , @ye-luo wrote: >> However, OpenMP task has a problem that it must be within >> to a parallel region; otherwise the task will be executed immediately. As a >> result, if we directly wrap to a regular task,

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292271. tianshilei1992 added a comment. Fixed `declare_mapper_codegen.cpp` with `CK0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. > If I remember correctly, you may yield the thread inside a target region > after enqueuing kernels and transfers. So even with 1 thread, there is chance > to run other tasks without finishing this target. Isn't that possible? I assume you were referring to `tas

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292280. tianshilei1992 added a comment. Fixed an issue that one wildcard is missing in the CHECK line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: cl

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292690. tianshilei1992 added a comment. Fixed the test case `target_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpe

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292696. tianshilei1992 added a comment. Fixed the test failure in OMP50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292835. tianshilei1992 added a comment. Fixed the test case `target_parallel_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/Code

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292979. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293195. tianshilei1992 added a comment. Continued to fix the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clan

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293253. tianshilei1992 added a comment. Fixed the case `target_parallel_for_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293254. tianshilei1992 added a comment. Fixed the test case `target_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293320. tianshilei1992 added a comment. Fixed the case `target_teams_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOp

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293323. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/C

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293466. tianshilei1992 added a comment. Fixed the case `target_teams_distribute_simd_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293505. tianshilei1992 added a comment. Fixed the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeG

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293537. tianshilei1992 added a comment. Refined the case `declare_mapper_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293577. tianshilei1992 added a comment. Rebased the source code and refined `declare_mapper_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files:

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. @jdoerfert Ready to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task

This revision was automatically updated to reflect the committed changes. Closed by commit rGebb1092a2875: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 289044. tianshilei1992 added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp Index:

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 290104. tianshilei1992 added a comment. Update one test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/te

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Is it because the triple is separated by `-`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93786/new/ https://reviews.llvm.org/

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tianshilei1992 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently, GCC toolchain can only be set via the option `--gcc-too

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. In D91107#2384191 , @tstellar wrote: > This code could be improved, but I don't think adding a specific environment > variable for this a good solution. You can use the existing > C

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2402886 , @jhuber6 wrote: > Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash > using this patch, I haven't encountered any errors on my machine. Could you > verify that this doesn't cau

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, grokos, ye-luo. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a subscriber: sstefan1. The implementation of targ

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added a comment. In D89844#2345337 , @ye-luo wrote: > Getting this even when compiling without offload. You can use the reproducer > from the original bug report. I noticed one issue and I'm working on it now. Repository: rG LLVM Githu

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 299803. tianshilei1992 added a comment. Fixed an issue that when there is mapper, the variable in the generated wrapped task still uses the one in the encountering function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 299814. tianshilei1992 added a comment. Tried to fix some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300371. tianshilei1992 added a comment. Removed useless code and fixed some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: clang/lib/CodeGen/CGSt

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300443. tianshilei1992 added a comment. Fixed the issue using a way that no need to change test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: cl

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300451. tianshilei1992 added a comment. Reverted changes for target data. It will be in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: c

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added a comment. I don't think the failed case has anything to do with this patch. It must be a random issue in the bolt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Previously we added support for target nowait, bu

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. In current implementation, if it requires an oute

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300509. tianshilei1992 added a comment. Fixed an issue that caused compiler crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOp

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300517. tianshilei1992 added a comment. Fixed some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cl

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300738. tianshilei1992 added a comment. Fixed two test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300754. tianshilei1992 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://revie

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe20d64c3d9d8: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait (authored by tianshilei1992). Repository: rG LLVM Github Mo

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 300859. tianshilei1992 added a comment. Fixed a major issue and one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMP

[PATCH] D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300869. tianshilei1992 added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/

[PATCH] D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd38788b357ad: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is… (authored by tianshilei1992). Repository: rG LLVM Git

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301150. tianshilei1992 added a comment. Rebased and fixed one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntim

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301151. tianshilei1992 added a comment. Fixed a rebase error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301164. tianshilei1992 added a comment. Fixed a rebase issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cla

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301325. tianshilei1992 added a comment. Rebased (again) to involve the reversion of another patch that can cause clang crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. This patch caused segment fault in D90099 where the map variable info pointer is `nullptr` but it is deferenced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://rev

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2359537 , @jhuber6 wrote: > In D89802#2359504 , @tianshilei1992 > wrote: > >> This patch caused segment fault in D90099 >> where the map

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301353. tianshilei1992 added a comment. Fixed all failed test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cp

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

tianshilei1992 added a comment. The two failed test cases should have nothing to do with this patch. Will merge this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 _

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0661328d7efb: [Clang][OpenMP] Added the support for target data nowait (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 updated this revision to Diff 345917. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Generally LGTM. Some nits. Comment at: clang/include/clang/Driver/Options.td:2331 PosFlag, NegFlag, BothFlags<[NoArgumentUnused, HelpHidden]>>; -def fopenmp_cuda_parallel_target_regions : Flag<["-"], "fopenmp-cuda-parallel-target-regions">,

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102940/new/ https://reviews.llvm.org/D102940 ___

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 _

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev. Herald added subscribers: dang, guansong, yaxunl. Herald added a reviewer: jansvoboda11. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Hera

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318377. tianshilei1992 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added changes in the driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https:/

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318398. tianshilei1992 added a comment. Droped the forward declaration and rewrote CUDA intrinsics with LLVM instrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:24 + return() +endif() + JonChesterfield wrote: > jdoerfert wrote: > > we need the 32 bit versions as well, I guess? > We could limit to 64 and see if a feature

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318717. tianshilei1992 added a comment. Fixed the test issue caused by wrong path seperator on Windows and Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318719. tianshilei1992 added a comment. Made test more robust Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318772. tianshilei1992 added a comment. Fixed test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161 Files: clang/docs/ClangCommandLineReference.rst clang

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad038aafa3a: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 added a comment. In D95161#2517662 , @JonChesterfield wrote: > Still LGTM. A little surprised these are being run on windows, but good to be > robust. It's driver test which only invokes `-###`. ;-) No actual execution. Repository: rG

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318788. tianshilei1992 added a comment. Code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolChains/Cuda.cpp openmp/libom

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

tianshilei1992 added a comment. In general we're moving to the direction that target specific implementation will be compiled along with user code, which is fantastic. In this way, we only need to provide one bitcode library for one target. The change in FE lacks of some efficiency. If user cod

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318879. tianshilei1992 added a comment. rebase and prep for a new patch for CUDA instrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/D

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319096. tianshilei1992 added a comment. rebased and dropped cuda header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolChains/Cuda

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/src/libcall.cu:319 -EXTERN int omp_is_initial_device(void) { - PRINT0(LD_IO, "call omp_is_initial_device() returns 0\n"); - return 0; // 0 by def on device -} +// EXTERN int omp_is_initial

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319109. tianshilei1992 added a comment. Added the missing critical option `-fopenmp-cuda-mode` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:785 + std::string LibOmpTargetName = "libomptarget-nvptx-cuda_" + + CudaVersionStr + "-" + GpuArch.str() + + ".bc";

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319132. tianshilei1992 added a comment. Fixed failed driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:16 +# TODO: This part can also be removed if we can change the clang driver to make +# it support device only compilation. +if(CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "x86_64") -

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:25 +#define NOINLINE __attribute__((noinline)) +#define ALIGN(N) __attribute__((aligned(N))) JonChesterfield wrote: > Suggest we drop the DEVICE annotation

<    1   2   3   4   5   6   >