tianshilei1992 added inline comments.

================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:25
+#define NOINLINE __attribute__((noinline))
+#define ALIGN(N) __attribute__((aligned(N)))
 
----------------
JonChesterfield wrote:
> Suggest we drop the DEVICE annotation and change ALIGN to alignas() or 
> similar, but in a later patch. This one is already quite noisy.
yes, just maintain minimal changes in the code for this patch. We can optimize 
everything afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94745/new/

https://reviews.llvm.org/D94745

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to