tianshilei1992 added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5936-5939 + CGF.Builder.CreateCast(X.getType()->hasSignedIntegerRepresentation() + ? llvm::Instruction::CastOps::SIToFP + : llvm::Instruction::CastOps::UIToFP, + IC, X.getAddress(CGF).getElementType()); ---------------- ABataev wrote: > Do we have a test for this? If `X` is not integer, I rather doubt that > hasSignedIntegerRepresentation is meaningful here I think you're right. How can we check if `Update` is signed or not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124724/new/ https://reviews.llvm.org/D124724 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
