[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. In D149193#4316293 , @dblaikie wrote: > I guess my main question is: What's the motivation for implementing this? Do > you have a need/use for this? (it doesn't seem to be motivated by GCC > compatibility - as discussed, lo

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added a comment. Does GCC have the same `-ftime-trace=` option? It seems like it doesn't, as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92396 is still open? If so, I am happy with unifying more of the dump/aux handling, and I imagine when/if GCC adds the option it will behave sim

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:517-529 + bool tryForceStoreSC0SC1(const SIMemOpInfo &MOI, + MachineBasicBlock::iterator &MI) const override { +if (ST.hasForceStoreSC0SC1() && +(MO

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:279 + void addTimeTraceFile(const char *Name, const JobAction *JA) { +TimeTraceFiles[JA] = Name; + } MaskRay wrote: > scott.linder wrote: > > If this is overriding prev

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

scott.linder added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:209 - std::map DebugPrefixMap; + llvm::SmallVector, 0> DebugPrefixMap; std::map CoveragePrefixMap; What benefit does forcing allocation have? Why not use the default

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

scott.linder added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:209 - std::map DebugPrefixMap; + llvm::SmallVector, 0> DebugPrefixMap; std::map CoveragePrefixMap; MaskRay wrote: > scott.linder wrote: > > What benefit does forcing

[PATCH] D148975: -fdebug-prefix-map=: make the last win when multiple prefixes match

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thank you! Does this warrant a release note, as it is changing the behavior in a backwards-incompatible manner? I do think changing to match GCC is worthwhile, even if it me

[PATCH] D149193: [Driver] -gsplit-dwarf: derive .dwo names from -o for link actions

scott.linder added a comment. I'm a bit confused after trying to work out the rules for the GCC version of `-dumpdir` over at https://gcc.gnu.org/onlinedocs/gcc/Overall-Options.html#index-dumpdir but it at least seems like our version is a subset of theirs. Do we support any of the other `-dum

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3884 + nullptr, getOpts().getOption(options::OPT_dumpdir), + Args.MakeArgString(Args.getLastArgValue(options::OPT_o, "a") + "-")); + Arg->claim(); MaskRay wrote: >

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. In D149193#4300885 , @MaskRay wrote: > I think the patch as-is implements all the useful parts of GCC's complex > rules and in the absence of `-dumpbase` (we deliberately don't implement), > the rule almost exactly matches

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. I am OK to give LGTM, assuming the other reviewers don't still have reservations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193 ___

[PATCH] D146023: [AMDGPU] Remove Code Object V2

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520 - assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL || - Func.getCallingConv() == CallingConv::SPIR_KERNEL); + if (Func.getCallingConv() != CallingConv::A

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder abandoned this revision. scott.linder added a comment. I'll open a new review as part of upstreaming all of the debug info work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https://reviews.llvm.org/D88978 _

[PATCH] D42766: [DebugInfo] Support DWARFv5 source code embedding extension

scott.linder created this revision. scott.linder added reviewers: echristo, arsenm, aprantl. Herald added subscribers: cfe-commits, JDevlieghere, nhaehnle, wdng. In DWARFv5 the Line Number Program Header is extensible, allowing values with new content types. In this extension source is embedded di

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

scott.linder created this revision. scott.linder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce an extra scope (another static function) to replace calls to `unique_ptr::reset` with implicit destructors via RAII. Repository:

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

scott.linder added reviewers: MaskRay, dineshkb-amd, aykevl. scott.linder added a comment. I'm not sure who else to add, please feel free to update the reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https://reviews.llvm.org/D10

[PATCH] D101542: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab19d84ce85: [NFC] Refactor ExecuteAssembler in cc1as_main.cpp (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101542/new/ https:

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. In D88978#2660274 , @arsenm wrote: > Is this still needed? Yes, I just got a little bogged down in the OMP code and haven't gotten back to it to finish it up. I anticipate needing to do this to soon, though. Repository:

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder created this revision. Herald added a subscriber: dexonsmith. scott.linder requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100671 Files: clan

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder added a comment. In D100671#2695923 , @dblaikie wrote: > This usage doesn't seem to quite match the standard - which provides an > existing instance of in_place_t for callers to use: > > std::optional o4(std::in_place, {'a', 'b', 'c'}); >

[PATCH] D94338: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

scott.linder created this revision. scott.linder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94338 Files: clang/docs/ClangOffloadBundler.rst Index: clang/docs/ClangOf

[PATCH] D94338: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc15b0e2229ea: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94338/new/

<    1   2   3