Are you sure it was this change and not r245265?
On Aug 17, 2015 10:41 PM, "Justin Bogner via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: bogner
> Date: Tue Aug 18 00:40:20 2015
> New Revision: 245267
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245267&view=rev
> Log:
> Revert
Author: rsmith
Date: Tue Aug 18 15:39:29 2015
New Revision: 245346
URL: http://llvm.org/viewvc/llvm-project?rev=245346&view=rev
Log:
Initialize the AST consumer as soon as we have both an ASTConsumer and an
ASTContext. Fixes some cases where we could previously initialize the AST
consumer more tha
On Tue, Aug 18, 2015 at 1:52 PM, Gábor Horváth wrote:
> On 18 August 2015 at 13:41, Richard Smith wrote:
>
>> On Tue, Aug 18, 2015 at 12:59 PM, Gábor Horváth
>> wrote:
>>
>>> Hi!
>>>
>>> In r244416 you made createModuleManager to call the In
Author: rsmith
Date: Tue Aug 18 16:53:42 2015
New Revision: 245361
URL: http://llvm.org/viewvc/llvm-project?rev=245361&view=rev
Log:
Range-based-for-convert some loops in ASTWriter. No functionality change
intended.
Modified:
cfe/trunk/include/clang/Basic/Module.h
cfe/trunk/lib/Serializa
On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
> > On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
> > wrote:
> >> Author: majnemer
> >> Date: Thu Aug 6 15:56:55 2015
> >
Author: rsmith
Date: Tue Aug 18 18:42:23 2015
New Revision: 245390
URL: http://llvm.org/viewvc/llvm-project?rev=245390&view=rev
Log:
[modules] Fix HeaderFileInfo serialization to store all the known owning
modules for a header, not just the current favourite.
Modified:
cfe/trunk/include/clan
Author: rsmith
Date: Tue Aug 18 18:42:50 2015
New Revision: 245391
URL: http://llvm.org/viewvc/llvm-project?rev=245391&view=rev
Log:
[modules] Tests for r245390.
Added:
cfe/trunk/test/Modules/Inputs/explicit-build-overlap/
cfe/trunk/test/Modules/Inputs/explicit-build-overlap/a.h
cfe/t
On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote:
> Richard, do you think there's anything we could do better here?
>
> It seems difficult to support proper move semantic behavior for
> [Sema]DiagnosticBuilder across the two common use cases:
>
> DiagnosticBuilder D;
> D << x;
> D << y;
rsmith added a subscriber: rsmith.
rsmith added a comment.
LGTM
http://reviews.llvm.org/D12110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard, I tried to ping you on the review thread but I'm not sure it
> got through. Martell requested this be merged to 3.7. What do you
> think?
Sure, this looks fine for branch.
> On Thu, A
rsmith added a comment.
This looks fine; can you add a testcase?
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote:
> Richard, I tried to ping you on the review thread but I'm not sure it
> got through. Martell requested this be merged to 3.7. What do you
> think?
LGTM
> On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits
> wrote:
> > Auth
On Tue, Aug 18, 2015 at 10:05 AM, Serge Pavlov wrote:
> sepavloff added inline comments.
>
>
> Comment at: lib/AST/DeclBase.cpp:273
> @@ +272,3 @@
> +return true;
> + if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
> +return ClassD->isLocalClass() && !ClassD->isLambda()
rsmith added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
-
Author: rsmith
Date: Tue Aug 18 21:30:28 2015
New Revision: 245406
URL: http://llvm.org/viewvc/llvm-project?rev=245406&view=rev
Log:
[modules] Don't eagerly deserialize so many ImportDecls. CodeGen basically
ignores ImportDecls imported from modules, so only eagerly deserialize the ones
from a P
On Wed, Aug 19, 2015 at 10:02 AM, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yrnkrn
> Date: Wed Aug 19 12:02:32 2015
> New Revision: 245459
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245459&view=rev
> Log:
> According to i686 ABI, long double size on x86 is 12
Author: rsmith
Date: Wed Aug 19 15:49:38 2015
New Revision: 245497
URL: http://llvm.org/viewvc/llvm-project?rev=245497&view=rev
Log:
Internal-linkage variables with constant-evaluatable initializers do not need
to be emitted. (Also reduces the set of variables that need to be eagerly
deserialize
Author: rsmith
Date: Wed Aug 19 16:09:32 2015
New Revision: 245501
URL: http://llvm.org/viewvc/llvm-project?rev=245501&view=rev
Log:
[modules] Don't needlessly bounce through Sema when updating exception
specifications.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk
rsmith added a subscriber: rsmith.
Comment at: include/clang/Frontend/CodeGenOptions.def:164-165
@@ -163,1 +163,4 @@
+CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should
contain
+ ///< external references to a PCH or module
It looks like this would only happen for a late-parsed template that the
analysis code is checking before it is parsed. Should we really be running
these checks at all in that case?
Also, it looks like this code doesn't actually want the body at all, and
just wants to get the location of the defin
Author: rsmith
Date: Wed Aug 19 16:59:52 2015
New Revision: 245509
URL: http://llvm.org/viewvc/llvm-project?rev=245509&view=rev
Log:
Add missing comment.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/
LGTM for branch.
On Aug 20, 2015 9:47 AM, "Hans Wennborg" wrote:
> It was requested that this be merged to 3.7.
>
> Richard: OK for merging?
>
> Thanks,
> Hans
>
> On Thu, Aug 20, 2015 at 6:11 AM, Olivier Goffart via cfe-commits
> wrote:
> > Author: ogoffart
> > Date: Thu Aug 20 08:11:14 2015
>
Author: rsmith
Date: Thu Aug 20 15:45:25 2015
New Revision: 245609
URL: http://llvm.org/viewvc/llvm-project?rev=245609&view=rev
Log:
PR24483: Delete some dead/incorrect code that triggered assertions.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaTemplate/instantiate-va
>
None of that answers my question. Our default GCC-compatible behavior for
x86_32 long double is to give it 4-byte alignment, 12-byte size, and this
matches the behavior I observe with GCC. Does MinGW /really/ deviate from
this and give long double a 16-byte alignment?
> 2015-08-19 21
On Wed, Aug 19, 2015 at 2:52 PM, Aaron Ballman
wrote:
> On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith
> wrote:
> > It looks like this would only happen for a late-parsed template that the
> > analysis code is checking before it is parsed. Should we really be
> running
&g
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of tweaks. Thanks!
Comment at: lib/AST/DeclBase.cpp:276
@@ +275,3 @@
+ return false;
+LDC = LDC->getParent();
+ }
er used in the condition of a #if that is not
#defined; this is a standard feature of the C preprocessor.
> Cheers,
> Charles
>
> -Original Message-
> From: Justin Bogner [mailto:jus...@justinbogner.com] On Behalf Of Justin
> Bogner
> Sent: Monday, August 17, 2015 9:28 P
rsmith added a comment.
Can you please give a brief description of the motivation for this change? When
would it be appropriate to use this rather than `-ftrap-function`?
Please also include an update for the Clang documentation to describe the new
flag.
http://reviews.llvm.org/D12181
n() {
> struct {
> char c[1];
> long double d;
> } s;
> std::cout<<&s.c< std::cout<<&s.d< }
> sh-4.3$ g++ a.cpp&&./a.exe
> 0x28fea0
> 0x28fea4
>
> I'll fix that.
>
>
> 2015-08-21 0:13 GMT+03:00 Richard Smith :
>
&
gt;> application
>>> > binary interface. This is the default.
>>> >
>>> >
>>> > You can check long double size out by running
>>> >
>>> > #include
>>> > int main() {
>>> > long double a;
>>>
Hans, it looked like you might have wanted PR24483 fixed for 3.7. If so,
this patch is safe for branch.
On Thu, Aug 20, 2015 at 1:45 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Aug 20 15:45:25 2015
> New Revision: 24560
rsmith added a comment.
In http://reviews.llvm.org/D12181#229358, @rsmith wrote:
> Can you please give a brief description of the motivation for this change?
> When would it be appropriate to use this rather than `-ftrap-function`?
I'd still like an answer to this. It's not clear to me what th
rsmith added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
rsmith added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4763
@@ +4762,3 @@
+ /// arithmetic.
+ bool UseStrictCastingRules;
+
This should be handled as an `EvaluationMode`.
Comment at: lib/AST/ExprConstant.cpp:4879-4907
@@ +4878,31 @@
On Thu, Aug 20, 2015 at 6:39 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin created this revision.
> mzolotukhin added reviewers: hfinkel, doug.gregor, t.p.northover, ab,
> mcrosier.
> mzolotukhin added a subscriber: cfe-commits.
> Herald added a subscrib
Author: rsmith
Date: Thu Aug 20 22:04:33 2015
New Revision: 245664
URL: http://llvm.org/viewvc/llvm-project?rev=245664&view=rev
Log:
[modules] When we see a definition of a function for which we already have a
non-visible definition, skip the new definition to avoid ending up with a
function with
rsmith added a comment.
Thanks for the rework, the general approach here seems reasonable.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680
@@ +7679,3 @@
+def err_omp_section_length_undefined : Error<
+ "section length is unspecified, but subscripted value is not an
On Fri, Aug 21, 2015 at 12:14 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin added a comment.
>
> Oh, I see. So, you meant something like this?
>
> void foo(std::vector av, float *
> b, int N) {
> for (auto a: av) // << `a` doesn't have nontemp
On Fri, Aug 21, 2015 at 10:35 AM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Yes, I've considered a builitin as an alternative. In fact, I started with
> it as it was easier to implement, but then decided to switch to type
> attribute due to the following reasons:
>
On Fri, Aug 21, 2015 at 4:59 PM, Michael Zolotukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mzolotukhin added a comment.
>
> Thanks for the feedback everyone!
> I think at this point I'll try to return to builtins then. In my original
> patch I didn't have type overloading, so I'll
Author: rsmith
Date: Fri Aug 21 20:47:18 2015
New Revision: 245779
URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev
Log:
[modules] Rearrange how redeclaration chains are loaded, to remove a walk over
all modules and reduce the number of declarations we load when loading a
redeclaration
Author: rsmith
Date: Fri Aug 21 21:09:38 2015
New Revision: 245780
URL: http://llvm.org/viewvc/llvm-project?rev=245780&view=rev
Log:
[modules] Remove some dead code after r245779.
Modified:
cfe/trunk/include/clang/Serialization/ASTReader.h
cfe/trunk/lib/Serialization/ASTReader.cpp
cfe
Author: rsmith
Date: Sat Aug 22 15:13:39 2015
New Revision: 245789
URL: http://llvm.org/viewvc/llvm-project?rev=245789&view=rev
Log:
[modules] Further simplification and speedup of redeclaration chain loading.
Instead of eagerly deserializing a list of DeclIDs when we load a module file
and doing
Author: rsmith
Date: Sat Aug 22 16:37:34 2015
New Revision: 245794
URL: http://llvm.org/viewvc/llvm-project?rev=245794&view=rev
Log:
Improve the performance of resolving a lookup result. We usually don't need to
pick the most recent declaration, and we can often tell which declaration is
more rece
Author: rsmith
Date: Sun Aug 23 22:33:22 2015
New Revision: 245821
URL: http://llvm.org/viewvc/llvm-project?rev=245821&view=rev
Log:
[modules] Stop updating all identifiers when writing a module. This is
unnecessary in C++ modules (where we don't need the identifiers for their
Decls) and expensive
Author: rsmith
Date: Sun Aug 23 22:38:11 2015
New Revision: 245822
URL: http://llvm.org/viewvc/llvm-project?rev=245822&view=rev
Log:
[modules] If local submodule visibility is disabled, don't bother checking
whether the owning module of a hidden declaration is visible -- it can't be.
Modified:
Author: rsmith
Date: Mon Aug 24 16:59:32 2015
New Revision: 245881
URL: http://llvm.org/viewvc/llvm-project?rev=245881&view=rev
Log:
[modules] Remove unnecessary deserialization of fully-external HeaderFileInfos
for all files we've seen in this compilation.
Modified:
cfe/trunk/include/clang/
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Comment at: lib/Sema/SemaExpr.cpp:4035
@@ +4034,3 @@
+ // Build an unanalyzed expression if either operand is type-dependent.
+ if (Base->isTypeDependent() ||
+static void escape(llvm::raw_ostream &OS, StringRef String) {
+ for (auto C: String) {
+if (strchr("\\\"", C))
+ OS << '\\';
+OS << C;
+ }
+}
Do we not have an existing function somewhere to do that? Also, that strchr
call is a very complex way of writing (C == '\\' || C == '"')
O
On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman
wrote:
> aaron.ballman created this revision.
> aaron.ballman added reviewers: alexfh, rsmith.
> aaron.ballman added a subscriber: cfe-commits.
>
> Per [except.handle]p10, the handler for a constructor or destructor
> function-try-block cannot refer
On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman
wrote:
> On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith
> wrote:
> > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman
> > wrote:
> >>
> >> aaron.ballman created this revision.
> >> aaron.ballman added
LGTM
On Mon, Aug 10, 2015 at 7:08 PM, Nick Lewycky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This simple-minded patch extends the case where we report "no viable
> conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable
> conversion from returned value of type 'X' to
On Mon, Aug 24, 2015 at 5:50 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> echristo added inline comments.
>
>
> Comment at: include/clang/Driver/Options.td:1853
> @@ -1853,1 +1852,3 @@
> +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use link
t for compatibility seems OK.
Can we produce an accompanying "deprecated" warning suggesting use of the
other name?
> Thank you,
>
> Filipe
>
>
> On Mon, Aug 24, 2015 at 6:45 PM, Richard Smith
wrote:
>>
>> On Mon, Aug 24, 2015 at 5:50
On Tue, Aug 25, 2015 at 1:39 PM, Filipe Cabecinhas <
filcab+llvm.phabrica...@gmail.com> wrote:
> Hi Richard,
>
> On Tue, Aug 25, 2015 at 11:01 AM, Richard Smith
> wrote:
>
>> On Aug 25, 2015 10:26 AM, "Filipe Cabecinhas" <
>> filcab+llvm.phab
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, sorry for the delay.
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:2074-2078
@@ +2073,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const {
+OS << "\n";
+ }
+ }];
+}
On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman
wrote:
> aaron.ballman created this revision.
> aaron.ballman added reviewers: rsmith, hans.
> aaron.ballman added a subscriber: cfe-commits.
>
> PR24559 brings up a long-standing issue in Clang where attribute order
> with differing syntax impacts
On Wed, Aug 26, 2015 at 1:55 PM, Aaron Ballman
wrote:
> On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith
> wrote:
> > On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman >
> > wrote:
> >>
> >> aaron.ballman created this revision.
> >> aaron.ballman a
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.def:1249-1255
@@ +1248,9 @@
+BUILTIN(__builtin_nontemporal_store, "v.", "t")
+BUILTIN(__builtin_nontemporal_store_1, "vcc*.", "")
+BUILTIN(__builtin_nontemporal_store_2, "vss*.", "")
+BUILTIN(__builtin_nontempo
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:221
@@ -220,4 +220,3 @@
- virtual bool canEmitAvailableExternallyVTable(
- const CXXRecordDecl *RD) const = 0;
+ virtual bool canEmitUnusedVTable(const CXXRecordDecl *RD) const = 0;
This w
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with some comment tweaks.
Comment at: lib/CodeGen/CGClass.cpp:1861
@@ +1860,3 @@
+ // We also have to make sure if we can refer to vtable:
+ // - If vtable is external
Author: rsmith
Date: Wed Aug 26 18:55:49 2015
New Revision: 246124
URL: http://llvm.org/viewvc/llvm-project?rev=246124&view=rev
Log:
[modules] The key to a DeclContext name lookup table is not actually a
DeclarationName (because all ctor names are considered the same, and so on).
Reflect this in t
rsmith added a subscriber: rsmith.
Comment at: lib/CodeGen/CGClass.cpp:1369-1382
@@ +1368,16 @@
+
+void VisitCallExpr(const Expr *E) {
+ Sensitive = true;
+}
+void VisitCXXTypeidExpr(const Expr *E) {
+ Sensitive = true;
+}
+void VisitExpr(const Expr *
rsmith added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3923
@@ +3922,3 @@
+
+void Parser::MaybeParseAttributes(unsigned WhichAttrKinds,
+ ParsedAttributesWithRange &Attrs,
Please provide an inlineable wrapper for this
On Thu, Aug 27, 2015 at 10:47 AM, Justin Bogner
wrote:
> Richard Smith via cfe-commits writes:
> > Author: rsmith
> > Date: Fri Aug 21 20:47:18 2015
> > New Revision: 245779
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev
> > Log
Author: rsmith
Date: Thu Aug 27 16:38:25 2015
New Revision: 246215
URL: http://llvm.org/viewvc/llvm-project?rev=246215&view=rev
Log:
Don't call a member function on a null pointer.
Modified:
cfe/trunk/lib/Serialization/ASTWriterDecl.cpp
Modified: cfe/trunk/lib/Serialization/ASTWriterDecl.cpp
On Sat, Aug 22, 2015 at 1:16 AM, Vassil Vassilev wrote:
> On 22/08/15 03:47, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Fri Aug 21 20:47:18 2015
>> New Revision: 245779
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=245779&vie
rsmith added a comment.
In http://reviews.llvm.org/D12181#234590, @jmgao wrote:
> Ping, I think @samsonov was waiting on @rsmith's feedback on the following:
>
> In http://reviews.llvm.org/D12181#229493, @jmgao wrote:
>
> > The goal is to be able to give a useful fsanitize-specific error message
On Thu, Aug 27, 2015 at 3:49 PM, John McCall wrote:
> rjmccall added inline comments.
>
>
> Comment at: include/clang/Driver/Options.td:990
> @@ -988,2 +989,3 @@
> "value range">;
> +def fstrict_vptrs: Flag<["-"], "fstrict-vptrs">, Group,
> Flags<[CC1Option]>;
> def
Author: rsmith
Date: Thu Aug 27 21:43:42 2015
New Revision: 246263
URL: http://llvm.org/viewvc/llvm-project?rev=246263&view=rev
Log:
PR24597: Fix in-place evaluation of call expressions to provide a proper "this"
pointer to an RVO construction of a returned object.
Modified:
cfe/trunk/lib/AST
On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara wrote:
> Comparing the result of InitListExpr::getSyntacticForm between r224986
> and r245836 I've discovered that integer to char implicit cast for
> integer literal 3 is no longer added to AST for C++ (while it is present
> in C).
>
> This is the
Author: rsmith
Date: Fri Aug 28 17:33:53 2015
New Revision: 246347
URL: http://llvm.org/viewvc/llvm-project?rev=246347&view=rev
Log:
PR24612: Don't bail out of checking a constexpr function before checking
whether it can ever produce a constant expression in the case where it has a
void return typ
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:3709
@@ -3708,3 +3708,3 @@
VAArgExpr(SourceLocation BLoc, Expr* e, TypeSourceInfo *TInfo,
-SourceLocation RPLoc, QualType t)
+SourceLocation RPLoc, QualType t, bool IsMS = false)
: E
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3387-3392
@@ -3386,4 +3386,8 @@
- llvm::Value *ArgValue = CGF.EmitVAListRef(VE->getSubExpr());
- llvm::Value *ArgPtr = CGF.EmitVAArg(ArgValue, VE->getType());
+ llvm::Value *ArgValue = VE->isMicrosoftABI()
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM.
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Couple of thoughts, but LGTM.
Comment at: lib/Sema/SemaExprMember.cpp:889
@@ +888,3 @@
+S = S->getParent();
+ } while (S != S->getFnParent());
+ return false;
--
Author: rsmith
Date: Mon Aug 31 17:17:11 2015
New Revision: 246497
URL: http://llvm.org/viewvc/llvm-project?rev=246497&view=rev
Log:
[modules] Rework serialized DeclContext lookup table management. Instead of
walking the loaded ModuleFiles looking for lookup tables for the context, store
them all
Author: rsmith
Date: Mon Aug 31 17:43:10 2015
New Revision: 246504
URL: http://llvm.org/viewvc/llvm-project?rev=246504&view=rev
Log:
[modules] Add some missing blockinfo records.
Modified:
cfe/trunk/include/clang/Serialization/ASTBitCodes.h
cfe/trunk/lib/Serialization/ASTWriter.cpp
Modif
On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Mon Aug 31 13:39:22 2015
> New Revision: 246468
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev
> Log:
> Pull the target attribute parsing out of CGCa
Author: rsmith
Date: Mon Aug 31 20:37:34 2015
New Revision: 246521
URL: http://llvm.org/viewvc/llvm-project?rev=246521&view=rev
Log:
[modules] Preserve DeclID order when merging lookup tables to give a more
predictable diagnostic experience. The hash-of-DeclID order we were using
before gave diffe
Author: rsmith
Date: Mon Aug 31 21:02:09 2015
New Revision: 246524
URL: http://llvm.org/viewvc/llvm-project?rev=246524&view=rev
Log:
Use a more appropriate way of writing 1.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
http://l
Author: rsmith
Date: Mon Aug 31 21:35:58 2015
New Revision: 246526
URL: http://llvm.org/viewvc/llvm-project?rev=246526&view=rev
Log:
Don't use fprintf to emit this diagnostic!
Added:
cfe/trunk/test/PCH/datetime.c
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:479
@@ +478,3 @@
+ /// that may occur. The intent of this mode is to determine an LValue's
+ /// Offset, so things not ordinarily allowed in constexprs
+ /// (reinterpret_casts, OOB array indices, et
Author: rsmith
Date: Tue Sep 1 02:41:55 2015
New Revision: 246534
URL: http://llvm.org/viewvc/llvm-project?rev=246534&view=rev
Log:
[modules] When emitting line tables, only emit filenames that are actually
referenced by the entries that we emit.
Modified:
cfe/trunk/lib/Serialization/ASTRea
Command 2: "C:/llvm-clean/msvc/RELWITHDEBINFO/bin/clang.EXE" "-cc1"
>> "-internal-isystem" "C:\llvm-clean\m
>>svc\RELWITHDEBINFO\bin\..\lib\clang\3.8.0\include" "-nostdsysteminc"
>> "-include-pch" "C:\llvm-clean\msvc\tools\clang
&
On Tue, Sep 1, 2015 at 6:26 AM, Aaron Ballman
wrote:
> On Tue, Sep 1, 2015 at 4:43 AM, İsmail Dönmez
> wrote:
> > Hi,
> >
> > On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits
> > wrote:
> >> Author: rsmith
> >> Date: Mon Aug 31 17:17
Author: rsmith
Date: Tue Sep 1 15:35:42 2015
New Revision: 246582
URL: http://llvm.org/viewvc/llvm-project?rev=246582&view=rev
Log:
Re-commit r246497 (and dependent changes r246524 and r246521), reverted in
r246546, with a workaround for an MSVC 2013 miscompile and an MSVC 2015
rejects-valid.
Or
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:42-44
@@ -33,1 +41,5 @@
bool CodeGenModule::TryEmitBaseDestructorAsAlias(const CXXDestructorDecl *D) {
+ // If sanitizing memory to check for use-after-dtor, do not emit as
+ // an alias, unless it has no fields or
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.h:85
@@ +84,3 @@
+ /// \brief Return true if this function is a target-specific builtin
+ bool isTSBuiltin(unsigned ID) const {
+return ID >= Builtin::FirstTSBuiltin;
I would prefer the m
On Sep 2, 2015 9:38 AM, "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is
> rather sparse. These tools are starting to get more attention from the
> community, and I am wondering whether it would make sense to
Author: rsmith
Date: Wed Sep 2 12:45:54 2015
New Revision: 246680
URL: http://llvm.org/viewvc/llvm-project?rev=246680&view=rev
Log:
[modules] Don't waste time reading in the names the module file writer gave to
blocks. We don't need these names, and decoding the corresponding bitcode has a
sign
rsmith added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:485
@@ +484,3 @@
+ std::string Name = Fn->getName();
+ std::string InlineName = Name + ".inlinefunction";
+ Fn->setName(InlineName);
I have a slight preference for ".alwaysinline" over ".in
rsmith added a comment.
I'd like to see some tests for poisoning bitfields, and particularly anonymous
bitfields (I think the code works fine in those cases, but they're a bit
special so explicitly testing them is useful).
Comment at: lib/CodeGen/CGCXX.cpp:151
@@ +150,3 @@
+
rsmith added a comment.
Functionally LGTM, but please add a test case. Is there any precedent for how
to spell these module flags (StrictVTablePointers / strict_vtable_pointers /
strict.vtable.pointers)?
http://reviews.llvm.org/D12580
___
cfe-comm
On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote:
> On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote:
>
>> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote:
>> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits <
>> >
>> > cfe-commits@lists.llvm.org> wrote:
>> > > H
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXX.cpp:140-147
@@ -131,1 +139,10 @@
+ // If sanitizing memory to check for use-after-dtor, do not emit as
+ // an alias, unless this class owns no members with trivial destructors.
+ const CXXMethodDecl *MD =
+ ca
On Thu, Sep 3, 2015 at 2:26 PM, Olivier Goffart wrote:
> On Thursday 3. September 2015 13:41:12 Richard Smith wrote:
> > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote:
> > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart
> wrote:
> > >> On Monday 31. A
2701 - 2800 of 6740 matches
Mail list logo
