rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land.
LGTM with a couple of tweaks. Thanks! ================ Comment at: lib/AST/DeclBase.cpp:276 @@ +275,3 @@ + return false; + LDC = LDC->getParent(); + } while (LDC); ---------------- `getLexicalParent()`? ================ Comment at: lib/AST/DeclBase.cpp:277-278 @@ +276,4 @@ + LDC = LDC->getParent(); + } while (LDC); + return false; +} ---------------- I think we can actually recast this loop as `while (true)`, since we must eventually reach the TU and return false. http://reviews.llvm.org/D11194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
