rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM with some comment tweaks. ================ Comment at: lib/CodeGen/CGClass.cpp:1861 @@ +1860,3 @@ + // We also have to make sure if we can refer to vtable: + // - If vtable is external then it's safe to use it (for availabe_externally + // CGVTables will make sure if it can emit it). ---------------- Typo "availabe" ================ Comment at: lib/CodeGen/CGClass.cpp:1863 @@ +1862,3 @@ + // CGVTables will make sure if it can emit it). + // - Otherwise we can refer to vtable if it's unused. + // FIXME: If vtable is used by ctor/dtor, we are always safe to refer to it. ---------------- unused -> safe to speculatively emit http://reviews.llvm.org/D12385 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
