[PATCH] D132742: [X86][BF16] Add type mangling for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGa845d8fc57b6: [X86][BF16] Add type mangling for Windows (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llv

[PATCH] D132742: [X86][BF16] Add type mangling for Windows

pengfei added a comment. Thanks @FreddyYe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llvm.org/D132742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D133920: [X86][fastcall] Move capability check before free register update

pengfei created this revision. pengfei added a reviewer: rnk. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: #57737 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133920 File

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

pengfei added a comment. Reverse ping. Any progress or plan for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86855/new/ https://reviews.llvm.org/D86855 ___ cfe-commits mailing list cfe-commi

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5d781d6273c: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rG527ef8ca981e: Reland "[X86] Support `_Float16` on SSE2 and up" (authored by pengfei). Herald added subscribers: Sanitizers, Enna1, mgorny. Herald added a project: Sanitizers. Changed prior to commit: ht

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a subscriber: vitalybuka. pengfei added a comment. Thanks @vitalybuka ! I believe the fail was caused by missing `COMPILER_RT_HAS_FLOAT16` in these tests. Relanded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://re

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. Thanks @benlangmuir for the revert. The problem seems Darwin supports the `_Float16` type already but with a different ABI. I have no idea how to solve the problem ATM. Post a question on discourse: https://discourse.llvm.org/t/compiler-rt-tests-fail-on-darwin-stage1-bu

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619265 , @alexfh wrote: > @pengfei could you fix the Darwin tests as well? And a general comment > regarding the ongoing `_Float16` effort: I think that this change should have > been a part of https://reviews.llvm.o

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441222. pengfei added a comment. Disable `extendhfsf2/truncsfhf2` tests on Darwin to avoid the fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: clang/do

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a comment. In D128571#3619438 , @pengfei wrote: > In D128571#3619265 , @alexfh wrote: > >> @pengfei could you fix the Darwin tests as well? And a general comment >> regarding the ongoing `_Float16`

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441236. pengfei added a comment. Exclude the ABI change on Darwin platform. Will enable it by a followup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: cla

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei updated this revision to Diff 441272. pengfei added a comment. Address review comments. Thanks @MaskRay ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 Files: clang/docs/LanguageExtensions.rst

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:357 +// Turn on _float16 for x86 (feature sse2) +HasFloat16 = SSELevel >= SSE2; MaskRay wrote: > MaskRay wrote: > > `_Float16` > > > > `for x86` convey no extra information sinc

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabeeae570eff: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D128571?vs=441272&i

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Am I understanding correctly? @pengfei you are interested in the > -fexcess-precision=16 part of this right? @rjmccall what do yo think? I agree with @rjmccall , we just need to disable what we do here for `-fexcess-precision=16`. CHANGES SINCE LAST ACTION https:/

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#3626632 , @sylvestre.ledru wrote: > Same as in https://reviews.llvm.org/D114099 > It breaks the build on ubuntu bionic, Hirsute, etc on amd64: > > > "/build/llvm-toolchain-snapshot-15~++20220702091600+23ee84f43201/b

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. FYI, `COMPILER_RT_HAS_FLOAT16` is set according to https://github.com/llvm/llvm-project/blob/main/compiler-rt/cmake/builtin-config-ix.cmake#L25-L31 and https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/CMakeLists.txt#L699 Repository: rG LLVM Gi

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

pengfei commandeered this revision. pengfei edited reviewers, added: zahiraam; removed: pengfei. pengfei added a comment. This patch was replaced by D128571 . Let me commandeer and abandon it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ h

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Then we need to add the option -fexcess-precision. I am not sure for now > where and what values the _FLT_EVAL_METHOD should have when excess precision > is enabled/disabled. I'm fine with a follow up patch to enable this option. Please notice LLVM15 will branch on J

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#3628120 , @sylvestre.ledru wrote: > @pengfei I am not convinced it is an issue on my side. I don't have anything > particular in this area and using a stage2 build system. > > Anyway, this patch fixes the issue on my

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Hi @jeanPerier , yes, you are right. This patch changes the calling conversion of fp16 from GPRs to XMMs. So you need to update the runtime. If you are using compiler-rt, you could simply re-build it with trunk code, or at least after rGabeeae57

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Thanks for confirming it! I don't have much experience in compiler-rt. But I think the version of clang matters much to compiler-rt particular in ABI changing cases like this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Thanks @clementval for reporting it and the reproducer. Put a patch D129294 to address it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added a comment. Ping? We have internal request for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 418448. pengfei marked 2 inline comments as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/i

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:590 + /// Log 2 of the maximum vector width. + unsigned MaxVectorWidth : 4; + LuoYuanke wrote: > I notice some code would indicate it is log 2 size with Log2 suffix in the

[PATCH] D122104: [X86][regcall] Support passing / returning structures

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd26190a10fc: [X86][regcall] Support passing / returning structures (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https:/

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5238 + for (unsigned i = 0; i < IRCallArgs.size(); ++i) +LargestVectorWidth = std::max(LargestVectorWidth, + getMaxVectorWidth(IRCallArgs[i]->getType())); ---

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___ cfe-commits mailing list cf

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added a comment. Thanks @erichkeane @aaron.ballman ! Yeah, I didn't receive buildbots notice about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 __

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3423846 , @MaskRay wrote: > Is this a problem with D105462 ? Should > -msse4.2 imply -mcrc32? -msse4.2 implies -mcrc32: https://godbolt.org/z/xaPccrKx3 Repository: rG LLVM Github

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. So it's interesting, it shouldn't fail that way https://godbolt.org/z/jcqx5x9j7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___ cfe

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3424226 , @MaskRay wrote: > In D122789#3424213 , @pengfei wrote: > >> In D122789#3423846 , @MaskRay >> wrote: >> >>> Is this a problem

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei created this revision. pengfei added a reviewer: nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This is to addre

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

pengfei added a comment. Add to `ReleaseNotes.rst` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130964/new/ https://reviews.llvm.org/D130964 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei updated this revision to Diff 449275. pengfei marked an inline comment as done. pengfei added a comment. Add CC1 option test. > When a module with "`indirect_branch_cs_prefix`" and another without the > module flag are merged, what the result should be? If 0, we should use `Min` > inste

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

pengfei added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. We support `float` -> `bf16` in `AVX512BF16`. https://www.intel.com/cont

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) +CmdArgs.push_back("-mindirect-branch-cs-prefix"); MaskRay wrote: > This is not needed with the TableGen CC1Op

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pengfei marked an inline comment as done. Closed by commit rG6f867f910283: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk (authored by

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. Thanks for review! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) +CmdArgs.push_back("-mindirect-branch-cs-prefix"); MaskRay wrote: > pengfei wrote: > > MaskRay

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

pengfei accepted this revision. pengfei added a subscriber: aaron.ballman. pengfei added a comment. This revision is now accepted and ready to land. LGTM, but maybe wait one day or two for other FE folks' opinions. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

pengfei created this revision. pengfei added reviewers: kparzysz, thieta, abdulras, tstellar. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

pengfei added a comment. This is for LLVM 15.0 release per to #56854. Forgive me my bad English. Suggestions are welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131172/new/ https://reviews.llvm.org/D131172 _

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

pengfei closed this revision. pengfei added a comment. In D131172#3699950 , @tstellar wrote: > @pengfei You can commit this directly to the release/15.x branch whenever you > are ready. I see. Done. Thanks all! Repository: rG LLVM Github Monorepo C

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130964/new/ https://reviews.llvm.org/D130964

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. In D130754#3701837 , @nikic wrote: > This change caused a significant compile-time regression for `O0` builds > (about 1%): > http://llvm-compile-time-tracker.com/compare.php?from=45bae1be90472c696f6ba3bb4f8fabee76040fa9&to=6f86

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei added a comment. In D130754#3701858 , @pengfei wrote: > In D130754#3701837 , @nikic wrote: > >> This change caused a significant compile-time regression for `O0` builds >> (about 1%): >> http://llvm-comp

[PATCH] D131468: [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller

pengfei added a comment. D124435 is going to change the assumption :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131468/new/ https://reviews.llvm.org/D131468 ___ cfe

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4888a37d367: [X86][BF16] Enable __bf16 for x86 targets. (authored by FreddyYe, committed by pengfei). Changed prior to commit: https://reviews.ll

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

pengfei added a comment. I have the same impression. I checked ISE says AMX instructions are `N.E.` on 32-bit mode. And seems Linux Kernel only enables AMX on 64-bit too https://lwn.net/ml/linux-kernel/20210730145957.7927-22-chang.seok@inte

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Ping @jyu2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 414276. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:679 + !llvm::isPowerOf2_32(OutSize)) +targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg); + jyu2 wrote: > Error message is not very clear to me. I think we

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 414277. pengfei added a comment. Remove outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

pengfei added a comment. Typos in `wiht different feature lists` and `In the even that`. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} erichkean

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 414614. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; jyu2 wrote: > Are you sure you w

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

pengfei accepted this revision. pengfei added a comment. LGTM. Comment at: clang/lib/Basic/Targets/X86.cpp:1133 +#include "llvm/Support/X86TargetParser.def" +.Default(""); +} clang-format. Comment at: llvm/include/llvm/Support/X86TargetPa

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121815/new/ https://reviews.llvm.org/D121815

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei created this revision. pengfei added reviewers: erichkeane, craig.topper, LiuChen3, LuoYuanke. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, the regcall calling conversion in Clang d

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Ping @jyu2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 416945. pengfei added a comment. Address Yuanke's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h cla

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417179. pengfei marked 2 inline comments as done. pengfei added a comment. Herald added a subscriber: StephenFan. Address review comments. Thanks Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:744 + void setMaxVectorWidth(unsigned Width) { +MaxVectorWidth = llvm::Log2_32(Width) + 1; + } craig.topper wrote: > Are you assuming Width is a power of 2? Should we as

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 417303. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; jyu2 wrote: > pengfei wrote: > >

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added a comment. Thanks @jyu2 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32103608fc07: [Inline-asm] Add diagnosts for unsupported inline assembly arguments (authored by pengfei). Repository: rG LLVM Github Monorepo CHA

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417502. pengfei added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/Co

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei accepted this revision. pengfei added a comment. LGTM. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:6 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang -targ

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a subscriber: hjl.tools. pengfei added a comment. In D122789#3446865 , @MaskRay wrote: > To kurly (original Gentoo reporter): > > printf '#include \n#include \nuint32_t > computeHardwareCRC32(uint32_t Crc, uint32_t Data) { return _mm_crc3

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added a comment. Thanks @vtjnash for the information! Comments on https://github.com/JuliaLang/julia/issues/44829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/ https://reviews.llvm.org/D105263 _

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

pengfei accepted this revision. pengfei added a comment. LGTM for X86. Comment at: clang/lib/Headers/CMakeLists.txt:88 + +set(x86_files +# Intrinsics Verified the list is correct to X86. Nit: should make them in alphabetical order? Comment a

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. GCC supports "-mcrc32", but seems only for built-in functions: https://godbolt.org/z/veeGMoY11 https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html#x86-Options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ http

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

pengfei added a comment. > Maybe I can ask cmake to check for architecture/targets during configuration > and select the headers automatically, but that is beyond the scope of this > patch. I'm not familar with cmake, but I guess it might be doable. I once verified the X86 headers by command `

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

pengfei added a comment. > So xorl %ecx, %edx doesn't zero out all 64-bits of %rcx and %rdx? That's two > 32-bit writes to two different registers, isn't it? `xorl %ecx, %edx` only zero out bit 63:32 of `rdx`. 1. There's only 1 write to register in the instruction, i.e. `%edx`; 2. As a src, non

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3302142 , @rnk wrote: > I think LLVM already doesn't do some tail merging optimizations on inline > asm, but allowing the use of the attribute is more principled, and will block > more optimizations (CSE). IIRC, the in

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3303821 , @lebedev.ri wrote: > In D84225#3303771 , @pengfei wrote: > >> In D84225#3302142 , @rnk wrote: >> >>> I think LLVM already doesn't

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3305140 , @rnk wrote: > In D84225#3304189 , @pengfei wrote: > >> It's not a workaround. We do need to avoid the merging sometime. For >> example, given we have 2 branches begin wi

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e19ba36fca9: [X86][MS] Add 80bit long double support for Windows (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D115441

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; } aaron.ballman wrote: > xbolva00 wrote: > > pengfei

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2988-2992 +.. option:: -mconservative-extend +Always extend the integer parameter both in the callee and caller. + +.. option:: -mno-conservative-extend +Keep the original integer parameter passin

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2451 + // attribute to the callee. + if (AttrOnCallSite || AI.getKind() == ABIArgInfo::Extend) { +if (AI.isSignExt()) LiuChen3 wrote: > pengfei wrote: > > Does the change af

[PATCH] D124435: [X86] Always extend the integer parameters in callee

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/integer_argument_passing.c:2 +// RUN: %clang_cc1 -O2 -triple -x86_64-linux-gnu %s -emit-llvm -o - | FileCheck %s --check-prefixes=EXTEND,CHECK +// RUN: %clang_cc1 -O2 -triple -i386-linux-gnu %s -emit-llvm -o - | F

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb1cec371c00: [X86] Fix CodeGen Module Flag for -mibt-seal (authored by joaomoreira, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei added a comment. In D118052#3480564 , @joaomoreira wrote: > I think there are no more untied knots... @pengfei, do you think this is > ready to merge? If yes, can you please merge it? tks! Sure. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124757/new/ https://reviews.llvm.org/D124757

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei created this revision. pengfei added reviewers: FreddyYe, RKSimon, LuoYuanke, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix uninitialize

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins-constrained.c:5 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-linux-gnu -target-feature +sse -S -o - -Wall -Werror | FileCheck %s --check-prefix=CHECK-ASM --check-prefix=COMMON +// RUN

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei updated this revision to Diff 426971. pengfei added a comment. Seperated unrelated change and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124916/new/ https://reviews.llvm.org/D124916 Files: clang/lib/Headers/cetintrin.h Index

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei added a comment. In D124916#3490868 , @RKSimon wrote: > LGTM - I'm intending to add -Wsystem-headers to the clang x86 builtins tests > once everything is clean. Thanks @RKSimon! That sounds great! I was thinking the headers will do diagnosis wh

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d18a86d14a9: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push craig.topper wrote: > The argument should als

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. One question: is it better to change the define of builtins than explicit casts? Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a)

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > What do you want to do about _mm512_maskz_srli_epi16 ? The Intel Intrinsic > guide has the same mismatch. These intrinsics are interesting. The descriptions on Intrinsic guide are for immediate variant, but all compilers' implementations are register variant. What's

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. In D125164#3498752 , @RKSimon wrote: > Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ > intrinsics return unsigned so we'd still end up with adding explicit casts No problem, adding explicit casts lo

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei added a comment. > These intrinsics are interesting. The descriptions on Intrinsic guide are for > immediate variant, but all compilers' implementations are register variant. > What's more, the codegen from Clang and GCC don't seem correct according to > the description of `vpsrlw zmm0

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

pengfei added a comment. In D125170#3498913 , @RKSimon wrote: > If people prefer we can alternatively use \code{.unparsed} .. \endcode blocks > - I'm unsure if these operation blocks are being used in a particular way > downstream We have used \code ..

  1   2   3   4   5   6   >