pengfei added a comment.

> What do you want to do about _mm512_maskz_srli_epi16 ? The Intel Intrinsic 
> guide has the same mismatch.

These intrinsics are interesting. The descriptions on Intrinsic guide are for 
immediate variant, but all compilers' implementations are register variant. 
What's more, the codegen from Clang and GCC don't seem correct according to the 
description of `vpsrlw  zmm0, zmm0, xmm1`. They should do the same broadcast as 
ICC.

Back to the question, I think the type in Clang's intrinsics match with 
Intrinsic guide. They just not match each other. I guess it might be historical 
reasons, so let's keep them and using cast?



================
Comment at: clang/lib/Headers/cetintrin.h:37
 static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) {
-  __builtin_ia32_incsspd((int)__a);
+  __builtin_ia32_incsspd((unsigned int)__a);
 }
----------------
Unnecessary cast?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125164/new/

https://reviews.llvm.org/D125164

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to