pengfei added a comment. Thanks for review!
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) + CmdArgs.push_back("-mindirect-branch-cs-prefix"); ---------------- MaskRay wrote: > pengfei wrote: > > MaskRay wrote: > > > This is not needed with the TableGen CC1Option change. > > Do you have an example how to change the CC1Option? Removing the code > > directly won't generate the expected module flag anymore. > OK, sorry. A statement is needed: `Args.AddLastArg(CmdArgs, > options::OPT_mindirect_branch_cs_prefix); ` Good to know such usage. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130754/new/ https://reviews.llvm.org/D130754 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits