[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

phosek created this revision. phosek added reviewers: smeenai, int3, oontvoo, thakis. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thi

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

phosek added a comment. In D122110#3395336 , @int3 wrote: > Would it make sense to have clang pass `-object_path_lto` whenever it's > invoking LLD? It already does, see https://github.com/llvm/llvm-project/blob/afc2f024462951d6e74c5e733f4b4666e21d3309/

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

phosek added a comment. In D122110#3395427 , @int3 wrote: > Ohh gotcha. So clang assumes that the platform linker's version is at least > as high as the host linker's, assuming the host linker is ld64. That seems > kind of hacky, but I suppose it's exis

[PATCH] D122109: [CMake][Clang] Skip host link version detection for lld on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGc624cc252738: [CMake][Clang] Skip host link version detection for lld on Darwin (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122109/ne

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f4be78abc: [Clang] Set -mlinker-version explicitly in the lto test (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122110/new/ https:

[PATCH] D122047: [CMake][Fuchsia] Switch to lld on Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe997bb2dd6: [CMake][Fuchsia] Switch to lld on Apple platforms (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122047/new/ https://revi

[PATCH] D123280: [CMake][Fuchsia] Include bolt

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We would like to use bolt with Fuchsia toolchain. Repo

[PATCH] D123280: [CMake][Fuchsia] Include bolt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff78d25b8e1c: [CMake][Fuchsia] Include bolt (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed to use clang-include-fixer. Repository:

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/test/Frontend/stack-usage-safestack.c:3 + +// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s +// RUN: %clang_cc1 %s -fwarn-stack-

[PATCH] D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf21445ea870: [CMake][Fuchsia] Include find-all-symbols in the distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124053/new/

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

phosek added a comment. Have you checked if all the tests are still passing? Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:160 +AddLinkerInputs(ToolChain, Inputs, Args, CmdArgs, JA); +ToolChain.addProfileRTLibs(Args, CmdArgs); This shouldn't mov

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:158-160 +bool NeedsXRayDeps = addXRayRuntime(ToolChain, Args, CmdArgs); if (NeedsXRayDeps) linkXRayRu

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3271084 , @MaskRay wrote: > No worries! Thanks for the reply. > > I use Debian and want it to work well and support the > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` direction. > Currently, `-DLLVM_DEFAULT_TARGET_TRIPLE=a

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek created this revision. phosek added reviewers: beanz, smeenai, ldionne, compnerd. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, ar

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 409394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.sit

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek added a comment. Provide fallback for `TARGET_TRIPLE` and print a warning about deprecation and future removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

phosek added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being used

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

phosek added a comment. I'd be in favor of defaulting to an `ERROR` and providing an option to downgrade to a `WARNING`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124489/new/ https://reviews.llvm.org/D124489 __

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19190cc651ef: [Driver] Support for compressed debug info on Fuchsia (authored by phosek). Herald added a subscriber: MaskRay. Herald added a project:

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. No longer needed, this is now the Clang default. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44605/new/ https://reviews.llvm.org/D44605 ___

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek updated this revision to Diff 426182. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/compress.c Index: clang/test/Driver/compre

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. In D114115#3477967 , @probinson wrote: > Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` > (or you might factor that bit out into its own test with the REQUIRES). I have moved that test to `clang/test/D

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3481547 , @MaskRay wrote: > Probably no from my view, as I got another internal feedback that "this seems > rather crufty". > It seems that it is the build system maintainer's responsibility. If you add > `-Wno-unknown

[PATCH] D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mysterymath, haowei, leonardchan. Herald added subscribers: abrachet, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f0e741db97c: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia (authored by phosek). Herald added a subscriber: MaskRay. Herald added a

[PATCH] D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG57636c25904e: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125082/new/ http

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek abandoned this revision. phosek added a comment. This was broken up into a series of smaller changes which landed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/ https://reviews.llvm.org/D122931 ___

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile); ---

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129413/new/ https://reviews.llvm.org/D129413 ___

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This matches the standard behavior on other pl

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ed8d8209584: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +CompressedBuffer.truncate(CompressedSize)

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

phosek added a comment. In D121141#3656100 , @mstorsjo wrote: > In D121141#3655323 , @ldionne wrote: > >> The `experimental-library-flag` test is currently failing on Windows because >> on Windows, `-stdlib=libc+

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:149 + elseif(NOT LLVM_USE_SANITIZER MATCHES "Memory.*") +find_package(zstd) + endif() Since there's no `Findzstd.cmake` module shipped with CMake, and we don't provide in LLVM, we should

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek created this revision. phosek added reviewers: abrachet, paulkirth. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This should provide a

[PATCH] D130231: [WIP][clang-doc] Improve the Markdown output

phosek created this revision. phosek added reviewers: abrachet, paulkirth. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This change tries to improve the usability of Markdown output, taking

[PATCH] D130231: [WIP][clang-doc] Improve the Markdown output

phosek updated this revision to Diff 446391. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130231/new/ https://reviews.llvm.org/D130231 Files: clang-tools-extra/clang-doc/MDGenerator.cpp Index: clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D130279: [clang-doc] Add check for pointer validity

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130279/new/ https://reviews.llvm.org/D130279 ___

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Su

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125499/new/ https://reviews.llvm.org/D125499 ___

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek accepted this revision. phosek added a comment. LGTM Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Spe

[PATCH] D125570: [CMake] Disable libedit in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: paulkirth. Herald added subscribers: abrachet, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't need libedit in our toolchain build.

[PATCH] D125570: [CMake] Disable libedit in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG534f66042001: [CMake] Disable libedit in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek added a comment. D125597 should address the build error in compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 _

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X

phosek created this revision. phosek added a reviewer: abrachet. Herald added subscribers: pengfei, kristof.beyls, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to build libunwind, libc+

[PATCH] D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X

This revision was automatically updated to reflect the committed changes. Closed by commit rGe64722f686bd: [CMake][Fuchsia] Build runtimes as universal libraries on OS X (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125908/new/

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM (small nit, people usually use PRXXX rather than bXXX to refer to issues) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66681/new/ https://reviews.llvm.org/D66681

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/ https://reviews.llvm.org/D66981 ___

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL370421: [CMake][Fuchsia] Enable experimental pass manager by default (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek accepted this revision. phosek added a comment. In D66324#1653198 , @paulkirth wrote: > In D66324#1652364 , @lebedev.ri > wrote: > > > Trying to start reviewing this. > > The llvm side of the patch is self

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

phosek added a comment. In D59754#1656217 , @leonardchan wrote: > Hi! We've noticed that for our arm bots, we're getting some flaky builds that > sometimes fail with `error: array designators are a C99 extension > [-Werror,-Wc99-designator]` and sometime

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL309724: [CMake] Include sancov tool in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35930?vs=108418&id=109173#toc Repository: rL LLVM https://reviews.ll

[PATCH] D36194: [CMake] Include llvm-objcopy tool in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D36194 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() mcgrathr wrote: > ph

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

phosek created this revision. Herald added a subscriber: mgorny. Don't support or build static C++ libraries for Fuchsia. Repository: rL LLVM https://reviews.llvm.org/D36202 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.cpp Index: test

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112 ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); -if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bdynamic"); - } CmdArgs.push_back("-lm"); } mc

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL309778: [Driver] Disable static C++ library support on Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36202?vs=109255&id=109258#toc Repository: rL LLVM https://revi

[PATCH] D36194: [CMake] Include llvm-objcopy tool in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL309786: [CMake] Include llvm-objcopy tool in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36194?vs=109233&id=109265#toc Repository: rL LLVM https://revi

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added a comment. One more thing, would it be possible add a test case to `test/Driver/fuchsia.c` covering this? Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek accepted this revision. phosek added a comment. LGTM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

phosek updated this revision to Diff 109485. Repository: rL LLVM https://reviews.llvm.org/D35820 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp Index: lib/Driver/ToolChain.cpp === --

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL30: Enable AddressSanitizer for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35922?vs=109605&id=109645#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL310017: [Driver][Fuchsia] Pass --hash-style=gnu to the linker (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36254?vs=109603&id=109677#toc Repository: rL LLVM https://revie

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 109852. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++ c

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") mcgrathr wrote: > Can you do this without duplicating all the

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 110311. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++ c

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

This revision was automatically updated to reflect the committed changes. Closed by commit rL310548: [Driver] Search compiler-rt paths in -print-file-name= (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35820?vs=109485&id=110515#toc Repository: rL LLVM https://revi

[PATCH] D36541: [CMake] Include LLVMFuzzer in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL310901: [CMake] Include LLVMFuzzer in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36541?vs=110452&id=03#toc Repository: rL LLVM https://reviews.llv

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL311033: [CMake] Build sanitized C++ runtimes for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36349?vs=110311&id=111399#toc Repository: rL LLVM https://reviews.ll

[PATCH] D36779: [Driver] SafeStack does not need a runtime library on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL311034: [Driver] SafeStack does not need a runtime library on Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36779?vs=111301&id=111400#toc Repository: rL LLVM https

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

phosek created this revision. phosek added a reviewer: xazax.hun. Herald added subscribers: cfe-commits, tschuett, rnkovacs, mgorny. Herald added a project: clang. We would like to use clang-scan-deps in Fuchsia build so include it in the toolchain distribution. Repository: rG LLVM Github Mono

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGb63bc648a489: [CMake] clang-scan-deps in Fuchsia distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72113/new/ https://reviews

[PATCH] D72188: [fuchsia] Enable Clang Static Analyzer

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72188/new/ https://reviews.llvm.org/D72188 ___

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG231875e111fa: [Clang] Always set -z now linker option on Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70576/new/ https://revi

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); andrewjcg wrote: > keith wrote

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2277539 , @rnk wrote: > Yeah, my goal is for the build system to be able to avoid having to embed PWD > into the compiler flags. For example, I believe it is a goal of the LLVM gn > build system for the build tree to be

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. phosek requested review of this revision. Herald added a subscriber: ormris. This flag can be used to relativize source paths againts a given directory. Compared

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2277712 , @phosek wrote: > In D83154#2277539 , @rnk wrote: > >> Yeah, my goal is for the build system to be able to avoid having to embed >> PWD into the compiler flags. For exampl

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. This change is trying to address the issues raised in D83154 . There are still some open questions: - Is `-fsource-dir` the best name for this flag? - I'm not sure if `make_relative` should be applied to all source paths, or only paths th

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2286587 , @keith wrote: > With D87928 do you think we would want this > flag as well? The only difference I can think of (besides general UX) is if > you need to remap paths outside of y

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. @keith do you plan on finishing this? I think we should change the name from `-fcoverage-prefix-map` to `-fprofile-prefix-map`, but otherwise it might be good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

phosek added a comment. This seems to have broken our Mac builders with the following error: -- Testing: 25226 tests, 24 workers -- Testing: 0.. 10.. 20. FAIL: Clang :: Frontend/ast-main.c (6834 of 25226) TEST 'Clang :: Frontend/ast-main.c' FAILED **

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd58fd4e52197: [compiler-rt] Compile assembly files as ASM not C (authored by phosek). Repository: rG LLVM Github Monore

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

phosek added a comment. In D86308#2228917 , @tambre wrote: > I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is > enabled by compiler-rt anyway and CMake can recognize the files as assembly > anyway. Can we remove that function a

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2231927 , @mati865 wrote: > @phosek in MSYS2 (targeting x86_64-w64-windows-gnu) Zlib works properly for > LLVM 10 but with master I'm now seeing: > > -- Constructing LLVMBuild project information > -- DEBUG zlib_libra

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

phosek added a comment. We started seeing assertion failure after rolling a toolchain that contains this change and `git bisect` identified this change. I have filed a bug with a reproducer as PR47324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D86822: [clang] Enable -fsanitize=thread on Fuchsia.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86822/new/ https://reviews.llvm.org/D86822 ___ c

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

phosek added a comment. This was discussed when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` was introduced and there was a pushback against changing the driver behavior depending on the value of that option, so if we're going to reverse that decision for BareMetal, I think that deserves a broader disc

[PATCH] D86877: [Clang][Driver] Support per-target runtime directories in the bare-metal toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 ___ c

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

phosek added a comment. It's not clear why couldn't we support per-target runtime directory? It uses the standard multiarch layout, so in you'd end up using a directory like `[path/to/resource-dir]/lib/armv6m-unknown-eabi/libclang_rt.builtins.a`. I'd find this more preferable for consistency wi

[PATCH] D92792: [clang] - Also look for devtoolset-10

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792 ___ c

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLO

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek updated this revision to Diff 303567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/include/clang/Lex/PreprocessorOptions.h clang/lib/Co

<    3   4   5   6   7   8   9   10   11   12   >