phosek accepted this revision. phosek added a comment. LGTM
================ Comment at: clang/test/Frontend/stack-usage-safestack.c:3 + +// RUN: %clang_cc1 %s -fwarn-stack-size=48 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=REGULAR %s +// RUN: %clang_cc1 %s -fwarn-stack-size=1060 -S -o - -triple=i386-apple-darwin 2>&1 | FileCheck --check-prefix=IGNORE %s ---------------- Is there any particular reason for using the `i386-apple-darwin` triple here and below? I'm not even sure if SafeStack is officially supported and tested on Darwin, `x86_64-linux` may be a safer choice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
