phosek added inline comments.
================ Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() ---------------- mcgrathr wrote: > phosek wrote: > > I think we also need: > > ``` > > set(RUNTIMES_${target}-fuchsia_SANITIZER_CXX_ABI "libcxxabi" ON CACHE > > STRING "") > > ``` > > > > > That seems to default correctly when building it all together. > Should we add it anyway? You're right, it's set by default so it's not needed. Repository: rL LLVM https://reviews.llvm.org/D35922 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits