[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. In D59264#1428785 , @MaskRay wrote: > > A nonzero __dso_handle has to match the value passed to __cxa_atexit but a > > zero __dso_handle matches every function registered. So it matters that DSO > > fini calls use &__dso_handle to

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. ASan provides its own operator new/delete to intercept all allocations and deallocations. Current

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek added a subscriber: ldionne. phosek added a comment. In D60235#1454152 , @mcgrathr wrote: > IMHO the library code should use `#if !__has_feature(...)` to avoid the > definitions entirely when built with a sanitizer whose runtime provides them. > B

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek updated this revision to Diff 193733. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-i386.o clang/test/Driver/Inputs/resourc

[PATCH] D60332: [gn] Support for per-target runtime directory layout

phosek updated this revision to Diff 194037. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60332/new/ https://reviews.llvm.org/D60332 Files: llvm/util

[PATCH] D60332: [gn] Support for per-target runtime directory layout

This revision was automatically updated to reflect the committed changes. Closed by commit rL357850: [gn] Support for per-target runtime directory layout (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60332?vs=194037&id=194038#toc Repository: rL LLVM

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

phosek added a comment. Our Mac builders have started failing after this change with the following: [3145/3502] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific Would it be possible to support the [per-target runtimes directory layout](https://github

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. @MaskRay can you review this again now that there's just a single `crtbegin.o` and `crtend.o` version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 ___ cfe-commits mailing

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1469186 , @jdenny wrote: > Is there anything I can do to help this patch make progress? I think it's ready to land. I was just waiting if anyone else wants to chime in, but it doesn't seem like. I was also thinking abo

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1472152 , @jdenny wrote: > In D59168#1470578 , @phosek wrote: > > > In D59168#1469186 , @jdenny wrote: > > > > > > > > > > > I was also thin

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek updated this revision to Diff 195934. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/runtimes/CMakeLists.txt Index: llvm/runtimes/CMakeLists.txt =

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. phosek updated this revision to Diff 195934. This is a more generic solution; while the sanitizer support can be used only for sani

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL358935: [CMake] Replace the sanitizer support in runtimes build with multilib (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60926?vs=195934&id=196159#toc Repos

[PATCH] D60990: [Driver] Support priority for multilibs

phosek created this revision. phosek added reviewers: jroelofs, bkramer. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. When more than one multilib flag matches, try to select the best possible match based on priority. When two different multilibs with the same same

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196331. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp Index: clang/lib/Driver/Multilib

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek created this revision. phosek added reviewers: beanz, jroelofs, mcgrathr. Herald added subscribers: cfe-commits, javed.absar. Herald added a project: clang. This introduces a support for multilibs to Fuchsia driver. Unlike the existing multilibs that are used primarily for handling differen

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 + +/// \p Flag must be a flag accepted by the driver with its leading '-' removed, +// otherwise '-print-multi-lib' will not emit them correctly. jroelofs wrote: > Can we e

[PATCH] D60974: Clang IFSO driver action.

phosek added a comment. Aside from comments that @jakehehrlich already made which I agree with, I'm also concerned about the use of `yaml2obj`. AFAIK that tool has always been intended as a testing, not a production tool, but with this change this would no longer be the case. Specifically, it f

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek updated this revision to Diff 196791. phosek marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61040/new/ https://reviews.llvm.org/D61040 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonA

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1474715 , @jdenny wrote: > Does the following match what you have in mind? > > $prefix/ > include/ > c++/ > v1/ > limits.h > ... > openmp/ > v1/ <-- I don't think o

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1480428 , @jdenny wrote: > It seems we have roughly the same situation for their ABIs. That is, for .so > files, someone noted that libc++ and libunwind have always used the same > version, .1, and openmp doesn't use a

[PATCH] D60990: [Driver] Support priority for multilibs

phosek added a comment. In D60990#1475116 , @lebedev.ri wrote: > Can this have test coverage? Done, I've added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196905. phosek marked an inline comment as done. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp

[PATCH] D60990: [Driver] Support priority for multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rC359359: [Driver] Support priority for multilibs (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60990?vs=196905&id=196933#toc Repository: rC Clang CHANGES SIN

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rC359360: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61040?vs=196791&id=196934#toc Repos

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek updated this revision to Diff 197241. phosek retitled this revision from "[runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/" to "[runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++". phosek edited the summary of this revision. phosek

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as done. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/) -

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek added a comment. In D59168#1484467 , @jdenny wrote: > In D59168#1480801 , @phosek wrote: > > > In D59168#1480428 , @jdenny wrote: > > > > > It seems we have roughly th

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL359603: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as not done. phosek added a subscriber: rsmith. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSI

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

phosek created this revision. phosek added a reviewer: juliehockett. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files may be affected by the choice of the rtlib, specifically wh

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

This revision was automatically updated to reflect the committed changes. Closed by commit rL359706: [Driver] Explicitly request platform rtlib in the Driver pic test (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek abandoned this revision. phosek added a comment. No longer needed, this was done as part of D60926 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60235/new/ https://reviews.llvm.org/D60235 _

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek created this revision. phosek added a reviewer: thakis. Herald added subscribers: llvm-commits, cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This reflects changes made in r359763. Repository: rCTE Clang Tools Extra https://revie

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek added a comment. In D61456#1488383 , @thakis wrote: > Thanks! This is incomplete: > > - Create clangd_lit_site_cfg_files.gni next to this build file, but path to > generated files there > - Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek updated this revision to Diff 197837. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61456/new/ https://reviews.llvm.org/D61456 Files: llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn llvm/utils/gn/secondary/clang-tools-extra/clangd/test/clangd_lit_site_cfg_files

[PATCH] D54784: Use --push/pop-state with XRay link deps

phosek abandoned this revision. phosek added a comment. Herald added a project: clang. Turned out this is not the right approach because not every linker supports `--push-state`/`--pop-state` but I'm hoping to instead rely on ELF autolinking once D60274 lands.

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

phosek created this revision. phosek added reviewers: hans, inglorion, rnk, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. When user specifies non-existent directory to -fcrash-diagnostics-dir, create it rather than failing with an error. Repository: rC Clang h

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL359954: [Driver] Create non-existent directory for -fcrash-diagnostics-dir (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed th

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files: clang/cmake/c

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rC360100: [Clang][NewPM] Don't bail out if the target machine is empty (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D58374?vs=188999&id=198367#toc Repository:

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

phosek created this revision. phosek added reviewers: leonardchan, fedor.sergeev, chandlerc, philip.pfaffe. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. While ASan and MSan passes were already ported to new PM, the kernel variants weren't setu

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

phosek added a comment. This change broke our build which is using Clang and the `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the compilation fails

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

This revision was automatically updated to reflect the committed changes. Closed by commit rC360313: [NewPM] Setup Passes for KASan and KMSan (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61664?vs=198580&id=198760#toc Repository: rC Clang CHANGES SI

[PATCH] D61709: [NewPM] Port HWASan

phosek added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:956 + + if (LangOpts.Sanitize.has(SanitizerKind::HWAddress)) { +bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::HWAddress); Can you also add `KernelHWAddress` (akin to

[PATCH] D52132: [CMake] Use cannonical triples for Fuchsia runtimes

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. This ensures that whether the user uses short or cannonical version of the triple, Clang will still find the runtimes under the cannonical triple name. Repository: rC Cl

[PATCH] D52159: [Lexer] Add xray_instrument feature

phosek updated this revision to Diff 165705. phosek edited the summary of this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D52159 Files: clang/include/clang/Basic/Features.def clang/test/Lexer/has_feature_xray_instrument.cpp Index: clan

[PATCH] D52160: [Driver] Support XRay on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, dberris. Herald added a reviewer: javed.absar. Herald added a subscriber: cfe-commits. This enables support for XRay in Fuchsia Clang driver. Repository: rC Clang https://reviews.llvm.org/D52160 Files: clang/lib/Driver/ToolCha

[PATCH] D52159: [Lexer] Add xray_instrument feature

This revision was automatically updated to reflect the committed changes. Closed by commit rC342358: [Lexer] Add xray_instrument feature (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D52159?vs=165705&id=165712#toc Repository: rC Clang https://reviews

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In https://reviews.llvm.org/D45639#1193112, @ldionne wrote: > @phosek I don't understand how you can expect code compiled with new headers > to link against an old dylib, unless you're setting the target platform, in > which case anything that would fail to link will ins

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you should probably a wait a day to see if sanitizer owners are fine with with this as well. Repository: rC Clang https://reviews.llvm.org/D52386 __

[PATCH] D52402: [CMake][Fuchsia] Use internal_linkage rather than always_inline for libc++

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. This is a workaround for PR39053 which was uncovered by https://reviews.llvm.org/D50652 when the default attribute has been changed from in

[PATCH] D52402: [CMake][Fuchsia] Use internal_linkage rather than always_inline for libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rC342833: [CMake] Use internal_linkage rather than always_inline for libc++ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D52402?vs=166630&id=166634#toc Repositor

[PATCH] D52397: [libc++] Remove Fuchsia-specific knowledge to pick the ABI version

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D52397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. We don't need to support legacy ABI and hence we can use the new one. Repository: rC Clang https://reviews.llvm.org/D52660 Files: cl

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

phosek updated this revision to Diff 168061. Herald added a subscriber: libcxx-commits. Repository: rCXX libc++ https://reviews.llvm.org/D52660 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D52660: [CMake][Fuchsia] Use unstable libc++ ABI for Fuchsia toolchain

phosek updated this revision to Diff 168064. Repository: rCXX libc++ https://reviews.llvm.org/D52660 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake === --- clang/cmake/caches/Fuch

[PATCH] D52660: [CMake][Fuchsia] Use unstable libc++ ABI for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL343652: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52660?vs=

[PATCH] D40814: [libcxx] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added subscribers: libcxx-commits, ldionne. This is no longer needed after D57670 landed. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40814/new/ https://reviews.

[PATCH] D40815: [libcxxabi] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added subscribers: libcxx-commits, ldionne. This is no longer needed after D57670 landed. Repository: rCXXA libc++abi CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40815/new/ https://revi

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek abandoned this revision. phosek added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is no longer needed after D57670 landed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40816/new/

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353268: [CMake] Unify scripts for generating VCS headers (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek added a comment. In D56305#1363417 , @carwil wrote: > Hi, we're currently working on similar functionality for the ARM backend, so > I got pointed to take a look at this patch. > Looks good to me, I quite like the tablegen improvements, but agree

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 185667. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Fil

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initialize

phosek created this revision. phosek added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We must only set the construction vtable visibility after we create the vtable initializer, otherwise the global value will be treated as declaration rather than de

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

phosek updated this revision to Diff 186142. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58010/new/ https://reviews.llvm.org/D58010 Files: clang/lib/CodeGen/CGVTables.cpp clang/test/CodeGen/construction-vtable-visibility.cpp Index: clang/t

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL353742: [CodeGen] Set construction vtable visibility after creating initializer (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://reviews.llvm.org/D58089 ___

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 186583. phosek marked 5 inline comments as done. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Files: clang/include/clang/Driver/Options.t

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); efriedma wrote: > trong wrote: > > trong wrote: > > > phosek wrote: > > > > trong wrot

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353957: [AArch64] Support reserving arbitrary general purpose registers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56305?vs=186583&id=186687#toc Repository:

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58204/new/ https://reviews.llvm.org/D58204 ___

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

phosek added a comment. We need to update https://github.com/llvm/llvm-zorg/blob/master/zorg/buildbot/builders/FuchsiaBuilder.py#L102 as well as our downstream bots, but other than that I'm fine with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58157/new/ https://reviews

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We plan on using experimental new pass manager for Fuchsia toolchain. Repository: rC Clang https://reviews.llvm.org/D58214 Files: clang/cmake/ca

[PATCH] D58268: [clang] Create install targets for non-shared libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58268/new/ https://reviews.llvm.org/D58268 ___

[PATCH] D58269: [clang] Add build and install targets for clang libraries

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58269/new/ https://reviews.llvm.org/D58269 ___

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

phosek created this revision. phosek added reviewers: jakehehrlich, juliehockett, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can be used to disable libc linking. This flag is supported by GCC since version 8.x as well as some Clang target toolchains. Re

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

phosek updated this revision to Diff 187149. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58325/new/ https://reviews.llvm.org/D58325 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.c clang

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL354208: [Driver][Fuchsia] Support -nolibc flag (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D58326: [Driver][Gnu] Support -nolibc flag

phosek created this revision. phosek added reviewers: echristo, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can be used to disable libc linking. This flag is supported by GCC since version 9 as well as some Clang target toolchains. Repository: rC Clang

[PATCH] D58326: [Driver][Gnu] Support -nolibc flag

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354210: [Driver][Gnu] Support -nolibc flag (authored by phosek, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek created this revision. phosek added a reviewer: chandlerc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches the behavior of the old pass manager. There are some targets that don't have target machine at all (e.g. le32, spir) which whose tests would never r

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek created this revision. phosek added a reviewer: chandlerc. Herald added subscribers: cfe-commits, jdoerfert, kbarton, eraman, javed.absar, mgorny, nemanjai. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Not every pass has been ported to new PM which is breaking

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek updated this revision to Diff 187493. Herald added a subscriber: mstorsjo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 Files: clang/test/CMakeLists.txt clang/test/CodeGen/aarch64-neon-across.c clang/test/Co

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. In D58375#1403144 , @efriedma wrote: > I can understand why tests that use -O1 or -O2 would produce different > results with the new pass manager, but it looks like not all the tests are > like that. Do you know why those tests a

[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

phosek created this revision. phosek added a reviewer: peter.smith. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls. Herald added a project: clang. This test wasn't running due to a missing : after the RUN statement. Enabling this test revealed that it's actually broken. Reposito

[PATCH] D58429: [CodeGen] Enable the complex-math test for arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL354481: [CodeGen] Enable the complex-math test for arm (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58480/new/ https://reviews.llvm.org/D58480 ___

[PATCH] D58284: [clang] Switch to LLVM_ENABLE_IDE

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https://reviews.llvm.org/D58284 ___

[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1400223 , @smeenai wrote: > I'm not entirely happy with the name clang-dev-headers, and am open to > suggestions. It's unfortunate clang-headers was already taken for something > different, but renaming that target or in

[PATCH] D58317: [clang] Add install targets for development headers

phosek added a comment. In D58317#1404966 , @smeenai wrote: > In D58317#1404961 , @phosek wrote: > > > In D58317#1400223 , @smeenai wrote: > > > > > I'm not entirely happy wi

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D37723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

This revision was automatically updated to reflect the committed changes. Closed by commit rL312989: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D37723?vs=114737&id=114746#toc Repository: rL LLVM ht

[PATCH] D37785: [Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for Fuchsia builds

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D37785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D37785: [Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for Fuchsia builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL313173: [Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for Fuchsia builds (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D37785?vs=114956&id=115094#toc Repository: rL LLVM https

[PATCH] D37872: [libc++abi] Fix ASAN build with older compiler-rt versions.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D37871: [ASAN] Add macro denoting availability of new `__asan_handle_no_return()` function.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

<    1   2   3   4   5   6   7   8   9   10   >