[PATCH] D136894: Add clang-doc readme

paulkirth added a comment. In D136894#3905638 , @brettw wrote: > I definitely wasn't intending to write "formal documentation" for clang-doc. > I was trying to write some notes for a future contributor as I'm winding down > my work here, and it seems no

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. Thanks for the feedback! I have a few questions I'm hoping you can answer. In D135488#3928559 , @arsenm wrote: > I don't think we should be pointing users to -mllvm flags. Plus, I don't > really think random dbgs() printing is

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. In D135488#3928831 , @dblaikie wrote: > Any chance we could squirrel the info away (I assume there's a reason we > can't compute the info where the warn-stack-size LLVM feature is implemented > in PrologEpilogInserter.cpp) som

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 475602. paulkirth added a comment. Rebase and address comments - Replace magic comparison with `MFI.isDeadIbjectIndex()` - Small code improvement by using a constructor w/ `emplace_back` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. In D135488#3928975 , @dblaikie wrote: > Fair enough - could the warn-stack-size warning be moved to there, then, and > then the information included in the warning? It could have both a warning > and remark form, so folks coul

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. As a quick test, I hacked the printer pass to generate an output string, and passed that into the remarks emitter. From opt or llc things look as expected. There's some additional output, but its limited. I see a more serious issue when using it from Clang, as the out

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. Can you document the new directory structure with a small example? It would also be good to document in the code that some of these changes were driven by file corruption, and if possible point to a bug on github. Comment at: clang-tools-extra/clang

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142564 Files: clang-tools-extra/clang-do

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142577 Files: clang-tools-extra/clang-do

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492246. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp cla

[PATCH] D131137: [clang][misexpect] Add support to clang for profitable annotation diagnostics

paulkirth updated this revision to Diff 492269. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131137/new/ https://reviews.llvm.org/D131137 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clan

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth updated this revision to Diff 492274. paulkirth added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564 Files: clang-tools-extra/clang-doc/Representation.cpp Index: cla

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

This revision was automatically updated to reflect the committed changes. Closed by commit rG881d151c527c: [clang-doc] Removed unused method in the Info class (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142577/new/ https:/

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#4081864 , @jdoerfert wrote: > Drive by: There should be a lang ref component to this. Thanks for pointing out that we need to update the langref. Offhand, do you recall if there are places other than `BranchWeightM

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492492. paulkirth added a comment. Rebase and update lang ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-bran

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492493. paulkirth edited the summary of this revision. paulkirth added a comment. Update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

This revision was automatically updated to reflect the committed changes. Closed by commit rG9470de65bb33: [clang-doc] Reduce duplicate code with template (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://rev

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488314. paulkirth added a comment. Address comments. - document what ValOffset is used for - remove dead code - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D13

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488338. paulkirth added a comment. - Actually remove dead code - Update pass description to be more accurate - fix typo - update enum member name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ http

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488427. paulkirth added a comment. Update clang test for windows file separators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488722. paulkirth added a comment. Add target triple to all RUN lines. Seems like the layout is the same on 64-bit windows, but for some reason clang.exe chooses i386 unless the triple is set. So just set the triple uniformly, and avoid any potential proble

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488727. paulkirth added a comment. Make YAML tests less brittle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-remark.c

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488784. paulkirth marked 21 inline comments as done. paulkirth added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:44 + +const char *PassName = "stack-frame-layout"; + nickdesaulniers wrote: > Consider replacing uses of `PassName` with `DEBUG_TYPE` since they have the > same value.

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. In D135488#4048380 , @nickdesaulniers wrote: > It would be really nice if we could limit this to a specific function somehow. I think you can do that, right ? see: https://llvm.org/docs/Remarks.html#cmdoption-pass-remarks-fil

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:8 +// RUN: mkdir -p %t +// RUN: %clang_cc1 %s -emit-codegen-only -triple x86_64-unknown-linux-gnu -target-cpu corei7 -Rpass-analysis=stack-frame-layout -o /dev/null -O0 2>&1 | FileCheck %s

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added inline comments. Comment at: llvm/test/CodeGen/AArch64/O0-pipeline.ll:76-77 ; CHECK-NEXT: Insert CFI remember/restore state instructions +; CHECK-NEXT: Lazy Machine Block Frequency Analysis +; CHECK-NEXT: Machine Optimization Remark Emitter +; C

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. In D135488#4048869 , @thegameg wrote: > In D135488#4048854 , @paulkirth > wrote: > >> In D135488#4048380 , >> @nickdesaulniers wrote: >> >>> I

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. Actually if we add if (!isFunctionInPrintList(MF.getName())) return false; we can filter by name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 _

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488815. paulkirth added a comment. Address comments - Take a stab a ReleaseNotes - Update -Wframe-larger-than documentation to reference this pass - Enable filtering output from this pass by function name Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488834. paulkirth added a comment. Fix documentation string, since it was invalid formatting for the rst file. Also since code blocks don't render correctly in the html, write the documentation so that its usable without the code examples Repository: r

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 488842. paulkirth marked 5 inline comments as done. paulkirth retitled this revision from "[codegen] Add a remarks based Stack Layout Analysis pass" to "[codegen] Add StackFrameLayoutAnalysisPass". paulkirth edited the summary of this revision. paulkirth add

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. In D135488#4049075 , @thegameg wrote: > I would rather have a more generic mechanism for remarks or diagnostics in > general. Even if it uses `isFunctionInPrintList`, I'd rather have a real flag > that doesn't require `-mllvm`

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489036. paulkirth added a comment. Fix test for Windows. I had missed one of the file paths in YAML. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. @nickdesaulniers @thegameg Are we happy w/ the ReleaseNotes and the documentation changes? If so, I'll land this, but I wasn't sure either of you saw those changes ... or if using `isFunctionInPrintList` for now is a good choice until we can implement filtering for re

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a652c540556: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#4052782 , @tejohnson wrote: > In D131306#4037037 , @paulkirth > wrote: > >> @tejohnson @xur I kind of dropped the ball on these patches, but what are >> your thoughts on thi

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 489147. paulkirth added a comment. Use more flexible whitespace matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth marked 3 inline comments as done. paulkirth added a comment. @chapuni Thanks for the suggestion. It didn't occur to me that it could break the lines like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llv

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 489176. paulkirth added a comment. Rebase. - fix test cases - improve code swaping branch weights in instruction.cpp - clean up some dead metadata types left over from an old version of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 490323. paulkirth added a comment. Herald added a subscriber: luke. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst cl

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG557a5bc336ff: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. This broke a reverse iteration bot: https://lab.llvm.org/buildbot#builders/54/builds/3337 Forward fix in: https://reviews.llvm.org/D142127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth added a comment. so do we want to land this? or are there some outstanding issues I'm unaware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

paulkirth added a comment. Hi, we're seeing a test failure in our CI after this stack. Not exactly sure which commit though. You can find the failing bot here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8772753421607483249/overview Some test output fro

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539346. paulkirth added a comment. Rebase and try to accomodate Unified LTO changes. Based on the Unified LTO patches, I think this is the correct handling for FatLTO, but I'd like to get a second opinion before landing this. CC: @ormris Repository: rG

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539584. paulkirth added a comment. Use `--` for LLD options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540192. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Update summary w/ instructions for using `-ffat-lto-objects` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4499608 , @MaskRay wrote: > Thanks for the update. Can you add a comment for the `-funified-lto` > combination? It's unclear what it does... ugh, I had put comments above each compiler invocation, but forgot that

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4733 + types::ID Output; + if (Args.hasArg(options::OPT_S)) +Output = types::TY_LTO_IR; MaskRay wrote: > This part is not tested. oh, feel free to disregard my Q about `-S

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540559. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Revise tests + update summary - Add driver tests for -S - Add codegen tests for -S - Test Unified LTO codegen - Use -fdriver-only t

[PATCH] D146777: [clang] Preliminary fat-lto-object support

This revision was automatically updated to reflect the committed changes. Closed by commit rG610fc5cbcc8b: [clang] Preliminary fat-lto-object support (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `see patch` tag conflicted w/ one later in the document. Changing the text should fix the documentation build error.

[PATCH] D155490: [clang][docs] Fix tag target name in link

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5784c47806cf: [clang][docs] Fix tag target name in link (authored

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. Small forward fix for the documentation in D155490 . If something else crops up I can revert both and reland. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.l

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth added a comment. yeah, I did `arc diff` w/o thinking about it, and then realized I should have just pushed immediately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155490/new/ https://reviews.llvm.org/D155490 __

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth added a comment. In D155490#4507061 , @MaskRay wrote: > I find that `See patch` is used elsewhere. Does this change fix a sphinx bot? yes: https://lab.llvm.org/buildbot#builders/92/builds/47401 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158668: Add getLikelyBranchWeight helper function

paulkirth added a comment. My initial reaction to this was that we should keep the `--unlikely-branch-weights` flag available, even if we decide to move forward with the other changes. but given that you haven't had to update many tests, I think its probably fine to go this way. Probably just a

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

paulkirth added a comment. In D158668#4611842 , @MatzeB wrote: >> My initial reaction to this was that we should keep the >> --unlikely-branch-weights flag available > > I don't feel strongly about it and can put it back. But can you give some > reasoni

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is mostly LGTM, modulo the small change to the test that I've suggested. Assuming the presubmit tests still pass with that small edit, you're good on my end. Com

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. @thakis thanks for the report. I've reverted for now. @brettw can you take a look? I'm a bit surprised that passed on the Linux and windows bot, but failed on Mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth reopened this revision. paulkirth added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-doc/single-file-public.cpp:9 +// for a name with a 40-char USR name. +// RUN: find %t -regex ".*[0-9A-Z][0-9A-Z][0-9A-Z]

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. Sorry, it took me a while to circle back to this. In D135488#3931603 , @dblaikie wrote: > I'm not sure we'd need/want to optimize a diagnostic experience for a > codebase that's got a lot of latent warnings. If people have lot

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth created this revision. paulkirth added reviewers: asb, phosek, hiraditya, jrtc27, mcgrathr. Herald added subscribers: jobnoorman, luke, Enna1, VincentWu, abrachet, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruce

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506762. paulkirth added a comment. Fix comment and add `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp compile

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > Can you add a FIXME her

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > paulkirth wrote: > > cr

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506790. paulkirth added a comment. Remove outdated diagnostics and add tests for SCS + save/restore. I'm not 100% on if this is the right approach for save/restore testing, so I'm hapy to back this bit out or add more cases. Repository: rG LLVM Github

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:184 + +; RUN: llc -mtriple=riscv32 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV32I +; RUN: llc -mtriple=riscv64 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV64I --

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507048. paulkirth added a comment. Split out save/restore tests for SCS into its own file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507801. paulkirth added a comment. Address comments. - Remove `.` from warning message - use `;;` prefix in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Fi

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth added a comment. ugh. I accidentally commited some temporary work here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 ___ cfe-commits mailing list c

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507805. paulkirth added a comment. Remove unrelated changes, due to bad commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerA

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507811. paulkirth added a comment. Restore check lines in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp compil

[PATCH] D146777: [clang] Preliminary fat-lot-object support

paulkirth created this revision. paulkirth added reviewers: phosek, tejohnson, MaskRay, alexander-shaposhnikov. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. I've split this into smaller patch sets by project: LLVM: https://reviews.llvm.org/D146776 Clang: https://reviews.llvm.org/D146777 LLD: https://reviews.llvm.org/D146778 If we're happy with that, then we can probably abandon this revision in favor of those. Repositor

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 508773. paulkirth retitled this revision from "[clang] Preliminary fat-lot-object support" to "[clang] Preliminary fat-lto-object support". paulkirth added a comment. Herald added a subscriber: inglorion. Fix typo in title Repository: rG LLVM Github Mon

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 501341. paulkirth added a comment. Allow EmbedBitcodePass to emit sections for Thin + Full LTO - Improve options handling when FatLTO is enabled, so LTO related flags are not dropped in CC1 - Misc code cleanups. I still view this as very much a WIP, but t

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added inline comments. Comment at: llvm/include/llvm/IR/MDBuilder.h:61 /// Return metadata containing two branch weights. + MDNode *createBranchWeights(uint32_t TrueWeight, uint32_t FalseWeight, tejohnson wrote: > Update comment to mention new par

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 502873. paulkirth marked 4 inline comments as done. paulkirth added a comment. Rebase and address comments. - update doc comments and describe `IsExpected` parameter - add assert when scaling branch weights on calls - remove redundant check, now done in `ge

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 502875. paulkirth added a comment. Remove redunant assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-branch-w

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 503568. paulkirth added a comment. Herald added a reviewer: alexander-shaposhnikov. Minor update to tests. - drop yaml2obj in favor of using llc + objcopy - remove c files Note one tests now fails, though. For some reason w/ FatLTO the linker rewrites `x

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

paulkirth accepted this revision. paulkirth added a comment. Herald added a subscriber: wangpc. Also LGTM for the changes in MisExpect.rst, modulo feedback from @erichkeane. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151963/new/ https://reviews.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 533433. paulkirth marked 12 inline comments as done. paulkirth added a comment. Rebase and address comments - Update & rename tests - Fix typos - Handle options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/include/clang/Driver/Options.td:2311 MarshallingInfoString>; +defm fat_lto_objects : BoolFOption<"fat-lto-objects", + CodeGenOpts<"FatLTO">, DefaultFalse, MaskRay wrote: > We just need the pos flag for CC1Opt

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 535472. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4457209 , @MaskRay wrote: > As mentioned, you may consider landing llvm patch then wait a bit so that (a) > people can experiment with the clang patch better (b) prevent the llvm/clang > patches to be both reverted,

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509508. paulkirth retitled this revision from "[CodeGen][RISCV] Change Shadow Call Stack Register to S11" to "[CodeGen][RISCV] Change Shadow Call Stack Register to X3". paulkirth edited the summary of this revision. paulkirth added a comment. update to use

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509811. paulkirth added a comment. Remove blank lines added to test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cp

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us here? From the discussions in psABI and sig-toolchain, I think we have a consensus that this is the approach we'll be taking for RISC-V. We'd prefer to correct this ASAP, so as to prevent futu

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. whe Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & SanitizerKind::ShadowCallStack) && - ((TC.getTriple().isAArch64() && -!llvm::AArch64::isX18ReservedByDefault(TC.getTriple())) || - (TC.getTriple().isRISCV() &&

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511458. paulkirth added a comment. Fix formatting and update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511466. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/doc

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511575. paulkirth marked an inline comment as done. paulkirth added a comment. Add default small-data-limit for Android and Fuchsia. - update tests - update clang driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511704. paulkirth marked an inline comment as done. paulkirth added a comment. Remove unrelated whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth created this revision. paulkirth added reviewers: phosek, MaskRay, enh, hiraditya, vit9696. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, asb, arichardson, inglorion. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers:

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512189. paulkirth marked an inline comment as done. paulkirth added a comment. Fix formatting in CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files:

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth added inline comments. Comment at: clang/test/Driver/emulated-tls.cpp:57 +// LTO related checks +//LTO_NOEMUTLS: plugin-opt=-emulated-tls=0 +//LTO_NOEMUTLS-NOT: plugin-opt=-emulated-tls=1 vit9696 wrote: > Maybe add a space before LTO here? Good catch. F

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512190. paulkirth added a comment. Remove extra newlines in emulated-tls.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files: clang/lib/Driver/ToolChains/Co

<    1   2   3   4   >