paulkirth added a comment. In D131306#4081864 <https://reviews.llvm.org/D131306#4081864>, @jdoerfert wrote:
> Drive by: There should be a lang ref component to this. Thanks for pointing out that we need to update the langref. Offhand, do you recall if there are places other than `BranchWeightMetadata.rst` that would need to be updated? > Also, changing branch weight metadata might impact downstream users, an RFC > seems in order (assuming I didn't miss one). You didn't miss one. I was under the impression that the layout of `MD_prof` was an internal detail that wouldn't require one. I think that is doubly true since the new field is optional, and existing bitcode/IR can still be consumed. But you raise a fair point that it would impact anyone trying to process new IR, so maybe one is in order to be a good citizen. I'll try to set aside some time to draft a short RFC for discourse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
