paulkirth added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:184
+
+; RUN: llc -mtriple=riscv32 -mattr=+reserve-x27 < %s | FileCheck %s 
-check-prefix=RV32I
+; RUN: llc -mtriple=riscv64 -mattr=+reserve-x27 < %s | FileCheck %s 
-check-prefix=RV64I
----------------
craig.topper wrote:
> Can we split this to a separate file? It doesn't look like it was generated 
> by update_llc_test_checks.py and we don't want these checks on the test cases 
> above.
Good point. This was taken directly from what looked to be the only relevant 
case in `saverestore.ll`. Tomorrow I will split this off into a standalone 
file. Do you know if there would be other relevant cases to consider from the 
save/restore tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146463/new/

https://reviews.llvm.org/D146463

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to