[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik accepted this revision as: philnik. philnik added a comment. Mostly LGTM. Just a few nits. Comment at: clang/www/hacking.html:276 + + Testing changes affecting libcxx + To make it consistent throughout Comment at: clang/www/hacki

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. + -

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added 1 blocking reviewer(s): aaron.ballman. philnik added a comment. LGTM from the libc++ side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 _

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 441353. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D128844: Improve the formatting of static_assert messages

philnik requested changes to this revision. philnik added a comment. This revision now requires changes to proceed. Sorry I missed that. You have to changes the libc++ tests to regex checks to allow both error-styles. This can then be removed once we drop support for LLVM 14 (so after the releas

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ee9a50a146c: [libc++] Implement P0618R0 (Deprecating ) (authored by philnik). Changed prior to commit: https://reviews.llvm.org/D127313?vs=441353&id=441398#toc Repository: rG LLVM Github Mo

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM. (The clang-format if more of a suggestion than anything else currently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https:

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik created this revision. philnik added reviewers: aaron.ballman, rsmith, RKSimon. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ wants to switch from `__compressed_pair` to using `no_unique

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. In D122874#3422263 , @aaron.ballman wrote: > I'm not opposed, but this does muddy the waters about the target-specific > nature of the attribute. Currently, the semantic attribute cannot be used > outside of Itanium ABI targets

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rG3ba8548c8e04: [libc++][ranges] Implement ranges::transform (authored by philnik). Herald added a project: c

[PATCH] D122173: [libc++][ranges] Implement ranges::transform

philnik marked an inline comment as done. philnik added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/ranges_transform.module.verify.cpp:1-15 +//===--===// +// +// Part of the LLVM Project, und

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a subscriber: ldionne. philnik added a comment. > And if `[[msvc::no_unique_address]]` and `[[no_unique_address]]` (when > eventually implemented) in MSVC have a different ABI impact, will we will > leave `__attribute__((no_unique_address))` alone so it won't break ABI? I think th

[PATCH] D130822: Fixed loads of typos

philnik added a comment. Could you split this up per project? Large patches like this are really hard to review, since there is no single person/small group that can approve everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130822/new/ htt

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik planned changes to this revision. philnik added a comment. This is useless until we have some `no_unique_address` in clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 _

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all tak

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. > Hmmm, I'd be more comfortable if this wasn't an ABI break for people using > the `__attribute__(())` spelling. If we wanted to surprise users with ABI > breaks, we'd just implement `[[no_unique_address]]` on Windows and break > users when Microsoft eventually supports

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3225908 , @erichkeane wrote: > In D114425#3225892 , @craig.topper > wrote: > >> I kind of wonder if we should detect the __int128 type being requested in >> ASTContext::GetBu

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 409607. philnik added a comment. - Rebased - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 409629. philnik marked an inline comment as done. philnik added a comment. Herald added a subscriber: mstorsjo. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D11

[PATCH] D129048: Rewording the "static_assert" to static assertion

philnik added a comment. In D129048#3668542 , @erichkeane wrote: > Tests ran clean for me as well. Looking at the CI, it appears that the > libcxx tests are improperly configured, and are being run against an 'older' > version of the compiler (not inc

[PATCH] D129048: Rewording the "static_assert" to static assertion

philnik added a comment. Also, please wait for #libc approval next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 _

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik created this revision. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC has a `__builtin_bswap128` which is used for `std::byteswap()`. Clang should also add this builtin. Repository: rG LLVM Github Monorepo https:/

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

philnik added a comment. Would it be possible to just add `#if TEST_CLANG_VER >= 1600` around the new warnings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 ___

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || ChuanqiXu wrote: > aaron

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D134654: [clang] Detect header loops

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > urnathan wrote:

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

philnik added a comment. TBH I don't think adding these builtins is worth the extra maintenance cost. libc++'s implementation is already really simple, and actually //uses// `__is_constructible`, contrary to the statement in the summary. This is the whole implementation currently: template

[PATCH] D131963: [libc++] Add custom clang-tidy checks

philnik added a comment. In D131963#3831786 , @smeenai wrote: > In D131963#3811811 , @ldionne wrote: > >> I'd be fine with this as-is if it works in the CI. >> >> IIUC, the current blocker for this is that the `Cl

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4047428 , @aaron.ballman wrote: > Thank you for working on this! I think the Debian CI failure is unrelated, > but the libc++ one looks plausibly related: > > > /home/libcxx-builder/.buildkite-agent/builds/e6f11fd2

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4050492 , @ChuanqiXu wrote: > @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: > error: unknown target 'libcxx-generate-files'`. The following off is my > configuring command: > > cmake -G

[PATCH] D133574: [C2x] reject type definitions in offsetof

philnik added a comment. In D133574#4051899 , @aaron.ballman wrote: > In D133574#4051782 , @bkramer wrote: > >> GitHub finds around 1.9k instances of this pattern to compute `alignof`. >> There's a lot of duplic

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes. Comment at: libcxx/utils/generate_header_tests.py:22 +

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060212 , @erichkeane wrote: > @ldionne @Mordante The libcxx failure isn't clear what it is complaining > about, but I thought this fix might end up breaking a libcxx test, since it > would be easy to fall into the

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4060246 , @erichkeane wrote: > In D141954#4060244 , @philnik wrote: > >> In D141954#4060212 , @erichkeane >> wrote: >> >>> @ldionne @

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

philnik added a comment. In D141954#4061962 , @erichkeane wrote: > Speaking of: I guess the libcxx failure is NOT caused by me? > https://reviews.llvm.org/D141992 > > I see this on a different review, despite this not being committed. That's not great

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 436032. philnik marked 3 inline comments as done. philnik added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/Rel

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 436126. philnik added a comment. Rebased to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Pap

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

philnik added a comment. Could you do this on a per-project basis? More than 1000 files is way to much to sift through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 437951. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438407. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438486. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438576. philnik added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Papers.csv

[PATCH] D36423: [libc++] Introsort based sorting function

philnik commandeered this revision. philnik added a reviewer: DIVYA. philnik added a comment. Herald added a subscriber: mgrang. Herald added a project: All. This has been superseded by D113413 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36423/new/

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 435230. philnik added a comment. Fix Patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Papers.csv

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik abandoned this revision. philnik added a comment. I don't plan to work on this any time soon, so I'll abandon it to clean up the review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4508209 , @MaskRay wrote: > Reverse ping @philnik :) > > The `release/17.x` branch will be created soon > (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). I know. I just didn't have the ti

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 542743. philnik added a comment. - Address comments - Try to fix CI - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/LanguageExtensions.r

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG874217f99b99: [clang] Enable C++11-style attributes in all language modes (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D154893: [Clang] Fix some triviality computations

philnik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { royjacobson

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

philnik added a comment. In D152003#4531732 , @aaron.ballman wrote: > In D152003#4531404 , @Fznamznon > wrote: > >>> should we try to land that today? >> >> I'm not sure. It causes failures in libc++ testing: >>

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

philnik added a comment. In D156247#4538626 , @aaron.ballman wrote: > I would like explicit buy-in from the libc++ folks on the idea of adding > `-fno-coroutines` as they're going to be impacted by Clang supporting such an > option (and they may have a

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a C++1

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

philnik added a comment. I think these changes would allow us to drop the `stddef.h` compat header from libc++, which would be really nice. Comment at: clang/lib/Headers/stddef.h:36-40 +#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L) || \ +(def

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

philnik added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Mordante wrote: > hazohelet wrote: > > Mordante wrote: > > > Why is this needed? Does this mean the builtin will fail in C++03 mode? > >

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4604482 , @aaron.ballman wrote: >> This allows standard libraries to mark symbols as extensions, so the >> compiler can generate extension warnings when they are used. > > Huh, so this is basically the opposite of the

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

philnik added a comment. @aaron.ballman I think what @danlark means is that when building clang against a libc++ which has debug assertions enabled, the clang tests he mentioned result in an assertion firing within libc++. i.e. the libc++ debug mode catches the non-strict weak ordering that it

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. Thanks for working on this! I think it would make a lot of sense to unify this build and the Debian build, since currently we are building Clang twice without a good reason. Repository:

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: arphaman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows standard libraries to m

[PATCH] D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate

philnik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:10932 +DiagnoseCTADCopy(); + } else if (!PP.getSourceManager().isInSystemHeader(Template->getLocation())) { +DiagnoseCTADCopy(); cor3ntin wrote: > So the idea here is that the standa

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik abandoned this revision. philnik added a comment. Abandoning, since it seems like we want to extend `diagnose_if` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572 _

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536620. philnik marked 16 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langu

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536623. philnik edited the summary of this revision. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langua

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

philnik added a comment. Would it be possible to make `__` also a placeholder, so standard libraries can use this before C++26? Or is `_` already a reserved identifier? (I don't think so) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538208. philnik marked 2 inline comments as done. philnik added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik added subscribers: cor3ntin, erichkeane, aaron.ballman. philnik added a comment. @aaron.ballman @erichkeane @cor3ntin (anybody else?) are you fine with moving the clang build kite-pipeline to `clang/utils/ci` and adding a `run-buildbot`? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538290. philnik marked 7 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files: clang/utils/ci/bu

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik abandoned this revision. philnik added a comment. I'm dropping this in favour of D151683 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 ___

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

philnik created this revision. philnik added reviewers: aaron.ballman, cor3ntin, erichkeane. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63656 Repository: rG LLVM Github Monorepo https://

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rGc6b4433a0f20: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays… (authored by

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 538798. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-bui

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 539183. philnik added a comment. Herald added a reviewer: NoQ. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files: clang/lib/Analysis/FlowSensitive

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. I like this a lot! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 _

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

philnik added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a ma

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

philnik added inline comments. Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/ranges.copy.segmented.pass.cpp:96 int main(int, char**) { - if (!std::is_constant_evaluated()) { -test_containers, std::deque>(); cor3ntin wrote: > this

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >> Thi

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In D157

[PATCH] D129951: adds `__disable_adl` attribute

philnik added a comment. I don't think libc++ can adopt this without having to essentially duplicate our code, since GCC doesn't support `__disable_adl` (and AFAICT there is no coordination between GCC and Clang to add it to both). Have you tested what impact making the members `static` has? Bo

[PATCH] D129951: adds `__disable_adl` attribute

philnik added a comment. In D129951#4178844 , @cjdb wrote: > In D129951#4178154 , @philnik wrote: > >> I don't think libc++ can adopt this without having to essentially duplicate >> our code, since GCC doesn't su

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. @aaron.ballman Do you have any opinion here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D153737: [clang] __is_trivially_equality_comparable should return false for arrays

philnik created this revision. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When comparing two arrays, their pointers are compared instead of their elements, which menas that they are not trivially e

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6d557ee34b6: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs (authored by philnik). Changed prior to commit: htt

[PATCH] D153737: [clang] __is_trivially_equality_comparable should return false for arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4de66e8c4434: [clang] __is_trivially_equality_comparable should return false for arrays (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

philnik created this revision. philnik added reviewers: aaron.ballman, cor3ntin. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63192 Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf8b982042e: [clang] Fix checking the equality comparator of base classes in… (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new trait to allow standard libraries to forward `std::equal` ca

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 509598. philnik added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4240572 , @aaron.ballman wrote: > Hmmm, is this effectively `std::has_unique_object_representations` (ensuring > that all bits of the object representation contribute to the value)? These two traits are indeed very s

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 510865. philnik marked 5 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 510887. philnik added a comment. Remove formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/LanguageExtensions.rst clang/include/

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511460. philnik marked 4 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4246513 , @aaron.ballman wrote: > Ah, I like this approach -- it keeps things roughly in sync with checking for > unique object representations, which is great. I spotted a few questions, but > in general this is hea

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511762. philnik marked 2 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4251076 , @aaron.ballman wrote: > One thing I can't quite determine is whether we expect to call this type > trait often or not. Are either of the uses in libc++ going to be instantiated > frequently? I'm trying to f

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik marked an inline comment as done. philnik added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant This does

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

philnik added a comment. Is this essentially "is_trivial_for_the_purposes_of_abi"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141775/new/ https://reviews.llvm.org/D141775 ___ cfe-commits mailing list

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 512201. philnik marked 3 inline comments as done. philnik added a comment. - Moved libc++ changes into it's own PR - Rebased - Fixed `enum` false-positive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new

  1   2   >