philnik created this revision.
philnik added reviewers: aaron.ballman, rsmith, RKSimon.
Herald added a project: All.
philnik requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

libc++ wants to switch from `__compressed_pair` to using `no_unique_address`. 
That is currently not possible, because there is no way to get the behaviour of 
`no_unique_address` in C++03. Adding the `__attribute__` spelling allows libc++ 
to switch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122874

Files:
  clang/include/clang/Basic/Attr.td


Index: clang/include/clang/Basic/Attr.td
===================================================================
--- clang/include/clang/Basic/Attr.td
+++ clang/include/clang/Basic/Attr.td
@@ -1701,7 +1701,7 @@
 }
 
 def NoUniqueAddress : InheritableAttr, TargetSpecificAttr<TargetItaniumCXXABI> 
{
-  let Spellings = [CXX11<"", "no_unique_address", 201803>];
+  let Spellings = [GNU<"no_unique_address">, CXX11<"", "no_unique_address", 
201803>];
   let Subjects = SubjectList<[NonBitField], ErrorDiag>;
   let Documentation = [NoUniqueAddressDocs];
   let SimpleHandler = 1;


Index: clang/include/clang/Basic/Attr.td
===================================================================
--- clang/include/clang/Basic/Attr.td
+++ clang/include/clang/Basic/Attr.td
@@ -1701,7 +1701,7 @@
 }
 
 def NoUniqueAddress : InheritableAttr, TargetSpecificAttr<TargetItaniumCXXABI> {
-  let Spellings = [CXX11<"", "no_unique_address", 201803>];
+  let Spellings = [GNU<"no_unique_address">, CXX11<"", "no_unique_address", 201803>];
   let Subjects = SubjectList<[NonBitField], ErrorDiag>;
   let Documentation = [NoUniqueAddressDocs];
   let SimpleHandler = 1;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to