[PATCH] D57258: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF

thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. libclang can be built in shared or static mode. On Windows, with LLVM_ENABLE_PIC=OFF, it was built in neither mode, leading to clients of libclang (c-index-test, c-arcmt-test) failing to link with it s

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

thakis added a comment. (fwiw using %T is discouraged nowadays, see https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions / https://reviews.llvm.org/D35396 ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/ https://reviews.llvm.org/D5056

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371562 , @george.karpenkov wrote: > > Can you elaborate a bit in what sense this decouples ARCMT from the > > analyzer? > > ARCMT now does not need to link against the analyzer > > > Can CLANG_ENABLE_STATIC_ANALYZER now

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

thakis added a comment. In D57127#1371563 , @george.karpenkov wrote: > > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > > used by tooling-like t

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis created this revision. thakis added a reviewer: zturner. Herald added a subscriber: delcypher. Herald added a reviewer: serge-sans-paille. `LLVMConfig.with_environment()` uses `os.path.normcase(os.path.normpath(x))` to normalize temporary env vars. `LLVMConfig.use_clang()` uses `with_envi

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis created this revision. thakis added a reviewer: arphaman. - fixes the test on macOS with LLVM_ENABLE_PIC=OFF - together with D57343 , gets the test to pass on Windows - makes it run everywhere (it seems to just pass on Linux) The main change is in CIndexer

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis added a comment. In D57343#1374063 , @zturner wrote: > Shouldn't the hash be case-insensitive on windows? I'm not sure: I think case-sensitive file systems on Windows are becoming more common with WSL. This seemed like the less intrusive change t

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. arphaman: ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

thakis added a comment. zturner: ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57343/new/ https://reviews.llvm.org/D57343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. erik.pilkington, can you take a look? Looks like arphaman isn't around. Since this touches libclang, I figure it might make sense if one of you takes a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. Could it be somewhere in lib/Driver? libclang depends on lib/Frontend which depends on lib/Driver -- is there any reason libclang can't depend on lib/Driver? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis updated this revision to Diff 184593. thakis edited the summary of this revision. thakis added a comment. shared function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driv

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

thakis added a comment. Nice! Comment at: cfe/trunk/docs/UsersManual.rst:2950 /Z7 Enable CodeView debug information in object files + /Zc:dllexportInlines- Don't dllexport/import inline member functions of dllexport/import classes + /Zc:d

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

thakis added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D54426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

thakis added a comment. (From a user point of view, I have no idea what "CTAD" means, and I sometimes work on a C++ compiler.) Repository: rC Clang https://reviews.llvm.org/D54565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

thakis created this revision. thakis added a reviewer: rnk. The flag -fdebug-compilation-dir is useful to make generated .o files independent of the path of the build directory, without making the compile command-line dependent on the path of the build directory, like -fdebug-prefix-map require

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

thakis added a comment. I don't have an opinion on this patch (if you force me to have one, I'm weakly in favor), but I agree with the general sentiment. When I told people to not use mllvm and Xclang before, they told me "but if I'm not supposed to use them, why are they advertised in --help"?

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

thakis added a comment. Oh hey, the patch does that already! Ignore me, then :-) That part is probably less controversial, maybe you want to land that while the warning part is being discussed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55150/new/ https://reviews.llvm.org/D55150

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

thakis added a comment. The usual process for adding / tweaking warnings is to build some large open-source project with the new / tweaked warning and note true and false positive rate. IIRC I did this on Chromium when I added the warning, and the out-of-bounds check prevented false positives w

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

thakis added a comment. Does our serialization machinery serialize these correctly automatically? What happens if you compiler a header saying `execution_character_set_push, "utf-8")` in a header, compile that to a pch, then include that through the pch in a .c file that does pop? My guess is

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

thakis accepted this revision. thakis added a comment. Ah ok, then I agree this doesn't need serialization yet :) It'd be nice to at least diag that the stack use is valid (also for the warning stack), but it doesn't have to be in this change. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D31739: Add markup for libc++ dylib availability

thakis added inline comments. Herald added subscribers: llvm-commits, jdoerfert, jfb, christof. Herald added a reviewer: serge-sans-paille. Herald added a project: LLVM. Comment at: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/lit.local.cfg:1 +if 'ava

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis created this revision. thakis added a reviewer: erik.pilkington. This adds support for static_assert() (and _Static_assert()) in @interface/@implementation ivar lists and in @interface method declarations. It was already supported in @implementation blocks outside of the ivar lists. The

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. (Since jfb added a few people who might not have seen it: This was discussed in "Objective-C++11: concerns about adding static_assert support to @interface / @implementation?" on cfe-dev) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3892-3893 /// +/// Note that a struct declaration refers to a declaration in a struct, +/// not to the declaration of a struct. +/// aaron.ballman wr

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > thakis wrote: > > aaron.ballman wrote: > > > Can you try explicitly specifying C++98 as

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190172. thakis marked an inline comment as done. thakis added a comment. test c++98 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDecl.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.mm:1 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s + aaron.ballman wrote: > erik.pilkington wrote: > > thakis wrote: > > >

[PATCH] D59118: creduce script for clang crashes

thakis added a comment. (A few python style comments; feel free to ignore, and feel free to land no matter what you do with the comments.) Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for c

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis abandoned this revision. thakis added a comment. We went with https://reviews.llvm.org/D36413 instead. (Upstream issue was https://crbug.com/751225) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36238/new/ https://reviews.llvm.org/D36238 __

[PATCH] D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name.

thakis added a comment. Note to self, this was for https://crbug.com/751225 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36413/new/ https://reviews.llvm.org/D36413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190418. thakis edited the summary of this revision. thakis added a comment. two features CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/Parse

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. Seems like this wasn't convincing, so now with two separate feature flags. I went with the shorter name, since adding "interface_" isn't just longer but also misleading, since this also works in @implementation ivar blocks now. CHANGES SINCE LAST ACTION https://review

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

thakis added a comment. Hi ahatanak, this causes a crash in chrome/ios. A reduced repro is at https://bugs.chromium.org/p/chromium/issues/detail?id=941680 . Is the code invalid, or is that a bug in the transform? Thanks, Nico Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190521. thakis added a comment. c89 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseObjc.cpp clang/lib/

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/include/clang/Basic/Features.def:121 FEATURE(objc_class_property, LangOpts.ObjC) +FEATURE(objc_c_static_assert, true) +FEATURE(objc_cxx_static_assert, LangOpts.CPlusPlus11)

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. Ah, got it, thanks for explaining! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190534. thakis edited the summary of this revision. thakis added a comment. extension CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/ParseDec

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; aaron.ballman wrote: > Given that static assertions are member declarations of a struct, should this > "repl

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

thakis added a comment. Herald added a subscriber: jdoerfert. ilya-biryukov, ping? :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 ___ cfe-commits mailing l

[PATCH] D59382: Rename directory housing clang-change-namespace to be eponymous

thakis created this revision. thakis added a reviewer: ioeric. Herald added a subscriber: mgorny. Makes the name of this directory consistent with the names of the other directories in clang-tools-extra. https://reviews.llvm.org/D59382 Files: clang-tools-extra/CMakeLists.txt clang-tools-ex

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. Why is this needed for index-while-building? My mental model for index-while-building is that that streams out build index metadata as part of the regular compile. Why does that require watching directories? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/ne

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. In D58418#1430490 , @jkorous wrote: > In D58418#1430160 , @thakis wrote: > > > Why is this needed for index-while-building? My mental model for > > index-while-building is that that streams

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. In D58418#1431399 , @jkorous wrote: > In D58418#1430630 , @thakis wrote: > > > In D58418#1430490 , @jkorous wrote: > > > > > In D58418#1430160

[PATCH] D59700: Make clang-move use same file naming convention as other tools

thakis created this revision. thakis added a reviewer: hokein. Herald added subscribers: llvm-commits, ioeric, mgorny. Herald added a project: LLVM. In all the other clang-foo tools, the main library file is called Foo.cpp and the file in the tool/ folder is called ClangFoo.cpp. Do this for clang-

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

thakis added inline comments. Comment at: docs/ReleaseNotes.rst:169 +- Add language support for clang-formatting C# files +- Add Microsoft coding style to encapsulate default C# formatting style Shouldn't this be in 'clang-format', not in 'AST Matchers'? Repo

[PATCH] D59750: Rename directory housing clang-include-fixer to be eponymous

thakis added a comment. I accidentally hit some keyboard shortcut and created the revision before I was done adding reviewer and subscriber lists. Fixed now; apologies for the confusing email this will send. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59750/new/ https://reviews.llvm

[PATCH] D16761: clang-cl: Support loading plugins on Windows

thakis added a comment. LLVM_EXPORT_REGISTRY no longer exists, so this can't be relanded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16761/new/ https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D59750: Rename directory housing clang-include-fixer to be eponymous

thakis added a comment. In D59750#1440981 , @bkramer wrote: > lg. Is the reference from libclang still around? Might need an update. I only found http://llvm-cs.pcc.me.uk/tools/clang/tools/libclang/CIndex.cpp#8955 which in http://llvm-cs.pcc.me.uk/tool

[PATCH] D16761: clang-cl: Support loading plugins on Windows

thakis added a comment. Clang's plugin model is currently fundamentally incompatible with how imports and exports work on Windows, which I'm guessing is probably why LLVM_EXPORT_REGISTRY was removed as well. There's no easy way to get plugins to work on Windows. CHANGES SINCE LAST ACTION ht

[PATCH] D54799: [clangd] textDocument/SymbolInfo method

thakis added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. SymbolInfoTests.All takes > 20% of all of check-clang-tools time. Can the test be made faster? Also, since it's using a large-ish non-pod initializer clang is currently slow to compile it, see http://ll

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

thakis created this revision. thakis added a reviewer: mbonadei. Herald added a project: LLVM. (Not adding a build file for clang-include-fixer/plugin yet.) https://reviews.llvm.org/D59838 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang-tools-extra/clang-include-fixer/

[PATCH] D59899: gn build: Add some build files for clangd

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, jfb, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, srhines. Herald added a project: LLVM. Enough to build the clangd binaries, but this is still missing build files for: -

[PATCH] D59899: gn build: Add some build files for clangd

thakis marked 2 inline comments as done. thakis added a comment. Thanks! Landing with comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59899/new/ https://reviews.llvm.org/D59899 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D59953: Rename clang-tools-extra lit cfg files to lit.site.cfg.py

thakis created this revision. thakis added a reviewer: zturner. Herald added a subscriber: mgorny. thakis added a comment. Actually, let me rename lit.cfg to lit.cfg.py too, one sec... Follow-up to r313892, which did this for clang and llvm. https://reviews.llvm.org/D59953 Files: clang-tool

[PATCH] D59953: Rename clang-tools-extra lit cfg files to lit.site.cfg.py

thakis added a comment. Actually, let me rename lit.cfg to lit.cfg.py too, one sec... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59953/new/ https://reviews.llvm.org/D59953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D59953: Add .py extension to clang-tools-extra lit cfg files

thakis updated this revision to Diff 192698. thakis retitled this revision from "Rename clang-tools-extra lit cfg files to lit.site.cfg.py" to "Add .py extension to clang-tools-extra lit cfg files". thakis added a comment. Ok, ptal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59953/ne

[PATCH] D59955: gn build: Add check-clang-tools to run clang-tools-extra lit tests

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: kadircet, arphaman, jkorous, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. Only runs the clang-tools-extra lit tests; not yet the unit tests. Add a build file for clangd-indexer too, since i

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

thakis added a comment. Can we delete clang-tidy-diff.py with this? (Or delete most of its contents and make it forward to this script?) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 ___

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

thakis added a comment. Looks like this landed without tests. Please add tests in a follow-up. Also, it looks like the flag is currently a cc1 flag. This should probably be a CoreOption instead so that both the gcc-style and the cl-style drivers expose it. Right now, users can't really use this

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

thakis added a comment. ps: Hooray for landing this, and thanks for the cool feature! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, ioeric, mgorny, srhines. Herald added a project: LLVM. https://reviews.llvm.org/D60038 Files: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt llvm/utils/gn

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 + +unittest("ClangApplyReplacementsTests") { + configs += [ "//llvm/utils/gn/build:clang_code" ] --

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis created this revision. thakis added reviewers: jkorous, arphaman. Herald added subscribers: kadircet, dexonsmith, ioeric, ilya-biryukov, mgorny. The CMake variable controlling if XPC code is built is called `CLANGD_BUILD_XPC` but three places unintentionally checked the non-existent varia

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. With this, check-clang-tools unit tests are complete, but the lit tests still don't run the one

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps = [ +"//clang-tools-extra/clangd", mbonadei wrote:

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis created this revision. thakis added reviewers: mbonadei, sdefresne. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. thakis edited the summary of this revision. This is a bit of a larger change since thi

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. (I noticed this while working on D60130 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis updated this revision to Diff 193313. thakis added a comment. Use {{source_file_part}} in bundle_data where possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130 Files: clang-tools-extra/clangd/xpc/framework/CMakeLists.txt clang-t

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

thakis created this revision. thakis added a reviewer: bkramer. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.) https://reviews.llvm.org/D60201

[PATCH] D60203: Updating Chromium's Java import order

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! (Test?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___ cf

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM. Requires making the llvm::MemoryBuffer* stored by SourceManager const, which in turn requires making the accessors for that return const llvm::MemoryBuffer*s

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Why would we want this to be different in Obj-C and C++? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D60203: Updating Chromium's Java import order

thakis added a comment. Ah, ok. Probably want to add tests at some point, but I'll land this as-is for now then. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___ cfe-commi

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Please don't land changes with open discussion. Objective-C++ basically is C++ code. I don't think it makes sense to make a distinction here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. erik.pilkington, could you stamp this maybe? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

thakis added a comment. See http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 for a "is same file" example. I'm not sure adding a bool to PresumedLoc is worth it for this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/

[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

thakis created this revision. thakis added reviewers: rnk, rsmith. This fixes one TODO and one FIXME in ConvertBackendLocation() about not copying llvm::MemoryBuffers when converting from from llvm::SMDiagnostics to clang::Diagnostics. The basic idea is to use `SourceManager::createFileID(clan

[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2355 + // XXX so comment is handled before pp directive is done, so no linetable + // entry yet when the handler runs. if (ParsingPreprocessorDirective || CurPtr == Buf

[PATCH] D60379: Make precompiled headers reproducible

thakis added a comment. In D60379#1458668 , @riccibruno wrote: > After looking at the bug report (https://bugs.debian.org/877359), I would > like to point out that there is currently *absolutely* no stability guarantee > for the serialization format (ie,

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. aprantl: Ping on Hans's question from Dec 18. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. In D54187#1460181 , @aprantl wrote: > Did anyone take the time to look at dexter and whether it would fit the bill > here? It would be great to avoid reimplementing its functionality just to > have something that then only works o

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. (Also, dexter has seen 7 commits over its lifetime, so I'm not sure that's something we'd want to depend on.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

thakis created this revision. thakis added a reviewer: akhuang. The run script runs in bash, so no need to depend on llvm's `not` binary. https://reviews.llvm.org/D60572 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py =

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

thakis abandoned this revision. thakis added a comment. This seems to break the script, nevermind! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60572/new/ https://reviews.llvm.org/D60572 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Seems like harmless plumbing. Given that the LLVM side of this is accepted, this lgtm. Comment at: test/Driver/fsanitize.c:837 +// RUN: %clang -target x86_64-linux-gnu -fsan

[PATCH] D59639: [clangd] Print template arguments helper

thakis added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt:16 Annotations.cpp + PrintASTTests.cpp BackgroundIndexTests.cpp Keep alphabetized? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D61029: clang-cl: List valid values for /std: in /? output

thakis created this revision. thakis added a reviewer: hans. https://reviews.llvm.org/D61029 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td === --- clang/include/clang/Dr

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

thakis added a comment. (Just for the record, I'm happy with whatever y'all end up with.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list cfe-comm

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. I'm confused by some of the decisions made in this change, see below. Comment at: clang-tools-extra/trunk/clangd/test/lit.cfg.in:29 + config.available_features.add('clangd-xpc-support') + trailing newline Comment at:

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. thakis wrote: > Every other LLVM project puts the lit.cfg.in for the

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/test/CMakeLists.txt:5 + # No tests for these, but we should still make sure they build. + clangd-indexer + dexp Since you're touching this anyway, there's now one test that calls clang-i

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. sammccall wrote: > MaskRay wrote: > > thakis wrote: > > > thakis wrot

[PATCH] D61324: Make check-clang depend on the clang-check binary always

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-tidy, clang-refactor, etc) if the static analyzer is

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

thakis added a comment. This breaks a test: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12112/steps/check-llvm%20check-clang%20stage3%2Fmsan/logs/stdio [--] 1 test from TransformerTest [ RUN ] TransformerTest.NodePartNameDeclRefFailure /b/s

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. Herald added a project: LLVM. I re-landed this to get access to the msan output, since the link above has long expired. Here's the new link: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/31821/steps/check-clang%20msan/logs/stdio Sadly, the bot outp

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. vitalybuka told me that this should repro things locally: mkdir /tmp/bot cd /tmp/bot svn checkout https://llvm.org/svn/llvm-project/zorg BUILDBOT_CLOBBER= BUILDBOT_REVISION=YOUR_REV zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_fast.sh 2>&1 | tee buildlog

[PATCH] D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest"

thakis added a comment. I think I figured it out. r359604 should fix the bug that caused this to be reverted twice. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50515/new/ https://reviews.llvm.org/D50515 ___ cfe-com

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. In case anyone else runs into this: When doing incremental builds, the old ClangdTests binary stays around in `./tools/clang/tools/unittests/clangd` and is still run by `check-clang-tools`. In case you don't want that (it makes the old test target slower; or maybe your l

<    1   2   3   4   5   6   7   8   9   10   >