thakis added a comment.
Nice!
================
Comment at: cfe/trunk/docs/UsersManual.rst:2950
/Z7 Enable CodeView debug information in object files
+ /Zc:dllexportInlines- Don't dllexport/import inline member functions
of dllexport/import classes
+ /Zc:dllexportInlines dllexport/import inline member functions of
dllexport/import classes (default)
----------------
very nit: I'd s/import/dllimport/. It's a bit longer, but not much, and more
greppable. (for both + and - versions)
================
Comment at: cfe/trunk/docs/UsersManual.rst:3104
+
+This causes the class-level `dllexport` and `dllimport` attributes not to be
+applied to inline member functions, as they otherwise would. For example, in
----------------
"to not be applied" sounds more correct to me, but I'm not a native speaker
either. And I think "to not apply to inline member functions" works to and is
shorter and not passive, and it makes the part after the comma sound better
(with the passive I think it might have to be "as they otherwise would be"?)
================
Comment at: cfe/trunk/docs/UsersManual.rst:3173
+This could lead to very subtle bugs. Using ``-fvisibility-inlines-hidden`` can
+lead to the same issue.
+
----------------
Maybe suggest a workaround in addition to pointing out the problem? ("In these
cases, a workaround is to make foo() not inline" or similar)
Repository:
rL LLVM
https://reviews.llvm.org/D54319
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
