thakis added a comment. In D58418#1430490 <https://reviews.llvm.org/D58418#1430490>, @jkorous wrote:
> In D58418#1430160 <https://reviews.llvm.org/D58418#1430160>, @thakis wrote: > > > Why is this needed for index-while-building? My mental model for > > index-while-building is that that streams out build index metadata as part > > of the regular compile. Why does that require watching directories? > > > You're right that this isn't necessary for the indexing phase. But we also > provide API so clients can consume the index. This functionality is used for > getting notifications about index data changes. > > You can see it for example here: > > https://github.com/apple/swift-clang/blob/stable/lib/IndexDataStore/IndexDataStore.cpp#L111 Is that code going to live in clang? This seems more like a tool built on top of the compiler rather than something core to the compiler itself (like the actual index-while-building feature). Maybe this could be in clang-tools-extra? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
