[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-02-28 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: What's the status of this PR? Seems like it would be helpful for some of the C23 additions (`_Float128` being of most interest to me) https://github.com/llvm/llvm-project/pull/78503 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -1369,13 +1369,50 @@ class TargetInfo : public TransferrableTargetInfo, } struct BranchProtectionInfo { -LangOptions::SignReturnAddressScopeKind SignReturnAddr = -LangOptions::SignReturnAddressScopeKind::None; -LangOptions::SignReturnAddressKeyKind SignK

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -1369,13 +1369,50 @@ class TargetInfo : public TransferrableTargetInfo, } struct BranchProtectionInfo { -LangOptions::SignReturnAddressScopeKind SignReturnAddr = -LangOptions::SignReturnAddressScopeKind::None; -LangOptions::SignReturnAddressKeyKind SignK

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -109,38 +109,29 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo { if (!FD) return; -const auto *TA = FD->getAttr(); -if (TA == nullptr) - return; - -ParsedTargetAttr Attr = -CGM.getTarget().parseTargetAttr(TA->getFeaturesStr(

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -173,6 +167,13 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { diag::warn_target_unsupported_branch_protection_attribute) << Attr.CPU; } +} else if (CGM.getTarget().isBranchProtectionSupportedArch( + CGM.getT

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -173,6 +167,13 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { diag::warn_target_unsupported_branch_protection_attribute) << Attr.CPU; } +} else if (CGM.getTarget().isBranchProtectionSupportedArch( + CGM.getT

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

2024-03-04 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > I'm seeing evidence that this might be a chatty diagnostic in practice: > > https://sourcegraph.com/github.com/torvalds/linux@90d35da658da8cff0d4ecbb5113f5fac9d00eb72/-/blob/kernel/fork.c?L311 > > https://sourcegraph.com/github.com/torvalds/linux@90d35da658da8cff0d4ecb

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

2024-03-04 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > Does anyone understand why Linux uses __builtin_return_address there? Grep turns up 257 callers of `__builtin_return_address` in the linux kernel sources. Hard to say definitely for all cases. It's possible that some are incorrect, or should have their callers explic

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > I tried running clang-format but the diff was huge and beyond just my changes. I usually do `git clang-format HEAD~N` where N is the number of commits of mine (N is optional when N == 1). https://github.com/llvm/llvm-project/pull/80089 _

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv nickdesaulniers wrote: Have you seen `llvm/utils/update_cc_test_checks.py` before? Honestly, ALL new tests to clang (or llvm) involving codegen should strive to use that (or

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv +// RUN: %clang_cc1 -fwrapv -triple x86_64-apple-darwin -emit-llvm -o - %s -fsanitize=signed-integer-wrap | FileCheck %s --check-prefix=CHECK nickdesaulniers wrote: `CHECK` i

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv +// RUN: %clang_cc1 -fwrapv -triple x86_64-apple-darwin -emit-llvm -o - %s -fsanitize=signed-integer-wrap | FileCheck %s --check-prefix=CHECK nickdesaulniers wrote: If there

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv nickdesaulniers wrote: We don't have to use `update_cc_test_checks`; it's nice when we can and when the test has many CHECK lines, but I suspect most of the CHECK lines in th

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-01-31 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,77 @@ +// Check that -fsanitize=signed-integer-wrap instruments with -fwrapv +// RUN: %clang_cc1 -fwrapv -triple x86_64-apple-darwin -emit-llvm -o - %s -fsanitize=signed-integer-wrap | FileCheck %s --check-prefix=CHECKSIW + +// Check that -fsanitize=signed-integer-over

[lld] [llvm] [flang] [libc] [libcxxabi] [clang] [clang-tools-extra] [libcxx] [libc] implement stdc_leading_ones (C23) (PR #80082)

2024-02-01 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers updated https://github.com/llvm/llvm-project/pull/80082 >From de314dcc670093d860830cf7e9c49978e001c3a0 Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Tue, 30 Jan 2024 15:30:41 -0800 Subject: [PATCH 1/6] [libc] implement stdc_leading_ones (C23) --- lib

[lld] [libc] [libcxxabi] [llvm] [clang-tools-extra] [libcxx] [clang] [flang] [libc] implement stdc_leading_ones (C23) (PR #80082)

2024-02-01 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers closed https://github.com/llvm/llvm-project/pull/80082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [clang-tools-extra] [lld] [libcxx] [flang] [clang] [llvm] [libcxxabi] [libc] implement stdc_leading_ones (C23) (PR #80082)

2024-02-01 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: d'oh, this broke post submit tests on non-x86 targets. I see the problem. Fixing. https://github.com/llvm/llvm-project/pull/80082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [libcxx] [lld] [libcxxabi] [clang] [llvm] [flang] [libc] [libc] implement stdc_leading_ones (C23) (PR #80082)

2024-02-01 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: Fix: https://github.com/llvm/llvm-project/pull/80318 https://github.com/llvm/llvm-project/pull/80082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nfc][clang] Fix test in new-array-init.cpp (PR #79225)

2024-01-23 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/79225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [lldb] [libcxx] [lld] [clang-tools-extra] [clang] [llvm] [libclc] [compiler-rt] [libc] [libcxxabi] [Thumb,ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR

2024-01-22 Thread Nick Desaulniers via cfe-commits
@@ -135,14 +135,14 @@ void Thumb1InstrInfo::loadRegFromStackSlot(MachineBasicBlock &MBB, void Thumb1InstrInfo::expandLoadStackGuard( MachineBasicBlock::iterator MI) const { MachineFunction &MF = *MI->getParent()->getParent(); - const TargetMachine &TM = MF.getTarget();

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-22 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: I think the libc buildbots are now failing as a result of this change. @aaupov can you PTAL? - https://lab.llvm.org/buildbot/#/builders/223/builds/34823 - https://lab.llvm.org/buildbot/#/builders/225/builds/29950 https://github.com/llvm/llvm-project/pull/69133 __

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-26 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,78 @@ +// REQUIRES: powerpc-registered-target nickdesaulniers wrote: Yeah, a full on integration test for this is a bit much. The backend tests LGTM; just making sure the frontend doesn't error when presented with this flag (and the `-no` variant) w

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-26 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: Thanks for the patch! https://github.com/llvm/llvm-project/pull/70255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/70366 Fixes a bug introduced by commit b54294e2c959 ("[clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first") In the added test case, the QualType is a LValueReferenceTy

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
@@ -1358,6 +1359,8 @@ class ConstExprEmitter : } llvm::Constant *VisitStringLiteral(StringLiteral *E, QualType T) { +if (!isa(T.getDesugaredType(CGM.getContext( nickdesaulniers wrote: Alternatively this could be: `if (isa)` any preference/though

[clang] [CGExprConstant] stop evaluating StringLiterals for non-ConstantArrayTypes (PR #70366)

2023-10-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Aug 22 13:47:12 2019 New Revision: 369705 URL: http://llvm.org/viewvc/llvm-project?rev=369705&view=rev Log: [Clang][CodeGen] set alias linkage on QualType Summary: It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with __attribute_

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
/consoleFull#-18314650158254eaf0-7326-4999-85b0-388101f2d404 > > Looks like you need to add a triple to the RUN line you added. Can you fix > this? > > Thanks! > Erik > > On Aug 22, 2019, at 1:47 PM, Nick Desaulniers via cfe-commits > wrote: > > Author: nickdesaulniers > Date:

r369713 - [Bugfix] fix r369705 unit test

2019-08-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Aug 22 16:18:46 2019 New Revision: 369713 URL: http://llvm.org/viewvc/llvm-project?rev=369713&view=rev Log: [Bugfix] fix r369705 unit test Summary: Aliases aren't supported on OSX. Add a GNU target triple. Reported-by: leonardchan Reported-by: erik.pilkington

[clang] 663f4f7 - [clang] consistently use getLangOpts()

2020-09-01 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-09-01T15:56:53-07:00 New Revision: 663f4f7edc2476231fa5bfc04519d5fd51a10112 URL: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112 DIFF: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112.di

[clang] e75fec2 - [AttrDocs] document always_inline

2020-12-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-12-17T12:34:23-08:00 New Revision: e75fec2b238f0e26cfb7645f2208baebe3440d41 URL: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41 DIFF: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41.di

[clang] f4c6080 - Revert "[IR] add fn attr for no_stack_protector; prevent inlining on mismatch"

2020-11-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-11-17T17:27:14-08:00 New Revision: f4c6080ab820219c5bf78b0c2143e7fa194da296 URL: https://github.com/llvm/llvm-project/commit/f4c6080ab820219c5bf78b0c2143e7fa194da296 DIFF: https://github.com/llvm/llvm-project/commit/f4c6080ab820219c5bf78b0c2143e7fa194da296.di

[clang] b7926ce - [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

2020-10-23 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-23T11:55:39-07:00 New Revision: b7926ce6d7a83cdf70c68d82bc3389c04009b841 URL: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841 DIFF: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841.di

[clang] c8f84bd - [Clang][CodeGen] fix failed assertion

2020-10-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-26T11:37:55-07:00 New Revision: c8f84bd0947d770a5df5e15d568a25a4f190df0b URL: https://github.com/llvm/llvm-project/commit/c8f84bd0947d770a5df5e15d568a25a4f190df0b DIFF: https://github.com/llvm/llvm-project/commit/c8f84bd0947d770a5df5e15d568a25a4f190df0b.di

[clang] cdff3bd - [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

2020-10-28 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-28T11:20:30-07:00 New Revision: cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 URL: https://github.com/llvm/llvm-project/commit/cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 DIFF: https://github.com/llvm/llvm-project/commit/cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0.di

[clang] 0f41778 - [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-17T11:49:22-07:00 New Revision: 0f417789192e74f9d2fad0f6aee4efc394257176 URL: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176 DIFF: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176.di

[clang] 033138e - [IR] make stack-protector-guard-* flags into module attrs

2021-05-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-21T15:53:30-07:00 New Revision: 033138ea452f5f493fb5095e5963419905ad12e1 URL: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1 DIFF: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1.di

[clang] a680bc3 - [clang][Arm] Fix handling of -Wa,-implicit-it=

2021-02-11 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-02-11T10:51:25-08:00 New Revision: a680bc3a31d36d321ccf3801bdcff74d58842bfa URL: https://github.com/llvm/llvm-project/commit/a680bc3a31d36d321ccf3801bdcff74d58842bfa DIFF: https://github.com/llvm/llvm-project/commit/a680bc3a31d36d321ccf3801bdcff74d58842bfa.di

[clang] 433c8d9 - [IR] make -stack-alignment= into a module attr

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T08:31:04-07:00 New Revision: 433c8d950cb3a1fa0977355ce0367e8c763a3f13 URL: https://github.com/llvm/llvm-project/commit/433c8d950cb3a1fa0977355ce0367e8c763a3f13 DIFF: https://github.com/llvm/llvm-project/commit/433c8d950cb3a1fa0977355ce0367e8c763a3f13.di

[clang] a596b54 - Revert "[IR] make -stack-alignment= into a module attr"

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T08:55:50-07:00 New Revision: a596b54d471cfde548bdda3925ea2f143f06b964 URL: https://github.com/llvm/llvm-project/commit/a596b54d471cfde548bdda3925ea2f143f06b964 DIFF: https://github.com/llvm/llvm-project/commit/a596b54d471cfde548bdda3925ea2f143f06b964.di

[clang] 3787ee4 - reland [IR] make -stack-alignment= into a module attr

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T10:59:46-07:00 New Revision: 3787ee457173c3612aac4c9b1a2b6d6ab0202616 URL: https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616 DIFF: https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616.di

[clang] fc018eb - [IR] make -warn-frame-size into a module attr

2021-06-10 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-10T16:15:27-07:00 New Revision: fc018ebb608ee0c1239b405460e49f1835ab6175 URL: https://github.com/llvm/llvm-project/commit/fc018ebb608ee0c1239b405460e49f1835ab6175 DIFF: https://github.com/llvm/llvm-project/commit/fc018ebb608ee0c1239b405460e49f1835ab6175.di

[clang] 193e41c - [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

2021-06-18 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-18T13:42:32-07:00 New Revision: 193e41c987127aad86d0380df83e67a85266f1f1 URL: https://github.com/llvm/llvm-project/commit/193e41c987127aad86d0380df83e67a85266f1f1 DIFF: https://github.com/llvm/llvm-project/commit/193e41c987127aad86d0380df83e67a85266f1f1.di

[clang] 8172183 - Whitespace fixes for

2021-06-18 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-18T15:09:18-07:00 New Revision: 817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d URL: https://github.com/llvm/llvm-project/commit/817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d DIFF: https://github.com/llvm/llvm-project/commit/817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d.di

[clang] a63d4f6 - [Clang][Codegen] rename no_profile fn attr no_profile_instrument_function

2021-06-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-21T11:42:06-07:00 New Revision: a63d4f6cbab133b0f1ce9afb562546fcc5bb2680 URL: https://github.com/llvm/llvm-project/commit/a63d4f6cbab133b0f1ce9afb562546fcc5bb2680 DIFF: https://github.com/llvm/llvm-project/commit/a63d4f6cbab133b0f1ce9afb562546fcc5bb2680.di

[clang] 8ace121 - [IR] convert warn-stack-size from module flag to fn attr

2021-06-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-21T15:09:25-07:00 New Revision: 8ace12130526f450c822ca232d1f865b247d7434 URL: https://github.com/llvm/llvm-project/commit/8ace12130526f450c822ca232d1f865b247d7434 DIFF: https://github.com/llvm/llvm-project/commit/8ace12130526f450c822ca232d1f865b247d7434.di

[clang] d238b60 - [Clang][DiagnosticSemaKinds] combine diagnostic texts

2021-08-06 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-08-06T13:58:21-07:00 New Revision: d238b60285820691b08bcca3ec510d13ea46a5ed URL: https://github.com/llvm/llvm-project/commit/d238b60285820691b08bcca3ec510d13ea46a5ed DIFF: https://github.com/llvm/llvm-project/commit/d238b60285820691b08bcca3ec510d13ea46a5ed.di

[clang] 9f95bc7 - [clang][ARM] relax -mtp=cp15 for non-thumb cases

2021-12-03 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-12-03T14:00:00-08:00 New Revision: 9f95bc7dc18390199553cf2ea3bfcdc6a95717ef URL: https://github.com/llvm/llvm-project/commit/9f95bc7dc18390199553cf2ea3bfcdc6a95717ef DIFF: https://github.com/llvm/llvm-project/commit/9f95bc7dc18390199553cf2ea3bfcdc6a95717ef.di

[clang] e3bb359 - [clang][Toolchains][Gnu] pass -g through to assembler

2022-10-24 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-10-24T12:30:44-07:00 New Revision: e3bb359aacddb5e0266e219f33d27b642089fd53 URL: https://github.com/llvm/llvm-project/commit/e3bb359aacddb5e0266e219f33d27b642089fd53 DIFF: https://github.com/llvm/llvm-project/commit/e3bb359aacddb5e0266e219f33d27b642089fd53.di

[clang] ad78ce4 - [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

2022-10-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-10-26T10:45:22-07:00 New Revision: ad78ce44bb4771139d2a18d6e1052268a7507a52 URL: https://github.com/llvm/llvm-project/commit/ad78ce44bb4771139d2a18d6e1052268a7507a52 DIFF: https://github.com/llvm/llvm-project/commit/ad78ce44bb4771139d2a18d6e1052268a7507a52.di

[clang] f039437 - git clang-format HEAD~

2022-10-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-10-26T14:24:30-07:00 New Revision: f03943722ba5a9fb2a0f23eb158ad469428b8876 URL: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876 DIFF: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876.di

[clang] 333771f - [Sema] Avoid isNullPointerConstant invocation

2022-08-14 Thread Nick Desaulniers via cfe-commits
Author: Justin Stitt Date: 2022-08-14T13:39:57-07:00 New Revision: 333771f3558c81390a0e5d715ad8d1e419050b66 URL: https://github.com/llvm/llvm-project/commit/333771f3558c81390a0e5d715ad8d1e419050b66 DIFF: https://github.com/llvm/llvm-project/commit/333771f3558c81390a0e5d715ad8d1e419050b66.diff

[clang] 2dbfd06 - [Clang] fix -Wvoid-ptr-dereference for gnu89

2022-10-04 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-10-04T13:01:01-07:00 New Revision: 2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7 URL: https://github.com/llvm/llvm-project/commit/2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7 DIFF: https://github.com/llvm/llvm-project/commit/2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7.di

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-19 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. Thanks for the fix! https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, nickdesaulniers wrote: Why make it a method on InstrI

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, nickdesaulniers wrote: Ah! Ok, they *why* for this PR

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, nickdesaulniers wrote: Ah! Ok, they *why* for this PR

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-22 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: ping @hazohelet . This should be good to land and should help clear some red in our CI for Linux kernel builds. https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9796,27 +9796,34 @@ X86InstrInfo::insertOutlinedCall(Module &M, MachineBasicBlock &MBB, return It; } -void X86InstrInfo::buildClearRegister(Register Reg, - MachineBasicBlock &MBB, +void X86InstrInfo::buildClearRegister(Register Reg,

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -3176,6 +3178,11 @@ def err_alignas_underaligned : Error< "requested alignment is less than minimum alignment of %1 for type %0">; def warn_aligned_attr_underaligned : Warning, InGroup; +def err_ctor_dtor_attr_on_non_void_func : Error< + "%0 attribute can only be applie

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -3176,6 +3178,11 @@ def err_alignas_underaligned : Error< "requested alignment is less than minimum alignment of %1 for type %0">; def warn_aligned_attr_underaligned : Warning, InGroup; +def err_ctor_dtor_attr_on_non_void_func : Error< + "%0 attribute can only be applie

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: ah, yeah I was curious about what precisely `reserved for the implementation` meant. System libraries? That means they should be able to opt out via `-Wno-whatever`. For anything thats */test/*, I assume they can be adjusted to just not use a reserved priority? https:/

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers unresolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers unresolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-27 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > We could maybe presume glibc on ELF targets Isn't that part of the triple? `aarch64-linux-gnu` gnu -> glibc (as opposed to `aarch64-linux-musl` -> musl, or `aarch64-linux-android` -> bionic) https://github.com/llvm/llvm-project/pull/67360 __

[clang] f023f5c - [clang][JumpDiagnostics] ignore non-asm goto target scopes

2023-07-20 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-20T19:58:22-07:00 New Revision: f023f5cdb2e6c19026f04a15b5a935c041835d14 URL: https://github.com/llvm/llvm-project/commit/f023f5cdb2e6c19026f04a15b5a935c041835d14 DIFF: https://github.com/llvm/llvm-project/commit/f023f5cdb2e6c19026f04a15b5a935c041835d14.di

[clang] ac52488 - [clang] fix for D155342

2023-07-20 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-20T20:30:37-07:00 New Revision: ac524886094db58112ca176e1d727330a94634a8 URL: https://github.com/llvm/llvm-project/commit/ac524886094db58112ca176e1d727330a94634a8 DIFF: https://github.com/llvm/llvm-project/commit/ac524886094db58112ca176e1d727330a94634a8.di

[clang] b54294e - [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

2023-07-24 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-24T13:50:45-07:00 New Revision: b54294e2c9596088aaf557b221bcf471745864bc URL: https://github.com/llvm/llvm-project/commit/b54294e2c9596088aaf557b221bcf471745864bc DIFF: https://github.com/llvm/llvm-project/commit/b54294e2c9596088aaf557b221bcf471745864bc.di

[clang] 15a484b - [clang][ConstExprEmitter] handle IntegerLiterals

2023-07-25 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-25T14:12:50-07:00 New Revision: 15a484bf6990c5c3b759f5bbf99055612c20b924 URL: https://github.com/llvm/llvm-project/commit/15a484bf6990c5c3b759f5bbf99055612c20b924 DIFF: https://github.com/llvm/llvm-project/commit/15a484bf6990c5c3b759f5bbf99055612c20b924.di

[clang] ef103ad - [clang][CodeGenModule] remove declaration of GetAddrOfConstantString

2023-07-25 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-25T14:25:25-07:00 New Revision: ef103adf60c6fccd3cc6d76b362c1c37c41da30f URL: https://github.com/llvm/llvm-project/commit/ef103adf60c6fccd3cc6d76b362c1c37c41da30f DIFF: https://github.com/llvm/llvm-project/commit/ef103adf60c6fccd3cc6d76b362c1c37c41da30f.di

[clang] d119980 - [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

2023-07-25 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-25T15:27:08-07:00 New Revision: d1199808afa5b46dfb6738f123b869d0e2fa050a URL: https://github.com/llvm/llvm-project/commit/d1199808afa5b46dfb6738f123b869d0e2fa050a DIFF: https://github.com/llvm/llvm-project/commit/d1199808afa5b46dfb6738f123b869d0e2fa050a.di

[clang] 2c26397 - [clang][ConstExprEmitter] handle NullToPointer ImplicitCastExpr

2023-07-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-07-26T12:53:02-07:00 New Revision: 2c26397f76d9b8d2a0dc8207eeca5b0d3216f3f0 URL: https://github.com/llvm/llvm-project/commit/2c26397f76d9b8d2a0dc8207eeca5b0d3216f3f0 DIFF: https://github.com/llvm/llvm-project/commit/2c26397f76d9b8d2a0dc8207eeca5b0d3216f3f0.di

[clang] e698695 - Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-08-16 Thread Nick Desaulniers via cfe-commits
Author: Erik Pilkington Date: 2023-08-16T15:21:46-07:00 New Revision: e698695fbbf62e6676f8907665187f2d2c4d814b URL: https://github.com/llvm/llvm-project/commit/e698695fbbf62e6676f8907665187f2d2c4d814b DIFF: https://github.com/llvm/llvm-project/commit/e698695fbbf62e6676f8907665187f2d2c4d814b.dif

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

2023-10-06 Thread Nick Desaulniers via cfe-commits
@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::De

<    1   2   3   4   5   >