Author: Nick Desaulniers Date: 2023-07-25T14:25:25-07:00 New Revision: ef103adf60c6fccd3cc6d76b362c1c37c41da30f
URL: https://github.com/llvm/llvm-project/commit/ef103adf60c6fccd3cc6d76b362c1c37c41da30f DIFF: https://github.com/llvm/llvm-project/commit/ef103adf60c6fccd3cc6d76b362c1c37c41da30f.diff LOG: [clang][CodeGenModule] remove declaration of GetAddrOfConstantString It looks like the definition was removed in cd21d541397e but the declaration was not. Surprisingly (to me), that doesn't seem to produce any kind of diagnostic. Reviewed By: efriedma Differential Revision: https://reviews.llvm.org/D156182 Added: Modified: clang/include/clang/CodeGen/ConstantInitBuilder.h clang/lib/CodeGen/CodeGenModule.h Removed: ################################################################################ diff --git a/clang/include/clang/CodeGen/ConstantInitBuilder.h b/clang/include/clang/CodeGen/ConstantInitBuilder.h index 88e357a0c29c06..9e0d0fa0d8e824 100644 --- a/clang/include/clang/CodeGen/ConstantInitBuilder.h +++ b/clang/include/clang/CodeGen/ConstantInitBuilder.h @@ -41,7 +41,7 @@ class CodeGenModule; /// for (auto &widget : widgets) { /// auto widgetDesc = widgetArray.beginStruct(); /// widgetDesc.addInt(CGM.SizeTy, widget.getPower()); -/// widgetDesc.add(CGM.GetAddrOfConstantString(widget.getName())); +/// widgetDesc.add(CGM.GetAddrOfConstantStringFromLiteral(widget.getName())); /// widgetDesc.add(CGM.GetAddrOfGlobal(widget.getInitializerDecl())); /// widgetDesc.finishAndAddTo(widgetArray); /// } diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index c5de947687ea61..8517b1c93b40f1 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1019,11 +1019,6 @@ class CodeGenModule : public CodeGenTypeCache { /// Return a pointer to a constant CFString object for the given string. ConstantAddress GetAddrOfConstantCFString(const StringLiteral *Literal); - /// Return a pointer to a constant NSString object for the given string. Or a - /// user defined String object as defined via - /// -fconstant-string-class=class_name option. - ConstantAddress GetAddrOfConstantString(const StringLiteral *Literal); - /// Return a constant array for the given string. llvm::Constant *GetConstantArrayFromStringLiteral(const StringLiteral *E); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
