[PATCH] D87225: [clangd] When finding refs for a template specialization, do not return refs to other specializations

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/515 Repository:

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/c

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge added a reviewer: hokein. nridge added a comment. I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however the output of `c-index-test` does not seem to be changed by adding this reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge updated this revision to Diff 290379. nridge added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87257/new/ https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp clang/lib/Index/Ind

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

nridge added a comment. In D87253#2261837 , @amosnier wrote: > How can I make sure I will receive updates on this issue (or any prolongation > of it)? By commenting on this review, you're automatically subscribed to it, so should get an email notificati

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. In D92155#2419549 , @sammccall wrote: > In D92155#2419346 , @psionic12 wrote: > >> Or, could you help to point out what's the difference between passing a >> plugin path through *clangd* sta

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

nridge updated this revision to Diff 311472. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91025/new/ https://reviews.llvm.org/D91025 Files: clang-tools-ext

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfef242c32e83: [clangd] Fix locateMacroAt() for macro definition outside preamble (authored by nridge). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge added reviewers: sammccall, hokein, kadircet. nridge added a comment. Shopping the patch around to some possible reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 ___

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge updated this revision to Diff 311476. nridge added a comment. Add a missed call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-e

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. In D92155#2454175 , @sammccall wrote: > I thought `getConfiguration('clangd')` with no scope specified was supposed > to be global (i.e. not a workspace-specific setting). There's a scope you can > pass in, and we're not providing

[PATCH] D93522: [WIP] [clangd] Extend heuristic resolution to support nested templates

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. https://github.com/clangd/clangd/issues/451 Repository: rG

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge added a comment. In D92290#2460748 , @sammccall wrote: > my manager was appalled when we added it... :-) > Does this enable some future work, or is it reasonable to evaluate this patch > in isolation? I was inspired to do this by a work-in-progr

[PATCH] D93522: [WIP] [clangd] Extend heuristic resolution to support nested templates

nridge added a comment. (This is not ready for review, I just posted it in case it helps inform discussion in D92290 .) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93522/new/ https://reviews.llvm.org/D93522

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge updated this revision to Diff 302759. nridge marked 4 inline comments as done. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 Files: clang-too

[PATCH] D89670: [clangd] Store the containing symbol for refs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bec07f91fb1: [clangd] Store the containing symbol for refs (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/577 Repository: rG LLVM G

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge added a reviewer: kadircet. nridge added a comment. Kadir, would you like to take a look at this, as you're already familiar with the index changes? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge updated this revision to Diff 304045. nridge added a comment. Split patch as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-ext

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Support for outgoing calls is left for a f

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 304048. nridge added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/X

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge added a comment. Thanks for the reviews! Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39 +--- +{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

nridge added inline comments. Comment at: clang-tools-extra/clangd/README.md:30 + We suggest building in RELEASE mode as building DEBUG binaries requires + considerably more resources. You can check [Building LLVM with CMake + documentation](https://llvm.org/docs/CMake.html) f

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge added a comment. Thanks for working on this! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry::entries()) { +Plugins.emplace_back(Database.getName(), Database.instantiate()); + } A side effect of thi

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Not sure if I'm authorized to approve changes to libTooling, but this LGTM! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry

[PATCH] D91131: [clangd] Bump index version number.

nridge added a comment. My apologies for not thinking of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91131/new/ https://reviews.llvm.org/D91131 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

nridge added a reviewer: sammccall. nridge added a comment. Sam, you're my go-to reviewer for "tricky macro stuff", but feel free to hand off if you prefer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91025/new/ https://reviews.llvm.org/D91025

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305397. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-ext

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305400. nridge marked 12 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-ex

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1317 -static Optional -symbolToTypeHierarchyItem(const Symbol &S, const SymbolIndex *Index, - PathRef TUPath) { kadircet wrote: > that's a great change to have,

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305406. nridge added a comment. Forgot to rename a few fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-extra/clangd/Protocol.cpp clang-tool

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305407. nridge added a comment. Update variable names and remove a commented declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-extra/clang

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 305408. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files: clang-tools-ext

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge added a comment. In D91123#2387032 , @kadircet wrote: > can you also add some tests to ClangdTests.cpp ? It seems like they would be highly duplicative of the tests in CallHierarchyTests.cpp. Comment at: clang-tools-extra/clang

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge updated this revision to Diff 305409. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91124/new/ https://reviews.llvm.org/D91124 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-too

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d77584fe040: [clangd] Call hierarchy (Protocol layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST &AST, Position Pos, const SymbolIndex *Index, kadircet wrote: > nridge wrote: > > kadirc

[PATCH] D83296: [clang-format] Add a MacroExpander.

nridge added a comment. What does this change mean for users of clang-format -- better formatting of complicated (e.g. multi-line) macro invocations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83296/new/ https://reviews.llvm.org/D83296 ___

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1155 + AdditionalDecls.push_back(AD); +break; + } hokein wrote: > I think the `break` is not necessarily needed. In practice we should just > have one non-renaming

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge updated this revision to Diff 294851. nridge marked 2 inline comments as done. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 Files: clang-too

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc6d1f8029b0: [clangd] When finding refs for a renaming alias, do not return refs to… (authored by nridge). Changed prior to commit: https://revie

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/500 Repository: rG LLVM G

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/543 Repository: rG LLVM G

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; hokein wrote: > why not using `isa(D)

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge added a comment. Sorry, I had a response to that comment but accidentally left it as unsubmitted... Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsMultiFile) { + MockFS FS; kadircet w

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge updated this revision to Diff 296019. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/new/ https://reviews.llvm.org/D88469 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nridge requested review of this revision. sccache is a compiler caching tool similar to ccache. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88790 Files: clang/lib/Tooling/

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge added a comment. Link to sccache for those not familiar: https://github.com/mozilla/sccache/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790 ___ cfe-commit

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge updated this revision to Diff 297445. nridge marked an inline comment as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/new/ https://reviews.llvm.org/D88469 Files: clang-tools-extr

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge updated this revision to Diff 297482. nridge added a comment. Slightly simplified test (base class does not need to be a template to trigger the issue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/ https://reviews.llvm.org/D87256

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsMultiFile) { + MockFS FS; kadircet wrote: > kadircet wrote: > > nridge wrot

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf82346fd7391: [clangd] Avoid relations being overwritten in a header shard (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge added a reviewer: sammccall. nridge added a comment. Sam, perhaps you could have a look at this? It involves tricky macro location stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88463/new/ https://reviews.llvm.org/D88463

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b962fdd5f36: [clangd] Heuristic resolution for dependent type and template names (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/n

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge updated this revision to Diff 297712. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88463/new/ https://reviews.llvm.org/D88463 Files: clang-tools-ext

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb764edc59ff7: [clangd] Try harder to get accurate ranges for documentSymbols in macros (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D60954: [clangd] Test case demonstrating variable template issue

nridge abandoned this revision. nridge added a comment. Herald added a subscriber: usaxena95. Fixed by D89098 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60954/new/ https://reviews.llvm.org/D60954 _

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

nridge added a comment. I posted about this a while ago, but wasn't sure how to fix. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89098/new/ https://reviews.l

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

nridge added a comment. This is neat! Are there plans to add vscode client support to invoke this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 ___ cfe-commits

[PATCH] D89284: [clangd] Propagate CollectMainFileRefs to BackgroundIndex

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This appears to have been an omission in D83536 <

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Use it in BackgroundIndexTest.RelationsMultiFile Repository: rG LLVM Gi

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge added a comment. This patch is a spinoff from my call hierarchy work (which I haven't posted for review yet, though I posted a draft at D89296 ). I'd like to be able to write tests where I can: - specify the contents of multiple header and source files,

[PATCH] D89284: [clangd] Propagate CollectMainFileRefs to BackgroundIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge added a comment. In D89297#2326838 , @nridge wrote: > In principle, it should be possible to make the same interface work with > `FileIndex` under the hood, but I haven't figured out how. (Specifically, I > haven't figured out how to get `FileInde

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. I applied the patch locally and it fixes most of the linker errors but I'm still seeing one: [6/393] Linking CXX executable bin/clangd-index-server FAILED: bin/clangd-index-server : && /usr/bin/clang++-10 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. In D91859#2410166 , @kadircet wrote: > In D91859#2409743 , @nridge wrote: > >> I applied the patch locally and it fixes most of the linker errors but I'm >> still seeing one: >> >> [...] > >

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. In D91859#2410002 , @kbobyrev wrote: > Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. > @nridge, I believe this should fix the problem you're seeing. Not sure if this is what you meant, but I fixed it by add

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 306951. nridge marked 14 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-ex

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1649 + // into the same CallHierarchyIncomingCall. + llvm::DenseMap ResultMap; + // We can populate the keys of ResultMap, and the FromRanges fields of ---

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 306953. nridge added a comment. Update as per API changes in xrefs patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files: clang-tools-extra/clangd/ClangdServer.c

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge updated this revision to Diff 306954. nridge added a comment. Update as per API changes in xrefs patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91124/new/ https://reviews.llvm.org/D91124 Files: clang-tools-extra/clangd/ClangdLSPServe

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

nridge added a comment. As discussed in https://reviews.llvm.org/D91123#inline-856770 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91941/new/ https://reviews.llvm.org/D91941 ___ cfe-commits mailing list

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 307223. nridge marked 2 inline comments as done. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tool

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. Thank you for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e6e6a2db674: [clangd] Call hierarchy (XRefs layer, incoming calls) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb976e014db: [clangd] Call hierarchy (ClangdServer layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a4f99c494d0: [clangd] Call hierarchy (ClangdLSPServer layer) (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D91124?vs=30

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdced150375d0: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy() (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D92000: [clangd] Collect main file refs by default

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is needed for call hierarchy to be able to fi

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. It looks like `CallHierarchy.IncomingOneFile` in failing on a few of the buildbots (e.g. clang-ppc64be-linux and clang-s390x-linux ), while passing on most of them. I

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo htt

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, kadircet

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, nridge wr

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. Note, the call hierarchy feature is pretty significantly impaired without this. See the example of `Selection::createEach()` discussed in this comment . Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

nridge updated this revision to Diff 307262. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92009/new/ https://reviews.llvm.org/D92009 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/c

[PATCH] D92009: [clangd] Sort results of incomingCalls request by container name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6f47595bab: [clangd] Sort results of incomingCalls request by container name (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92077: [clangd] Avoid type hierarchy crash on incomplete type

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/597 Repository: rG LLVM G

[PATCH] D92077: [clangd] Avoid type hierarchy crash on incomplete type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d2c681f2835: [clangd] Avoid type hierarchy crash on incomplete type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. One thing that just occurred to me: does this need an index version bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 ___ cfe-commits

[PATCH] D92000: [clangd] Collect main file refs by default

nridge updated this revision to Diff 307730. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 Files: clang-tools-extra/clangd/ClangdServer.h clang-tools-ext

[PATCH] D92000: [clangd] Collect main file refs by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6cb47b640ff: [clangd] Collect main file refs by default (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/602 Repository: rG LLVM G

[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fd91ddaf9d: [clangd] Do not treat line as inactive if skipped range ends at character… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. > What I'm asking specifically is: this feature has a cost, how important is > supporting it? Are there codebases where these attributes are widely used, > and enforcement at development time is particularly valuable? FWIW, one of the codebases I work on uses a clang plu

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

nridge created this revision. nridge added a reviewer: njames93. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, xazax.hun. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://bugs.llvm.org/s

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

nridge added a comment. I see that you have a more sophisticated fix at D91149 . Will leave it up to you if we should just wait for that to land, or land this in the interim. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

<    1   2   3   4   5   6   7   8   9   10   >