nridge added a comment.

In D92155#2454175 <https://reviews.llvm.org/D92155#2454175>, @sammccall wrote:

> I thought `getConfiguration('clangd')` with no scope specified was supposed 
> to be global (i.e. not a workspace-specific setting). There's a scope you can 
> pass in, and we're not providing one.
>
> Nevertheless testing it locally these flags do seem to be used. We should fix 
> this, I think `workspace.getConfiguration('clangd').inspect('arguments')` and 
> then applying the components manually makes it possible. This is a horrible 
> breaking change, though :-(

Apart from the breaking nature of the change, I think being able to specify 
`"clangd.arguments"` per-workspace is a very important use case (to take the 
most obvious example, `--compile-commands-dir` is workspace-specific).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92155/new/

https://reviews.llvm.org/D92155

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to