nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/XRefs.cpp:1155 + AdditionalDecls.push_back(AD); + break; + } ---------------- hokein wrote: > I think the `break` is not necessarily needed. In practice we should just > have one non-renaming alias at the current position. If not, that probably > means we likely have a bug, `break` seems to just hide the bug. Agreed, the `break` was left over from the previous approach and shouldn't be there any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
