[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added a comment. In D124688#3483895 , @sammccall wrote: > Trying this on a few files, this seems like it increases preamble sizes up to > 1% or so Are preamble sizes a good proxy for preamble build times as well? I suspect that may be the metric

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:388 +// arguments +auto ForwardedParmMatcher = compoundStmt(forEachDescendant( +invocation( upsj wrote: > sammccall wrote: > > We tend not to use ASTMatchers for the

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge added a comment. Thanks, the changes here look good. Something is strange about the diff though, it's not letting me see the complete changes relative to the baseline, only the incremental changes relative to a previous version (I think this is also why Phabricator's build status says p

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 426356. nridge added a comment. Handle implicit coawait-exprs properly in RebuildCoawaitExpr, other test fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files:

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. In D115187#3471261 , @sammccall wrote: > We're not supposed to transform > initial/final suspends, but the code is now doing so. > > This seems to be a consequence of switching from BuildRe

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Final nit: please update the commit message as it's a bit out of date, and then I'll go ahead and merge Comment at: clang-tools-extra/clangd/unittests/InlayHintTest

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG043e96502408: [clangd] Add inlay hints for mutable reference parameters (authored by upsj, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:474 +// the parameter names from the wrapped function +if (Args.size() > FixedParamCount && Args.size() == Params.size()) { + auto ForwardedParams = matchForwardedParams( --

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

nridge added a comment. Is there a related change that explains what this setting does? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) { nridge wrote: > daiyousei-qz wrote: > > nridge wrote: > > > It would be interesting to have a couple of test c

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:266 if (IsLastInScope) { - // If the if statement is the last statement its enclosing statements + // If the if statement is the last statement of its enclo

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

nridge added a comment. nit: typo in commit message ("hedaer") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129642/new/ https://reviews.llvm.org/D129642 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge updated this revision to Diff 445407. nridge added a comment. Revise patch to use $0 (no placeholder text) rather than ${n:placeholder} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128621/new/ https://reviews.llvm.org/D128621 Files: clan

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge added a comment. In D128621#3645271 , @sammccall wrote: > - Of the ideas we've heard, I like `${0:named}` => `$0` best, but can > certainly live with the one in this patch I like this approach as well. Revised the patch to do this. Repository:

[PATCH] D88299: [clang-format] Add MacroUnexpander.

nridge added a comment. Does this patch change the formatting behaviour of clang-format? If so, are there any test cases that show before/after formatting? The MacroCallReconstructorTest unit test seems like it's testing an internal interface. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D88299: [clang-format] Add MacroUnexpander.

nridge added a comment. Thanks! (I was intrigued by Sam's "solves a whole class of clang-format's biggest problems" comment :-)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299

[PATCH] D67025: Add .inl as valid C++ header type

nridge added a reviewer: sammccall. nridge added a subscriber: sammccall. nridge added a comment. Adding @sammccall as reviewer This is a simple change that would benefit clangd users (it just came up again recently, on Stack Overflow

[PATCH] D67025: Add .inl as valid C++ header type

nridge added a comment. In D67025#3665293 , @aaron.ballman wrote: > this is why we have the `-x` option so that users can specify a specific > language mode to use. Is there a reason that option does not suffice for > clangd? One reason is that the mos

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

nridge added a comment. In D130259#3671009 , @kadircet wrote: > sorry for not mentioning in the bug that i was also working on a patch, Which bug/issue is this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

nridge updated this revision to Diff 447112. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128621/new/ https://reviews.llvm.org/D128621 Files: clang-tools-extra/clangd/CodeCompletionStrings.c

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2eba08fd9a5f: [clangd] Do not try to use $0 as a placeholder in completion snippets (authored by nridge). Repository: rG LLVM Github Monorepo CHA

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 427998. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files: clang-tools-e

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1476 bool IsImplicit) { -return getSema().BuildResolvedCoawaitExpr(CoawaitLoc, Result, IsImplicit); +// This function rebuilds a coawait-expr given its operator. +

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. There is one remaining test failure, related to a duplicate diagnostic. I've reduced it to the following: namespace std { template struct coroutine_traits {}; } // end of namespace std struct awaitable { bool await_ready() noexcept; template

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. I think the issue is related to this loop in `AnalyzeImplicitConversions()`, which iterates over `Expr::children()`, and adds each child to a list of expressio

[PATCH] D124909: Fix issues with using clangd with C++ modules

nridge added a comment. In D124909#3501896 , @sammccall wrote: > I think first steps are pretty high level, to understand: > > - what the goals are (e.g. performance, easier integration with build system, > work with modules syntax features, ...) I'll s

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 429611. nridge added a comment. Fix last test case and review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files: clang-tools-extra/clangd/unittests/FindT

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added a comment. I looked through this patch, and it looks good to me! I will leave the final approval to Sam though. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416 +// These mocks aren't quite right - we omit shared_ptr for simplicity. +

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Had a read through this. I'm still digesting it, but the high-level approach seems reasonable to me. Could we add a test case for the recursive scenario that came up during chat: void foo(); template void foo(Head head, Tail... tail) { foo(tail...); }

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Another test case that comes to mind is: void f1(int a, int b); void f2(int c, int d); template void foo(Args... args) { if (cond) { f1(args...); } else { f2(args...); } } int main() { foo(1, 2); } I guess in this case it w

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. One more testcase: template void foo(Args...); template void bar(Args... args) { foo(args...); } template void foo(Args... args) { bar(args...); } int main() { foo(1, 2); } Sure, this is a stack overflow at runtime, but there's

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end()) {

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end()) {

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf2a4eae6b19: [clang] Expose CoawaitExpr's operand in the AST (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

nridge added a comment. In D126138#3529820 , @paulaltin wrote: > It turned out that this issue wasn't actually specific to multi-line macros > (see this comment > ), Indeed, sin

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

nridge added a comment. Potentially related issue: https://github.com/clangd/clangd/issues/773 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125863/new/ https://reviews.llvm.org/D125863 ___ cfe-commits m

[PATCH] D126274: [clangd] Handle '--' in QueryDriverDatabase

nridge created this revision. nridge added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. Herald added a project: All. @iannisdezwart Hi :) Do you plan to continue to work on this? It seems like we're most of the way there! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. I'm not a clang-tidy maintainer so I don't know if I have the authority to green-light this patch, but I'm fairly confident the fix is correct (it's restoring the previous usage of the SourceM

[PATCH] D126274: [clangd] Handle '--' in QueryDriverDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rG175833ed6f62: [clangd] Handle '--' in QueryDriverDatabase (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126274/new/ https://reviews.ll

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge updated this revision to Diff 557829. nridge added a comment. Implement the "simple lookup optimization" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files: clang-tools-extra/clangd/ClangdLSPSer

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge planned changes to this revision. nridge added a comment. The updated patch additionally implements the "simple lookup optimization" discussed in the review. With this version, memory usage on the test workload is: background_index 574MB (index 387MB, slabs 187MB). This is an increase o

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge updated this revision to Diff 557830. nridge added a comment. Address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge marked 2 inline comments as done. nridge added a comment. @sammccall, how would you feel about proceeding with the patch in its current state, with the memory usage increase brought down from 8.2% to 2.5% thanks to the combination of the simple lookup optimization + RefKind filtering, and

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

nridge created this revision. nridge added reviewers: hokein, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It's useful to be able to distinguish local variables from namespace scope variables. Repository:

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86a4a530f435: [clangd] Add a distinct highlighting for local variables (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D66723?vs=217065&id=217476#toc Repository: rG LLVM Githu

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66828 Files: clang-tools-extra/cla

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL370429: [clangd] Add distinct highlightings for static fields and methods (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66990 Files: clang-tools-extra/cla

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. There is precedent for highlighting declarations and uses differently in other C++ editors. For example, Eclipse CDT has separate highlightings for function and functions declarations (see screenshot below). Objectively speaking, I think it makes sense to style function

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type can be a pointer or ilya-bir

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. In D66990#1654312 , @ilya-biryukov wrote: > I think this makes sense, but it should be done for **all** declarations and > not just functions. > But doing that in the current design would mean we need to double the number > of s

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. In D66990#1655175 , @ilya-biryukov wrote: > In D66990#1655030 , @nridge wrote: > > > I was hoping though that a patch like this, which would bring us largely to > > parity with Eclipse CDT'

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72041 Files: clang-tools-extra/c

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fix some bugs in the testcases which this exposed. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72066 Fil

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 235970. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-ext

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is mostly a workaround for https://bugs.llvm.org/show_bug.cgi?id=42914. Once that is fixed, the handling in VisitDeducedTyped()

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

nridge added a comment. Just throwing a wild idea out there: what if we used `textDocument/onTypeFormatting` to replace the `.` with `->` as soon as it's typed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67224/new/ https://reviews.llvm.org/D67

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 236608. nridge marked an inline comment as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-extra/clangd/u

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG751d4dae3284: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D72066?vs=236608&id=236612#toc Repositor

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f47cf607c7: [clangd] Heuristically resolve dependent call through smart pointer type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

nridge updated this revision to Diff 236621. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71644/new/ https://reviews.llvm.org/D71644 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236653. nridge added a comment. Remove no longer used flag from XRefTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-extra/clangd/FindTarge

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/un

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236652. nridge marked an inline comment as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-ext

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 236674. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-ext

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a69d3c6b3da: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D72119?vs=236653&id=237183#toc Repository: rG L

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 237186. nridge added a comment. Address latest review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-e

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge updated this revision to Diff 237193. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72355/new/ https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added reviewers: kadircet, ilya-biryukov, sammccall. nridge added a comment. Review ping again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 ___ cfe

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

nridge added inline comments. Comment at: include/clang/Tooling/Syntax/Tokens.h:206 + /// DECL(a); + /// spelledTokens() returns {"#", "define", "DECL", "(", "name", ")", "eof"}. + /// FIXME: we do not yet store tokens of directives, like #include, #define, ---

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:898 class $10^Foo { - $11^Foo(int); + $11^Foo(int) {} $12^Foo(): $13^Foo(111) {} ilya-biryukov wrote

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge updated this revision to Diff 237570. nridge marked 2 inline comments as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72355/new/ https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/un

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ad1308b69b8: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 237572. nridge marked an inline comment as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-extra/clangd/XR

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rG79a09d8bf4d5: [clangd] Show template arguments in type hierarchy when possible (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge added a comment. In D72041#1800189 , @sammccall wrote: > - the allSelectedNodes API on SelectionTree feels non-orthogonal: it's only > meaningful here because the input happened to be a point and thus touches a > single token and therefore node. I

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge updated this revision to Diff 238094. nridge added a comment. Revise the approach to treat non-first expansions as not-selected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72041/new/ https://reviews.llvm.org/D72041 Files: clang-tools-ex

[PATCH] D87979: [clangd] Link libclangdSupport into clangd-index-server

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/534 Repos

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge added a comment. In D87257#2260499 , @hokein wrote: > In D87257#2260022 , @nridge wrote: > >> I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however >> the output of `c-index-test` does

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge updated this revision to Diff 293040. nridge added a comment. Add clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87257/new/ https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp clang/lib/Ind

[PATCH] D87995: [clangd] Fix typo in field name

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8

[PATCH] D87995: [clangd] Fix typo in field name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90a8c44d92b2: [clangd] Fix typo in field name (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge updated this revision to Diff 293045. nridge added a comment. Herald added a subscriber: mgrang. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/ https://reviews.llvm.org/D87256 Files: clang-tools-extra/cla

[PATCH] D87225: [clangd] When finding refs for a template specialization, do not return refs to other specializations

nridge updated this revision to Diff 293047. nridge added a comment. Take a different fix approach, as suggested in the issue discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 Files: clang-tools-

[PATCH] D87979: [clangd] Link libclangdSupport into clangd-index-server

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18f8f34d3d8: [clangd] Link libclangdSupport into clangd-index-server (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87979/new/ https:/

[PATCH] D87257: [clang] Traverse init-captures while indexing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa3c7638ba16: [clang] Traverse init-captures while indexing (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D87257?vs=2930

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1150 + if (llvm::isa(D) || llvm::isa(D)) { +Decls = getDeclAtPosition(AST, *CurLoc, + Relations | DeclRelation::Underlying); hokein wrote: >

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge updated this revision to Diff 294577. nridge marked 5 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87256/new/ https://reviews.llvm.org/D87256 Files: clang-tools-ext

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge updated this revision to Diff 294580. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1150 + if (llvm::isa(D) || llvm::isa(D)) { +Decls = getDeclAtPosition(AST, *CurLoc, + Relations | DeclRelation::Unde

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. nridge requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceI

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 287291. nridge added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceInfo.cpp clang/unittests/Index/Index

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167 +if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName())) + return false; + hokein wrote: > nit: this could be simplified by calling the > `base::TraverseTemplat

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 21. nridge marked 4 inline comments as done. nridge added a comment. Herald added a subscriber: danielkiss. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.ll

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge updated this revision to Diff 22. nridge added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.llvm.org/D86424 Files: clang/lib/Index/IndexTypeSourceInfo.cpp clang/test/Index/Core/index-sou

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, danielkiss, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If the tree includes

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

nridge added a comment. In D86861#2249490 , @hokein wrote: > IIUC, you're mostly fixing the issues mentioned in > https://github.com/clangd/vscode-clangd/pull/44#issuecomment-669092168. If it > just contains two fixes (this, and https://reviews.llvm.org/

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd6b0c3b5db: [clang] Do not consider the template arguments of bases to be bases themselves (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D86861: [clangd] Handle templates more consistently in type hierarchy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca842c825a1c: [clangd] Handle templates more consistently in type hierarchy (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SIN

<    1   2   3   4   5   6   7   8   9   10   >