nridge added a comment. Thanks, the changes here look good.
Something is strange about the diff though, it's not letting me see the complete changes relative to the baseline, only the incremental changes relative to a previous version (I think this is also why Phabricator's build status says patch application failed <https://buildkite.com/llvm-project/diff-checks/builds/102021>) ================ Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:223 + assertParameterHints(R"cpp( + using alias = int&; + void foo(alias param); ---------------- For good measure, let's add an `alias = const int&` case (expecting no `&`) as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124359/new/ https://reviews.llvm.org/D124359 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
