nridge added inline comments.
================ Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167 + if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName())) + return false; + ---------------- hokein wrote: > nit: this could be simplified by calling the > `base::TraverseTemplateSpecializationTypeLoc` I don't see how, given that `WalkUpFromTemplateSpecializationTypeLoc()`needs to be called with `Relations` containing `RelationIsBaseOf`, while `TraverseTemplateArgumentLoc()` needs to be called with `Relations` empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86424/new/ https://reviews.llvm.org/D86424 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
