[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

kadircet accepted this revision. kadircet added a comment. LGTM from my side as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64918/new/ https://reviews.llvm.org/D64918 ___ cfe-commits mailing lis

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210564. kadircet added a comment. - Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/c

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet updated this revision to Diff 210589. kadircet marked an inline comment as done. kadircet added a comment. - Get rid of CachedShard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 Files: clang-to

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet updated this revision to Diff 210594. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64860/new/ https://reviews.llvm.org/D64860 Files: clang-tools-extra/clangd/FS.cpp clang-tools-extra/clang

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rL366455: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D64712: [clangd] Refactor background-index shard loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL366458: [clangd] Refactor background-index shard loading (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:149 + std::unique_ptr create(PathRef CDBDirectory) { +assert(!CDBDirectory.empty() && + "Tried to create storage for empty directory!"); sammccall

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

kadircet updated this revision to Diff 210621. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64745/new/ https://reviews.llvm.org/D64745 Files: clang-tools-ex

[PATCH] D64745: [clangd] BackgroundIndex stores shards to the closest project

This revision was automatically updated to reflect the committed changes. Closed by commit rL366467: [clangd] BackgroundIndex stores shards to the closest project (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM thanks! Do you have commit access? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970

[PATCH] D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We were deferring the population of DependentTU field in LoadedShard until BackgroundIndexLoader was consumed. Thi

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

This revision was automatically updated to reflect the committed changes. Closed by commit rL366545: [clangd] Handle windows line endings in QueryDriver (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210786. kadircet added a comment. - Add tests. - Change the layer we ignore the diags: - Mark diags from headers as insidemainfile when we decide to surface them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:473 + SourceManager &SM = Info.getSourceManager(); + if (!InsideMainFile && SM.isWrittenInBuiltinFile(Info.getLocation())) { +IgnoreDiagnostics::l

[PATCH] D64980: [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard

This revision was automatically updated to reflect the committed changes. Closed by commit rL366559: Revert "Revert r366458, r366467 and r366468" (authored by kadircet, committed by ). Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Changed prior to commit: https:/

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target = llvm::make_unique(N, SM, Ctx); - return Target->isExtrac

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM from my side. Do you have any concerns @sammccall ? Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) {

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Since background-index can perform disk writes, we don't want to turn it on tests that won't clear it. Repositor

[PATCH] D64990: [clangd] Disable background-index on lit-tests by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL366575: [clangd] Disable background-index on lit-tests by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210834. kadircet added a comment. - Move deduplication logic back into the `flushLastDiag` as discussed offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files:

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 210838. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files: clang-tools-ex

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpts); -

[PATCH] D65154: [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. That LGTM, but i didn't have any bad feelings regarding the previous state. Since we tend to read those options in isolation and don't care about how they look like in general, but that mi

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 212131. kadircet marked 3 inline comments as done. kadircet added a comment. - Always set LastDiagWasAdjusted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files:

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpts); -

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Introduces DefineInline action and initial version of availability checks. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 212307. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files: clang-tools-ex

[PATCH] D64863: [clangd] Ignore diags from builtin files

This revision was automatically updated to reflect the committed changes. Closed by commit rL367303: [clangd] Ignore diags from builtin files (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D65486: [clangd] Ignore semicolons, whitespace, and comments in SelectionTree.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the comments, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65486/new/ https://reviews.llvm.org/D65486 _

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

kadircet added a comment. This looks great, thanks! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745 +bool SymbolCollector::shouldProcessFile(FileID FID) { + assert(ASTCtx); we already have `shouldIndexFile` as an anonymous function inside

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:194 CI.getDiagnostics().setIgnoreAllWarnings(true); +/// Instruct the parser to ask our ASTConsume

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:68 + bool hasOnlyRootStmtChildren(); + // We only support extraction of RootStmts. A RootStmt as a statement that is + // fully selected including all of it's children. ---

[PATCH] D64718: [clangd] Triggering indexing on each translation unit with an error

kadircet planned changes to this revision. kadircet added a comment. this requires keeping an inverted dependency graph, which can be quite expensive memory-wise. In a project like chromium there are ~40k translation units, and it is safe to assume there are ~1k core headers just coming from std

[PATCH] D63264: [clang][Driver] Deduce target triplet from clang executable name

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63264/new/ https://reviews.llvm.org/D63264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet marked an inline comment as done. kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 ___ cfe-commits mailing list cfe-commi

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm.org/D62804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet updated this revision to Diff 206193. kadircet added a comment. - Introduce a new wrapper CDB that adds target and mode info to returned compile commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D6

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet added a comment. In D63194#1553649 , @ilya-biryukov wrote: > The only suggestion from me would be maybe try moving this to a layer that > would also make also benefit other compilation-db-based things like > `clang-tidy`, etc? > Any ideas on h

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet updated this revision to Diff 206210. kadircet marked 9 inline comments as done and an inline comment as not done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63330/new/ https://reviews.llvm.o

[PATCH] D63330: [clangd] Add Value field to HoverInfo

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:920 + {R"cpp( +constexpr int add(int a, int b) { return a + b; } +int [[b^ar]] = add(1, 2); sammccall wrote: > constexpr may not be required here, I

[PATCH] D63714: [clangd] Cleanup the duplicated getTokenRange.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:926 for (const auto &Ref : MainFileRefs) { Location Result; +if (auto Range = nit: move de

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 206231. kadircet marked 9 inline comments as done. kadircet added a comment. - Rename SystemIncludeExtractor to QueryDriverDatabase - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ h

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet updated this revision to Diff 206378. kadircet marked 4 inline comments as done. kadircet added a comment. - Move clang related changes to a different patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. kadircet added a child revision: D63194: [clangd] Link and initialize target infos. Wraps JSON compilation database with a target and mode adding

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

kadircet updated this revision to Diff 206386. kadircet added a comment. Herald added a subscriber: arphaman. - Rename file - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63755/new/ https://reviews.llvm.org/D63755 Files: clang/binding

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

kadircet added a comment. Also there were some offline discussions around, handling of "invisible nodes"(e.g, `ExprWithCleanups`) and other types of typelocs like ParenTypeLocs and owner of '=' sign in copy/move assignment constructors Comment at: clangd/Selection.cpp:54 + +

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet updated this revision to Diff 206598. kadircet marked an inline comment as done. kadircet added a comment. - revert leftover change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 Files: clang-to

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

This revision was automatically updated to reflect the committed changes. Closed by commit rL364386: [clang][Tooling] Infer target and mode from argv[0] when using… (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D63194: [clangd] Link and initialize target infos

kadircet closed this revision. kadircet added a comment. Landed as rL364387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

This revision was automatically updated to reflect the committed changes. Closed by commit rL364389: [clangd] Enable extraction of system includes from custom toolchains (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D63330: [clangd] Add Value field to HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL364390: [clangd] Add Value field to HoverInfo (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:54 + +// RAV subclass to find all DeclRefs in a given Stmt +class FindDeclRefsVisitor I believe this class is rather used to check if any decl referenced in a

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clangd/Selection.cpp:45 + if (R.first > Begin) +return false; // [R.First, Begin) is not covered. + if (Begin < R.second)

[PATCH] D63931: [clangd] Make PreambleStatusCache handle filenames more carefully

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63931/new/ https://reviews.llvm.org/D63931

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/ https://reviews.llvm.org/D63295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:34 +// class to store information about the Expr that is being extracted +class Extract { +public: most of the methods seem to be taking a SM, why not make it

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd currently doesn't cache any indexing failures, which results in retrying those failed files even if their c

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet updated this revision to Diff 207296. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files: clang-tools-ex

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:161 CI.getDiagnostics().hasUncompilableErrorOccurred()) { llvm::errs() << "Skipping TU due to uncompilable errors\n"; +} else { sammccall wrote: > I'm p

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet updated this revision to Diff 207308. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. - Use TUs path as a fallback, rather than a search path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet updated this revision to Diff 207312. kadircet added a comment. - Add comments to the CheckDir lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/ https://reviews.llvm.org/D63295 Files: clang-tools-extra/clang-include-fixer

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet updated this revision to Diff 207316. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files: clang-tools-ex

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is to enable cache invalidation when command line flags changes. Repository: rG LLVM Github Monorepo htt

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:313 +// we don't even know what absolute path they should fall in. +if (HadErrors && !IGN.IsTU) + continue; sammccall wrote: > Maybe add a FIXME that we should

[PATCH] D64019: [clangd] Turn background-index on by default

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64019 Files: clang-tools-extra/clangd/tool/Cla

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet updated this revision to Diff 207484. kadircet marked 2 inline comments as done. kadircet added a comment. - Update fixme to mention error case in addition to the missing files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ http

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet added a comment. In D64018#1566085 , @sammccall wrote: > This makes sense but is hard to debug - is there a reason we don't just store > (the relevant parts of) the actual compile command? Size? Yes I had the size in mind, also didn't see any u

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207489. kadircet added a comment. - Store Cmdline itself instead of hash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ https://reviews.llvm.org/D64018 Files: clang-tools-extra/clangd/index/Backgr

[PATCH] D64063: [clang][ArgumentAdjusters] Do not add fsyntax-only if already exists

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D64018: [clangd] Store hash of command line in index shards.. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet updated this revision to Diff 207497. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/ https://reviews.llvm.org/D63295 Files: clang-tools-ex

[PATCH] D64063: [clang][ArgumentAdjusters] Do not add fsyntax-only if already exists

This revision was automatically updated to reflect the committed changes. Closed by commit rL364904: [clang][ArgumentAdjusters] Do not add fsyntax-only if already exists (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207578. kadircet marked 3 inline comments as done. kadircet added a comment. - Use an InternedCompileCommand struct rather than a pack of StringRefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ ht

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL365005: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory (authored by kadircet, committed by ). Herald added subscribers: llvm-commits, il

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207721. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ https://reviews.llvm.org/D64018 Files: clang-tools-ex

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

kadircet added a comment. Could you also revert changes in `LSPDiagnosticCompare` in `Protocol.h`, that were introduced by rL363889 ? (or bring back `fixits-duplication.test`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64133 Files: clang-tools-extra/clangd/Headers.

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet updated this revision to Diff 207793. kadircet added a comment. - Delete leftover header swap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64133/new/ https://reviews.llvm.org/D64133 Files: clang-tools-extra/clangd/Headers.h clang-too

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:65 struct IncludeGraphNode { - // True if current file is a main file rather than a header. - bool IsTU = false; + enum class SourceFlag : uint8_t { +

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet updated this revision to Diff 207832. kadircet added a comment. - Populate HadErrors in background index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64133/new/ https://reviews.llvm.org/D64133 Files: clang-tools-extra/clangd/Headers.h

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64147 Files: clang-tools-extra/clangd/index/Ba

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. gcc invokes cc1 through a path deduced from argv[0] therefore it must be correctly set. Also it prints the search

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

kadircet updated this revision to Diff 207986. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64147/new/ https://reviews.llvm.org/D64147 Files: clang-tools-ex

[PATCH] D64019: [clangd] Turn background-index on by default

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:191 "Index project code in the background and persist index on disk. " "Experimental"), +llvm::cl::init(true)); --

[PATCH] D63986: [clangd] Also cache failures while indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rL365120: [clangd] Also cache failures while indexing (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D64133: [clangd] Add HadErrors field into shards

This revision was automatically updated to reflect the committed changes. Closed by commit rL365122: [clangd] Add HadErrors field into shards (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D64018: [clangd] Store hash of command line in index shards.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365121: [clangd] Store hash of command line in index shards. (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

This revision was automatically updated to reflect the committed changes. Closed by commit rL365123: [clangd] Make HadErrors part of background index's internal state (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D64019: [clangd] Turn background-index on by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL365124: [clangd] Turn background-index on by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL365132: [clangd] Query driver reads stderr and passes driver as first argument (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This also turns off implicit discovery of additional compilation databases. Repository: rG LLVM Github Monorep

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1088 + + if (Trigger == "/") { // trigger only on '#include.../' +auto StartOfLine = Code->rfind('\n', *Offset); i think instead of regex, it would be better to just per

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208686. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files: clang-tools-ex

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:653 +auto PI = CDB.getProjectInfo(File); +assert(PI && "Found CDB but no ProjectInfo!"); + sammccall wrote: > This looks like a bad assertion: it should be OK to pro

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208697. kadircet added a comment. - Rearrange changes to get a better diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files: clang-tools-extra/clangd/GlobalComp

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208890. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files: clang-tools-ex

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64489 Files: clang-tools-extra/clangd/QueryDri

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

This revision was automatically updated to reflect the committed changes. Closed by commit rL365634: [clangd] Filter out non-governed files from broadcast (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[] = { - Driver, "-E", "-x", driver::ty

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL365776: [clangd][QueryDriver] Use language from underlying database if possible (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:252 -llvm::Optional toHalfOpenFileRange(const SourceManager &Mgr, +// FIXME: Here we check whether the token at the location is a greatergreater +// (>>) token and consider it as a single greate

<    3   4   5   6   7   8   9   10   11   12   >