kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Headers.h:65
struct IncludeGraphNode {
- // True if current file is a main file rather than a header.
- bool IsTU = false;
+ enum class SourceFlag : uint8_t {
+ None = 0,
----------------
sammccall wrote:
> nit: I'd tend to use a plain enum here to avoid the operator boilerplate, but
> up to you
I was more worried about incidental usages like:
```
IncludeGraphNode IGN;
if(IGN.IsTU) blabla;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64133/new/
https://reviews.llvm.org/D64133
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
