[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446763. kadircet added a comment. - Add OOB check as an asssertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-extra/clangd/AST.cpp clang

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:790 +// Skip functions with less parameters, they can't be the target. +if (Callee->parameters().size() < Parameters.size()) + return; upsj wrote: > This is not a sufficient

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446769. kadircet marked an inline comment as done. kadircet added a comment. - Rather than asserting limit the traversal - Have more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://r

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446770. kadircet added a comment. - Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/cl

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446796. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet added a comment. In D130260#3671290 , @sammccall wrote: > driveby thoughts, but please don't block on them. > > (if this fix is a heuristic that fixes a common crash but isn't completely > correct, that may still be worth landing but warrants a

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

This revision was automatically updated to reflect the committed changes. Closed by commit rG4839929bed6e: [clangd] Make forwarding parameter detection logic resilient (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D130260?vs=446796&id=446805#toc Repository: rG LLV

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:89 + return MD; +auto *DeclCtx = cast(MD->getDeclContext()); +if (DeclCtx->isInvalidDecl())

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kadircet closed this revision. kadircet added a comment. Landed as rG9fe89a1f0fa6d88aa4786580b89e81dc906fcc52 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 __

[PATCH] D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching.

kadircet added a comment. Thx, LGTM. I agree that figuring out includes/macros in conditional branches is already best-effort, so I don't think this will result in noticeable regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125179/new/

[PATCH] D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:769 + // So don't bother generating the long version of the predefines buffer. + // The is going to overwrite

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. -

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428072. kadircet added a comment. - Add lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428089. kadircet added a comment. - Mention range as an extension field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPS

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428368. kadircet marked 9 inline comments as done. kadircet added a comment. - Get rid of warning and not advertising when client has capability. - Introduce paddingLeft/paddingRight, get rid of leading/trailing spaces in label, but re-introduce them when se

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:586 + // Only advertise inlayHints extension if client doesn't support the standard + // implementation. sammccall wrote: > I still feel a little uncomfortable with this

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428370. kadircet added a comment. - Advertise inlayHintProvider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428413. kadircet added a comment. - Default initialize paddingLeft/Right - Don't serialize kind when its null - Run in vscode, seems to be working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ htt

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3137ca80b9ef: [clangd] Support for standard inlayHint protocol (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D121733: Clean pathnames in FileManager.

kadircet added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:218 + llvm::sys::path::remove_dots(CleanFilename, /*remove_dot_dot=*/false); + Filename = CleanFilename; + this is actually breaking the [contract of FileEntryRef](https://github.com/l

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:134 + return false; +return inMainFile() ? handleCommentInMainFile(PP, Range) +: handleCommentInHeaderFile(PP, Range); the split seems to be increasi

[PATCH] D125673: [clangd] Add command-line flag to set background indexing thread priority.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM. i agree that having this as a config to let users prioritise some sources over others could be useful, but it's too intrusive and unclear how useful that would be in practice

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

kadircet added a reviewer: kadircet. kadircet added a comment. 66% win sounds great, it would be nice to have some detailed numbers (but this is clearly a huge win, so no need to reperform the experiments if numbers are gone) Comment at: clang-tools-extra/clangd/XRefs.cpp:895

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for noticing this, LGTM! Comment at: clang-tools-extra/clangd/XRefs.cpp:961 const ParsedAST &AST; - const llvm::DenseSet &TargetIDs; + llvm::DenseMap TargetDe

[PATCH] D115232: [clangd] Indexing of standard library

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry for the long turn around here, LGTM. let's ship it! Comment at: clang-tools-extra/clangd/index/StdLib.cpp:233 + // Sadly we can't use IndexOpts.FileFilter to restr

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125684/new/ https://reviews.llvm.org/D125684

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:384 } + void VisitUnresolvedUsingType(const UnresolvedUsingType * UUT) { +Outer.add(UUT->getDecl(), Flags); nit: formatting around `*` Repository: rG LLVM

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

kadircet marked an inline comment as done. kadircet added a comment. In D125863#3522025 , @hokein wrote: > sorry, I might be lack of the context, where is the user complaint? I'm not > sure which cases are improved with this patch. so the complaint was

[PATCH] D125925: Add an option to fill container for ref

kadircet added a comment. Can you also update the remote-index protos & marshalling logic in: - clang-tools-extra/clangd/index/remote/Index.proto - clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp Comment at: clang-tools-extra/clangd/index/Index.h:75 llvm::

[PATCH] D125925: Add an option to fill container for ref

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125925/new/ https://reviews.llvm.org/D125925 __

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. First patch for propogating multifile changes from tweak outputs to LSP WorkspaceEdits. Uses FS to convert toolin

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 216815. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang-too

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:644 + assert(It.second.Edits && "TextEdits hasn't been generated?"); + if (auto Draft = DraftMgr.getDraft(It.first())) { +

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D65433: [clangd] DefineInline action availability checks. Initial version of Defi

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 216823. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:229 +if (const VarDecl *VD = dyn_cast(D)) { + if (VD->isLocalVarDecl()) { +addToken(Loc, HighlightingKind::LocalVariable); nit: `addToken(Loc, VD->isLoc

[PATCH] D65526: [Clangd] First version of ExtractFunction

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:29 +// - Always passed by l-value reference +// - No return +// - Cannot move declarations before extracting did you mean no return *type* ? =

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a first step in documenting different configuration knobs we have in clangd. Repository: rG LLVM Githu

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

kadircet updated this revision to Diff 217154. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66740/new/ https://reviews.llvm.org/D66740 Files: clang-tools-ex

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG3aeed0fd5ad5: [clangd] Add docs for configuration knobs in clangd (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66740/new/ https://r

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added a comment. Thanks! This looks really useful when we can't build an AST due to unknown compiler commands, but I am not sure about how useful it is to surface command-line parsing errors once we are able to build an AST. Because people most likely won't care about these errors once

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

kadircet added a comment. I agree with Ilya's concerns on SourceLocations, even though most of the time user will have the source locations available in the dyntyped node, they might need some traversals to fetch the exact range especially in cases of nested name specifiers. It would be nice to

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added a comment. In D66759#1646599 , @ilya-biryukov wrote: > How common is this? Do we have any particular examples? Well, I don't have any data to prove, but my experience has been so far; most of the people don't touch Makefiles apart from a

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:465 +Diags.insert(Diags.end(), Preamble->Diags.begin(), Preamble->Diags.end()); + // Finally, add diagnostics coming from the AST. + { ilya-biryukov wrote: > kadircet wrote:

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. > Concretely, can you give an example of which node and what you'd want it to > point to? If it's just the single unqualified-name token, I agree and would > like to add it (as a separate

[PATCH] D66759: [clangd] Surface errors from command-line parsing

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66759/new/ https://reviews.llvm.org/D66759 __

[PATCH] D65526: [Clangd] First version of ExtractFunction

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:165 +else + SR.setEnd(ChildFileRange->getEnd()); + } SureYeaah wrote: > kadircet wrote: > > I suppose thi

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked 14 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:601 + llvm::inconvertibleErrorCode(), + "File contents differ on disk for %s, please save", FilePath.data()); +}

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217803. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217806. kadircet added a comment. - Handle formatting error in ClangdServer rather than just printing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 217820. kadircet marked an inline comment as done. kadircet added a comment. - Get rid off compatibility check for files that are not open in the editor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

kadircet added a subscriber: sammccall. kadircet added a comment. Thanks for updating this! Pinging @sammccall since he is also working on writing some release docs, might be helpful to bring this to your attention. Comment at: clang-tools-extra/docs/clangd/Installation.rst:35

[PATCH] D66943: [clangd][NFC] Update background-index command line description

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We didn't change this in D64019 just in case we revert it back. Deleting

[PATCH] D66943: [clangd][NFC] Update background-index command line description

This revision was automatically updated to reflect the committed changes. Closed by commit rL370367: [clangd][NFC] Update background-index command line description (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:5 -## Usage + - code completion + - compile errors and warnings -

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:95 + - use raw strings + - rerame (bound to ``, rather than a contextual code action) + s/rerame/rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D67092: [clangd] Update clangd-vscode docs to be more user-focused.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/README.md:9 + - include management + - code formatting sammccall wrote: > kadircet wrote: > > what about code-actions(and also some screenshots) > Added a section for ref

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked 13 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:414 + if (llvm::Error Err = reformatEdit(E, Style)) { +llvm::handleAllErrors(std::move(Err), [&](llvm::ErrorInfoBase &EIB) { + e

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218637. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The check was generating a fix without taking qualifiers in return type into account. This patch changes the insertion location to be before qualif

[PATCH] D67213: [clang-tidy] Fix definitions in headers check to respect qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371022: [clang-tidy] Fix definitions in headers check to respect qualifiers (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218878. kadircet marked 2 inline comments as done. kadircet added a comment. - Define more strict semantics around filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:130 +/// pointed by FID. +Tweak::Effect fileEdit(const SourceManager &SM, FileID FID, + tooling::Replacements Replacements); kadircet wrote: > kadircet wro

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218883. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 218936. kadircet marked 4 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: cla

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet marked an inline comment as done. kadircet added a comment. In D65433#1661865 , @arphaman wrote: > When fully implemented, will define inline tweak work with C++ methods in > classes as well? Yes you can see an example of it in the tests provid

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:414 + if (llvm::Error Err = reformatEdit(E, Style)) { +llvm::handleAllErrors(std::move(Err), [&](llvm::ErrorInfoBase &EIB) { + elog("Failed to format {0}: {1}", It.first(),

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 219324. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

This revision was automatically updated to reflect the committed changes. Closed by commit rL371392: [clangd] Support multifile edits as output of Tweaks (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

kadircet added a reviewer: kadircet. kadircet added a comment. thanks for taking a look at this! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:447 struct X { - X& [[operator]]++() {} + X& [[operator]]++() { return *this; } };

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:378 +buildRenameEdit(FilePath, *AffectedFileCode, *RenameRanges, NewName, +RenameDecl.getNameAsString()); if (!RenameEdit) { nit: move bo

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71652/new/ https://reviews.llvm.org/D71652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/235 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

kadircet abandoned this revision. kadircet added a comment. nope i haven't, thanks for taking care ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72085/new/ https://reviews.llvm.org/D72085 ___ cfe-com

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGb2eaac3e3e0a: [clangd] Replace shortenNamespace with getQualification (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D71652?vs=23456

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

kadircet added a reviewer: sammccall. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:499 + )cpp", + + R"cpp(// Class template argument deduction could you rather add this test into `FindTargetTests.cpp` ?

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:519 +ASSERT_TRUE(AST.getDiagnostics().empty()) +<< AST.getDiagnostics().begin()->Message

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:140 if (const SelectionTree::Node *N = Selection.commonAncestor()) { -auto Decls = targetDecl(N->ASTNode, Relations); +auto Decls = explicitReferenceTargets(N->ASTNode, Relations); Resu

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Format/Format.cpp:2381 +// if so adds a Replacement to NewReplacements that removes the entire line. +llvm::Error MaybeRemoveBlankLine(tooling::Replacements &NewReplaces, +

[PATCH] D71422: [clangd] Introduce bulletlists

This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGa000f2e53f5c: [clangd] Introduce bulletlists (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D71422?vs=234059&id=236574#toc Reposito

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:695 + DeclRelationSet Relations = DeclRelation::Underlying; + auto Decls = getExplicitDeclAtPosition(AST, SourceLocationBeg, Relations); if (Decls.empty()) instead of creating a n

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:463 + } + // Query the index for references from other files. + if (Index && Results.References.size() < Limit) { could we merge this and the code for decls by only popu

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1021 TEST(FindReferences, NeedsIndex) { + const char *Header = (R"cpp( nit: i don't think there's much benefit in combining refs for macros and symbols in a single

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet marked 23 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:393 +// Converts a string of the form `word1-word2-...` into `Word1 Word2 ...`. +std::string beautify(llvm::StringRef Input) { + std::string Res; --

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236842. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ex

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1093 + + // If the main file is in the index, we don't return duplicates. + // (even if the

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:466 + markup::Paragraph &P = Output.addParagraph(); + P.appendText(beautify(index::getSymbolKindString(Kind))); + if (!Name.empty()) { sammccall wrote: > kadircet wrote: > > sammcca

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236976. kadircet marked 10 inline comments as done. kadircet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ext

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236993. kadircet added a comment. - Change `Value:` to `Value =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-extra/clangd/Hover.cpp clang-to

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

This revision was automatically updated to reflect the committed changes. Closed by commit rG287a874d1c46: [clangd] Refurbish HoverInfo::present (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.or

[PATCH] D72450: [clangd] Improve type printing in hover

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Do not include tag keywords when printing types for symbol names, as it will come from SymbolKind. Also

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. LSP requires diagnostics to lay inside main file. In clangd we keep diagnostics in three different cases: - alread

[PATCH] D72462: [clangd] Fix markdown rendering in VSCode

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Eventough it is OK to have a new line without any preceding spaces in some markdown specifications, VSCod

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:342 +llvm::Optional NoteInsideMainFile; +for (auto &N : D.Notes) { + if (!N.InsideMainFile) ilya-biryukov wrote: > NIT: ar

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

This revision was automatically updated to reflect the committed changes. Closed by commit rG189aa5b7a458: [clangd] Adjust diagnostic range to be inside main file (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72458/new/ https

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet updated this revision to Diff 237105. kadircet marked an inline comment as done. kadircet added a comment. - Use find_if instead of raw loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72458/new/ https://reviews.llvm.org/D72458 Files:

[PATCH] D72450: [clangd] Improve type printing in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rGffd0f116754c: [clangd] Improve type printing in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72450/new/ https://reviews.llvm.

[PATCH] D72462: [clangd] Fix markdown rendering in VSCode

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfa27e4f04d: [clangd] Fix markdown rendering in VSCode (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72462/new/ https://reviews.llv

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/XRefs.cpp:715 + if (auto *CTSD = dyn_cast(CXXRD)) { +if (CTSD->isInvalidDecl()) { + CXXRD = CTSD->getSpeciali

<    13   14   15   16   17   18   19   20   21   22   >