kadircet marked 2 inline comments as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:342
+ llvm::Optional<Note> NoteInsideMainFile;
+ for (auto &N : D.Notes) {
+ if (!N.InsideMainFile)
----------------
ilya-biryukov wrote:
> NIT: arguably simpler with the standard algorithm
> ```
> auto It = llvm::find_if(D.Notes, [](const Node&N) { return N.InsideMainFile;
> });
> assert(It != D.Notes.end());
> ```
>
> Up to you.
agreed, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72458/new/
https://reviews.llvm.org/D72458
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
