kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:769 + // So don't bother generating the long version of the predefines buffer. + // The is going to overwrite it anyway (to almost nothing). + PreprocessorOpts.UsePredefines = false; ---------------- s/The/Preamble > to almost nothing This feels like too much of a detail, i'd probably drop. up to you though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125180/new/ https://reviews.llvm.org/D125180 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
