[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This enables users to wait until async request completes. Taking a response isn't enough, as receiving

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261694. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-ex

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:120 + auto Req = std::move(Requests.front()); + // Leave request on the queue so that waiters can see it. Lock.unlock(); --

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261715. kadircet added a comment. - Call sync instead of waiting on context destruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-extra/clan

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet updated this revision to Diff 261717. kadircet added a comment. - Drop LSP latency test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79302/new/ https://reviews.llvm.org/D79302 Files: clang-tools-extra/clangd/unittests/ClangdLSPServerTe

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet marked 8 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:280 const PreambleData &Baseline) { + assert(llvm::sys::path::is_absolute(FileName) && "relative FileName!"); // F

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet updated this revision to Diff 261745. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https://reviews.llvm.org/D77644 Files: clang-tools-ex

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet updated this revision to Diff 261744. kadircet added a comment. - Rebase, add comments and introduce Inclusion equality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/ https://reviews.llvm.org/D78743 Files: clang-tools-extra/cl

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is only used by documentlink and go-to-definition. We are pushing range detection logic from Inclu

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 261765. kadircet marked an inline comment as done. kadircet added a comment. - Perform line mapping only for includes found through built-in file. - Drop filename range mapping. - Make use of FileChanged events to track being in built-in file. Repository:

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:44 +PreLoc.getColumn()); + PreLoc = SM.getPresumedLoc(FilenameRange.getBegin()); + auto FileNameBe

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet abandoned this revision. kadircet added a comment. as discussed offline there is no real use case for this now and it is unclear whether there will be. dropping it, until we've got a use case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95. Herald added a project: clang. kadircet requested review of this revision. Herald added a subscriber: ilya-biryukov. Currently an Arena can only be built while consuming a TokenBuffer, some users (like clangd) might

[PATCH] D84975: [clangd][WIP] Make use of SyntaxTrees for SemanticSelection

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch is not intended for production, it is merely an experiment to

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix

[PATCH] D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG161882816540: [clang][Syntax] syntax::Arena doesnt own TokenBuffer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84973/new/ https://

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

kadircet added a comment. In D84839#2187222 , @ilya-golovenko wrote: > @kadircet I decided to add `OnlyChildren` to `enum VisitKind` instead of > making a `VisitKindSet` - this helped to minimize the changes in > `shouldVisit()`. What do you think? SG

[PATCH] D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. The logic was using incorrect flag versions. For example: - `-target=` can't be a prefix, it must be `--target=`. -

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. This skips searching for `target` related flags in the existing args if we don't have a valid target to insert. Dep

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know if i should land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

kadircet added a comment. please note that this might require special handling for go-to-def. as go-to-def only jumps to canonical decl and in operator new's case the user provided one might not be canonical, whereas the canonical one is likely builtin without a source info. also you have a ty

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:241 auto AddResultDecl = [&](const NamedDecl *D) { +// FIXME: C++ global operator new/delete are impli

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

This revision was automatically updated to reflect the committed changes. Closed by commit rGd76057c1fe6a: Add document outline symbols from unnamed contexts, e.g. extern "C". (authored by ilya-golovenko, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:264 + // No need to search for target args if we don't have a mode to insert. + bool AlreadyHasTarget = !TargetMode.TargetIsValid; bool AlreadyHasMode = false; hokein wrote: > While th

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

kadircet added a comment. I can see how this can cause problems with current implementation, but I don't think the proposed solution in here is also solving these problems. For example, `MSGuidDecl`'s DeclName is actually empty (it is the printName overload that makes it meaningful). Hence when

[PATCH] D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names

This revision was automatically updated to reflect the committed changes. Closed by commit rG87de54dbb6ef: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet updated this revision to Diff 282557. kadircet added a comment. - Rename `AlreadyHas` to `ShouldAdd` (and revert the logic) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85077/new/ https://reviews.llvm.org/D85077 Files: clang/lib/Toolin

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet updated this revision to Diff 282584. kadircet added a comment. - Change bitwise assignment to logical operators, as bitwise operators do not have short-circuting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85077/new/ https://reviews.l

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76c3ec814dec: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes (authored by kadircet). Repository: rG LLVM Github Monorepo CHA

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

kadircet added a comment. Sigh, (I think) this is working for macros defined in preamble region as a side effect of preamble being loaded separately and before anything in the main file. E.g. #define FO^O 1 #define FOO 2 void foo() { int x = FOO; }; hovering over the first definition

[PATCH] D85291: [clangd] Fix a crash in DefineInline

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D85291: [clangd] Fix a crash in DefineInline

This revision was automatically updated to reflect the committed changes. Closed by commit rG011732852c2c: [clangd] Fix a crash in DefineInline (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85291/new/ https://reviews.llvm.org

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet updated this revision to Diff 283266. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/ https://reviews.llvm.org/D85310 Files: clang-tools-ex

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:393 +if (auto *PT = Source->getDescribedFunctionTemplate()) { + if (PT->getTemplatedDecl() == Source) +return false;

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

kadircet added a comment. > I'm not quite sure there should be no tooltip for a #define. Such tooltip is > not really useful, but at the same time clangd shows tooltips for function > declarations/defnitions, namespaces, variables, etc. and not showing it for > macro definition will be a little

[PATCH] D85318: [clangd] Hide "swap if branch" tweak

kadircet added a comment. you might want this to be cherry-picked into 11 release Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85318/new/ https://reviews.llvm.org/D85318 ___ cfe-commits mailing list cfe

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ac30188666: [clangd] Disable define out-of-line code action on templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/

[PATCH] D85354: [clangd] Reduce availability of extract function

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch introduces hoisting det

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

kadircet added a comment. Regarding tests, it feels like we can also test this in ASTUnitTests which is directly in clang, as it is also using PrecompiledPreamble::Build. What about moving the test there instead? Comment at: clang-tools-extra/clangd/unittests/ModulesTests.cpp

[PATCH] D85502: [clangd] Add more error details on the remote index server side

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:322 +return makeStringError( +llvm::formatv("Can not use URI schemes other

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. This was resulting in inserting headers at bogus locations, see https://github.com/ycm-core/YouCompleteMe/issues/373

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:143 + std::function ContextProvider = nullptr, + bool CollectMainFileRefs = true); ~BackgroundIndex(); // Blocks while the current task finishes. please set the d

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:144 + CInvok, PCHContainerOps, Diags, FileMgr, false, CaptureDiagsKind::None, 1, + TU_Comple

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. fixes https://github.com/clangd/clang

[PATCH] D85727: [clangd] Disable ExtractFunction for C

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This tweak uses constructs like auto

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

kadircet updated this revision to Diff 284694. kadircet added a comment. - Drop the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85721/new/ https://reviews.llvm.org/D85721 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[PATCH] D85727: [clangd] Disable ExtractFunction for C

This revision was automatically updated to reflect the committed changes. Closed by commit rG24a816c7d392: [clangd] Disable ExtractFunction for C (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85727/new/ https://reviews.llvm.o

[PATCH] D85721: [clangd] Unify macro matching in code completion for AST and Index based macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb626f45329e8: [clangd] Unify macro matching in code completion for AST and Index based macros (authored by kadircet). Repository: rG LLVM Github M

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

kadircet updated this revision to Diff 284702. kadircet added a comment. - Move new test closer to other FakeHeaderGuard tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85590/new/ https://reviews.llvm.org/D85590 Files: clang/lib/Tooling/Inc

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea8e71c3da56: [clang][HeaderInsert] Do not treat defines with values as header guards (authored by kadircet). Repository: rG LLVM Github Monorepo

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added a comment. thanks, lgtm. mostly comments arounds tests, sorry for not looking at them before. Comment at: clang-tools-extra/clangd/index/FileIndex.h:156 /// Exposed to assist in unit tests. -SlabTuple indexMainDecls(ParsedAST &AST); +SlabTuple indexMainDecls(Pa

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); can't we rather reco

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added a subscriber: ilya-biryukov. Fixes https://github.com/clangd/clangd/issues

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:210 GetClangTidyOptions(*TFS.view(/*CWD=*/llvm::None), File); + if (!Opts.ClangTidyOpts.Checks) { +// If the user hasn't configured clang-tidy checks at all, including

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:209 // Update diag to point at include inside main file. D.File = SM.getFileEntryForID(SM.getMainFileID())->getName().str(); D.Range = std::move(R); adamcz wrote: > kadi

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285116. kadircet added a comment. - Add tests into clang-lit - Make sure current number of args is less than overloads param count. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285117. kadircet marked 2 inline comments as done. kadircet added a comment. - Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85826/new/ https://reviews.llvm.org/D85826 Files: clang-tools

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5573 + // performing any semantic checks on availability. That's to improve user + // experience, it is better to see all overloads rather than none. + if (Expr::hasAnyTypeDependentArguments(Args))

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet updated this revision to Diff 285141. kadircet added a comment. - Change logic to find all signatures without any dependent args and post filter non-viable overloads using the argument counts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives = aaron.ballman wrote: > njames93 wrote: > >

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

kadircet added a comment. mostly looks good to me, as discussed offline I would rather expose AST within a thread, both to keep the API changes to a minimum in the future and possibly indicating the "view-ness" of the exposed structs like AST more explicitly. Repository: rG LLVM Github Monor

[PATCH] D85883: [clangd] Add ClangdServer::customAction() extension point

kadircet added a comment. no I am totally fine with the change. I just wanted to give Adam some time to take a look too :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85883/new/ https://reviews.llvm.org/D85883 __

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet marked 19 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to crashes or false positives. +const char *getClangTidyBlacklist() { + static const std::string FalsePositives =

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

kadircet updated this revision to Diff 285389. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83224/new/ https://reviews.llvm.org/D83224 Files: clang-tools-ex

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

This revision was automatically updated to reflect the committed changes. Closed by commit rG66a2e3a52564: [clangd] Send EOF before resetting diagnostics consumer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83178/new/ https

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0464acd0197c: [clangd] Move clang-tidy check modifications into ClangdServer (authored by kadircet). Changed prior to commit: https://reviews.llvm

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSy

[PATCH] D85826: [clang] Make signature help work with dependent args

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5513 for (OverloadCandidate &Candidate : CandidateSet) { -if (Candidate.Function && Candidate.Function->isDeleted()) - continue; +if (Candidate.Function) { + if (Candidate.Functio

[PATCH] D85826: [clang] Make signature help work with dependent args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53c593c2c893: [clang] Make signature help work with dependent args (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet created this revision. kadircet added reviewers: sammccall, adamcz. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, javed.absar. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Introduces a

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:172 +for (const auto &Elem : LRU) + TotalBytes += Elem.second->getUsedBytes(); +return TotalBytes; adamcz wrote: > Any idea how expensive this is? I suppose TUSchedu

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet marked 8 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1309 +// fileStats results include ast cache sizes too, subtract them. +PreambleBytes -= ASTCacheBytes; + } adamcz wrote: > So

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet updated this revision to Diff 286043. kadircet marked an inline comment as done. kadircet added a comment. - Rename the overload - Add comments around possible caveats that might result in inaccuracies. - Move the metric recording itself into another thread. - Keep the calculations in the

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:727 + // Run the collector again with CollectMainFileRefs = true. + InMemoryFileSystem = new llvm::vfs::InMemoryFileSystem(); + CollectorOpts.CollectMainFileRefs = true; ---

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet updated this revision to Diff 261845. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79315/new/ https://reviews.llvm.org/D79315 Files: clang-tools-ex

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:610 +auto FileRange = +syntax::FileRange(SM, FileTok->location(), Inc.Written.length()) +.toCharRange(SM); sammccall

[PATCH] D79315: [clangd] Get rid of Inclusion::R

This revision was automatically updated to reflect the committed changes. Closed by commit rGd870016bfce8: [clangd] Get rid of Inclusion::R (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79315/new/ https://reviews.llvm.org/D79

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262057. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-e

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:39 SrcMgr::CharacteristicKind FileKind) override { -if (isInsideMainFile(HashLoc, SM)) { +auto AddMainFileInc = [&](SourceLocation HashLoc) { Out->MainFileIn

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet updated this revision to Diff 262107. kadircet marked 5 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/ https://reviews.llvm.org/D78743 Files: cla

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet updated this revision to Diff 262132. kadircet added a comment. - Add test Lexing until the

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

kadircet updated this revision to Diff 262132. kadircet added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79426/new/ https://reviews.llvm.org/D79426 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262324. kadircet added a comment. - Try to fix windows builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https://reviews.llvm.org/D78740 Files: clang-tools-extra/clangd/Headers.cpp clang-too

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f7917c269d6: [clangd] Handle PresumedLocations in IncludeCollector (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/ https:/

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 262374. kadircet added a comment. - use basename in tests as having unescaped backslashes breaks windows build bots. going to address that separetely in line directive generation logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet updated this revision to Diff 262381. kadircet added a comment. - Escape backslashes and quotes while generating line directive for filename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/ https://reviews.llvm.org/D78743 Files:

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d6d48add8a8: [clangd] Reland 'Handle PresumedLocations in IncludeCollector' (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78740/new/

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

This revision was automatically updated to reflect the committed changes. Closed by commit rG717bef662329: [clangd] Preserve line information while build PreamblePatch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78743/new/

[PATCH] D79669: [clangd] Filter pch related flags coming from the user

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. PCH format is unstable, hence using a preamble built with a different version of clang (or even

[PATCH] D79678: [clangd] Add CSV export for trace metrics

kadircet accepted this revision. kadircet marked 2 inline comments as done. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/support/Trace.cpp:210 +assert(!needsQuote(Metric.Name)); +std::strin

[PATCH] D79669: [clangd] Filter pch related flags coming from the user

This revision was automatically updated to reflect the committed changes. Closed by commit rG35d867a790c2: [clangd] Filter pch related flags coming from the user (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79669/new/ https:

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We were serializing it no matter what, which was against the spec Repository: rG LLVM Github Monore

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9fefec4368: [clangd] Make version in PublishDiagnosticsParams optional (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79692?vs=263084&id=263117#toc Repository: rG LLVM G

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Could you also put `Fixes https://github.com/clangd/clangd/issues/375` in the commit message? Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTe

[PATCH] D79879: [clangd] Change getSymbolID to accept macro location instead of macro info

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a child revision: D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo. Repository: rG LLVM Github

[PATCH] D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79879 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79881 Files: clang

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D77644 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79930 Files: clang

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet retitled this revision from "[clangd] Patch PP directives to use stale preambles while buildin

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 264567. kadircet added a comment. - Only store defines - Make use of source text directly instead of printing tokens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Fi

<    10   11   12   13   14   15   16   17   18   19   >