kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM, thanks! Could you also put `Fixes https://github.com/clangd/clangd/issues/375` in the commit message? ================ Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:381 int i = 3; double f = [[8]] / i; // NOLINT // error-ok } ---------------- you can also drop the `// error-ok` now as there are no diags left. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79691/new/ https://reviews.llvm.org/D79691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
